https://github.com/torvalds/linux
Revision caebd1b389708bf3d0465be829480fc706a68720 authored by Nir Dotan on 03 August 2018, 12:57:44 UTC, committed by David S. Miller on 03 August 2018, 19:28:01 UTC
In previous patch mlxsw_afa_resource_del() was added to avoid a duplicate
resource detruction scenario.
For mirror actions, such duplicate destruction leads to a crash as in:
# tc qdisc add dev swp49 ingress
# tc filter add dev swp49 parent ffff: \
protocol ip chain 100 pref 10 \
flower skip_sw dst_ip 192.168.101.1 action drop
# tc filter add dev swp49 parent ffff: \
protocol ip pref 10 \
flower skip_sw dst_ip 192.168.101.1 action goto chain 100 \
action mirred egress mirror dev swp4
Therefore add a call to mlxsw_afa_resource_del() in
mlxsw_afa_mirror_destroy() in order to clear that resource
from rule's resources.
Fixes: d0d13c1858a1 ("mlxsw: spectrum_acl: Add support for mirror action")
Signed-off-by: Nir Dotan <nird@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7cc6169
Tip revision: caebd1b389708bf3d0465be829480fc706a68720 authored by Nir Dotan on 03 August 2018, 12:57:44 UTC
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
Tip revision: caebd1b
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.2 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| README | -rw-r--r-- | 7.9 KB |
| acl.h | -rw-r--r-- | 1.8 KB |
| bitmap.c | -rw-r--r-- | 39.6 KB |
| dir.c | -rw-r--r-- | 9.0 KB |
| do_balan.c | -rw-r--r-- | 54.3 KB |
| file.c | -rw-r--r-- | 7.5 KB |
| fix_node.c | -rw-r--r-- | 77.4 KB |
| hashes.c | -rw-r--r-- | 3.5 KB |
| ibalance.c | -rw-r--r-- | 34.3 KB |
| inode.c | -rw-r--r-- | 92.3 KB |
| ioctl.c | -rw-r--r-- | 5.3 KB |
| item_ops.c | -rw-r--r-- | 18.2 KB |
| journal.c | -rw-r--r-- | 120.4 KB |
| lbalance.c | -rw-r--r-- | 41.3 KB |
| lock.c | -rw-r--r-- | 2.6 KB |
| namei.c | -rw-r--r-- | 43.8 KB |
| objectid.c | -rw-r--r-- | 6.8 KB |
| prints.c | -rw-r--r-- | 21.4 KB |
| procfs.c | -rw-r--r-- | 13.0 KB |
| reiserfs.h | -rw-r--r-- | 116.6 KB |
| resize.c | -rw-r--r-- | 6.3 KB |
| stree.c | -rw-r--r-- | 64.0 KB |
| super.c | -rw-r--r-- | 70.0 KB |
| tail_conversion.c | -rw-r--r-- | 9.2 KB |
| xattr.c | -rw-r--r-- | 24.2 KB |
| xattr.h | -rw-r--r-- | 3.7 KB |
| xattr_acl.c | -rw-r--r-- | 9.6 KB |
| xattr_security.c | -rw-r--r-- | 2.7 KB |
| xattr_trusted.c | -rw-r--r-- | 1.2 KB |
| xattr_user.c | -rw-r--r-- | 1.1 KB |
Computing file changes ...
