Skip to main content

Browse the archive

https://github.com/mozilla/gecko-dev
16 June 2024, 00:10:27 UTC
Revision cb967789c50c1f13b9679743eaae5ea78c089b9b authored by Brian Birtles on 28 May 2014, 07:51:49 UTC, committed by Brian Birtles on 28 May 2014, 07:51:49 UTC 
Bug 1004871 part 8 - Simplify ElementAnimations::GetEventsAt; r=dholbert
 
This patch shuffles the code in ElementAnimations::GetEventsAt to make it easier
to follow.

It also removes a check for whether or not the animation is paused.
Previously we would not dispatch events if the animation was paused and in its
active phase (but we would if the animation had finished). There doesn't seem to
be any reason for this. If the animation was paused between the last sample and
the current sample and the boundary of an iteration also occurred in that time
then I expect we should dispatch that event. Removing this check for the pause
state does not cause any tests fail.

Separating out the event logic here makes it clear that we do not dispatch start
events in the situation where one sample falls before the active interval and
one sample falls after it (filed as bug 1004361). This patch adds a comment to
this effect.
1 parent 3ce242e
History
Tip revision: cb967789c50c1f13b9679743eaae5ea78c089b9b authored by Brian Birtles on 28 May 2014, 07:51:49 UTC
Bug 1004871 part 8 - Simplify ElementAnimations::GetEventsAt; r=dholbert
Tip revision: cb96778
File Mode Size
accessible
addon-sdk
b2g
browser
build
caps
chrome
config
content
db
docshell
dom
editor
embedding
extensions
gfx
hal
image
intl
ipc
js
layout
media
memory
mfbt
mobile
modules
mozglue
netwerk
nsprpub
other-licenses
parser
probes
profile
python
rdf
security
services
startupcache
storage
testing
toolkit
tools
uriloader
view
webapprt
widget
xpcom
xpfe
xulrunner
.clang-format -rw-r--r-- 22 bytes
.clang-format-ignore -rw-r--r-- 26 bytes
.gdbinit -rw-r--r-- 4.9 KB
.gitignore -rw-r--r-- 1.1 KB
.hgignore -rw-r--r-- 1.3 KB
.hgtags -rw-r--r-- 6.3 KB
.lldbinit -rw-r--r-- 1.6 KB
.reviewboardrc -rw-r--r-- 253 bytes
AUTHORS -rw-r--r-- 33.4 KB
Android.mk -rw-r--r-- 284 bytes
CLOBBER -rw-r--r-- 1.1 KB
LEGAL -rw-r--r-- 2.5 KB
LICENSE -rw-r--r-- 389 bytes
Makefile.in -rw-r--r-- 9.7 KB
README.txt -rw-r--r-- 1.2 KB
aclocal.m4 -rw-r--r-- 1.8 KB
client.mk -rw-r--r-- 15.0 KB
client.py -rwxr-xr-x 5.7 KB
configure.in -rw-r--r-- 306.3 KB
mach -rwxr-xr-x 2.2 KB
moz.build -rw-r--r-- 2.0 KB
mozilla-config.h.in -rw-r--r-- 2.0 KB

README.txt

back to top