Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 09:02:56 UTC
Revision cd529a46e17b43976d05c1e2ece2676ec7941cc8 authored by Mike Christie on 16 October 2006, 22:09:40 UTC, committed by James Bottomley on 25 October 2006, 22:13:57 UTC 
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path
 
from bhalevy@gmail.com:

It looks like change 652 to libiscsi.c added some dead code around line
670
                if (rc) {
                        spin_unlock_bh(&conn->session->lock);
                        goto again;
                }

since 5 lines above we goto again if (rc).

It looks like the previous if (rc) should go away if we want to put the
ctask before
breaking out of the while loop with "goto again" (see following patch).

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
1 parent 9864404
History
Tip revision: cd529a46e17b43976d05c1e2ece2676ec7941cc8 authored by Mike Christie on 16 October 2006, 22:09:40 UTC
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path
Tip revision: cd529a4
File Mode Size
Documentation
arch
block
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
scripts
security
sound
usr
.gitignore -rw-r--r-- 542 bytes
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 88.2 KB
Kbuild -rw-r--r-- 1.2 KB
MAINTAINERS -rw-r--r-- 73.2 KB
Makefile -rw-r--r-- 48.8 KB
README -rw-r--r-- 16.2 KB
REPORTING-BUGS -rw-r--r-- 3.0 KB

README

back to top