Revision cdd97383e19d4afe29adc3376025a15ae3bab3a3 authored by Dan Carpenter on 07 December 2022, 07:06:31 UTC, committed by Jakub Kicinski on 08 December 2022, 17:09:36 UTC
In an earlier commit, I added a bounds check to prevent an out of bounds read and a WARN(). On further discussion and consideration that check was probably too aggressive. Instead of returning -EINVAL, a better fix would be to just prevent the out of bounds read but continue the process. Background: The value of "pp->rxq_def" is a number between 0-7 by default, or even higher depending on the value of "rxq_number", which is a module parameter. If the value is more than the number of available CPUs then it will trigger the WARN() in cpu_max_bits_warn(). Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()") Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed14e59
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 735 bytes |
Makefile | -rw-r--r-- | 408 bytes |
ast.c | -rw-r--r-- | 8.3 KB |
ast.h | -rw-r--r-- | 1.1 KB |
config.c | -rw-r--r-- | 23.2 KB |
config.h | -rw-r--r-- | 1.5 KB |
debug_fs.c | -rw-r--r-- | 21.5 KB |
dir.c | -rw-r--r-- | 7.3 KB |
dir.h | -rw-r--r-- | 889 bytes |
dlm_internal.h | -rw-r--r-- | 21.5 KB |
lock.c | -rw-r--r-- | 163.4 KB |
lock.h | -rw-r--r-- | 3.6 KB |
lockspace.c | -rw-r--r-- | 22.3 KB |
lockspace.h | -rw-r--r-- | 1.3 KB |
lowcomms.c | -rw-r--r-- | 47.4 KB |
lowcomms.h | -rw-r--r-- | 1.9 KB |
lvb_table.h | -rw-r--r-- | 541 bytes |
main.c | -rw-r--r-- | 1.9 KB |
member.c | -rw-r--r-- | 16.4 KB |
member.h | -rw-r--r-- | 1.3 KB |
memory.c | -rw-r--r-- | 3.1 KB |
memory.h | -rw-r--r-- | 1.2 KB |
midcomms.c | -rw-r--r-- | 37.9 KB |
midcomms.h | -rw-r--r-- | 1.5 KB |
netlink.c | -rw-r--r-- | 2.9 KB |
plock.c | -rw-r--r-- | 11.5 KB |
rcom.c | -rw-r--r-- | 17.0 KB |
rcom.h | -rw-r--r-- | 987 bytes |
recover.c | -rw-r--r-- | 22.8 KB |
recover.h | -rw-r--r-- | 1.3 KB |
recoverd.c | -rw-r--r-- | 8.8 KB |
recoverd.h | -rw-r--r-- | 781 bytes |
requestqueue.c | -rw-r--r-- | 5.0 KB |
requestqueue.h | -rw-r--r-- | 736 bytes |
user.c | -rw-r--r-- | 25.3 KB |
user.h | -rw-r--r-- | 440 bytes |
util.c | -rw-r--r-- | 1.6 KB |
util.h | -rw-r--r-- | 545 bytes |
Computing file changes ...