Revision cdd97383e19d4afe29adc3376025a15ae3bab3a3 authored by Dan Carpenter on 07 December 2022, 07:06:31 UTC, committed by Jakub Kicinski on 08 December 2022, 17:09:36 UTC
In an earlier commit, I added a bounds check to prevent an out of bounds
read and a WARN(). On further discussion and consideration that check
was probably too aggressive. Instead of returning -EINVAL, a better fix
would be to just prevent the out of bounds read but continue the process.
Background: The value of "pp->rxq_def" is a number between 0-7 by default,
or even higher depending on the value of "rxq_number", which is a module
parameter. If the value is more than the number of available CPUs then
it will trigger the WARN() in cpu_max_bits_warn().
Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed14e59
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 283 bytes |
| alloc.c | -rw-r--r-- | 24.2 KB |
| alloc.h | -rw-r--r-- | 3.2 KB |
| bmap.c | -rw-r--r-- | 14.4 KB |
| bmap.h | -rw-r--r-- | 7.8 KB |
| btnode.c | -rw-r--r-- | 7.0 KB |
| btnode.h | -rw-r--r-- | 1.4 KB |
| btree.c | -rw-r--r-- | 62.7 KB |
| btree.h | -rw-r--r-- | 2.0 KB |
| cpfile.c | -rw-r--r-- | 25.4 KB |
| cpfile.h | -rw-r--r-- | 1.1 KB |
| dat.c | -rw-r--r-- | 12.7 KB |
| dat.h | -rw-r--r-- | 1.7 KB |
| dir.c | -rw-r--r-- | 16.5 KB |
| direct.c | -rw-r--r-- | 8.7 KB |
| direct.h | -rw-r--r-- | 634 bytes |
| export.h | -rw-r--r-- | 505 bytes |
| file.c | -rw-r--r-- | 3.7 KB |
| gcinode.c | -rw-r--r-- | 5.2 KB |
| ifile.c | -rw-r--r-- | 5.2 KB |
| ifile.h | -rw-r--r-- | 1.1 KB |
| inode.c | -rw-r--r-- | 32.8 KB |
| ioctl.c | -rw-r--r-- | 35.1 KB |
| mdt.c | -rw-r--r-- | 15.9 KB |
| mdt.h | -rw-r--r-- | 3.6 KB |
| namei.c | -rw-r--r-- | 12.6 KB |
| nilfs.h | -rw-r--r-- | 12.6 KB |
| page.c | -rw-r--r-- | 13.2 KB |
| page.h | -rw-r--r-- | 1.9 KB |
| recovery.c | -rw-r--r-- | 23.5 KB |
| segbuf.c | -rw-r--r-- | 12.0 KB |
| segbuf.h | -rw-r--r-- | 5.5 KB |
| segment.c | -rw-r--r-- | 74.2 KB |
| segment.h | -rw-r--r-- | 7.8 KB |
| sufile.c | -rw-r--r-- | 31.8 KB |
| sufile.h | -rw-r--r-- | 4.2 KB |
| super.c | -rw-r--r-- | 34.8 KB |
| sysfs.c | -rw-r--r-- | 30.8 KB |
| sysfs.h | -rw-r--r-- | 5.2 KB |
| the_nilfs.c | -rw-r--r-- | 20.1 KB |
| the_nilfs.h | -rw-r--r-- | 11.3 KB |
Computing file changes ...
