Revision cdd97383e19d4afe29adc3376025a15ae3bab3a3 authored by Dan Carpenter on 07 December 2022, 07:06:31 UTC, committed by Jakub Kicinski on 08 December 2022, 17:09:36 UTC
In an earlier commit, I added a bounds check to prevent an out of bounds
read and a WARN(). On further discussion and consideration that check
was probably too aggressive. Instead of returning -EINVAL, a better fix
would be to just prevent the out of bounds read but continue the process.
Background: The value of "pp->rxq_def" is a number between 0-7 by default,
or even higher depending on the value of "rxq_number", which is a module
parameter. If the value is more than the number of available CPUs then
it will trigger the WARN() in cpu_max_bits_warn().
Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed14e59
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.3 KB |
| Makefile | -rw-r--r-- | 459 bytes |
| aops.c | -rw-r--r-- | 51.6 KB |
| aops.h | -rw-r--r-- | 3.1 KB |
| attrib.c | -rw-r--r-- | 89.4 KB |
| attrib.h | -rw-r--r-- | 3.5 KB |
| bitmap.c | -rw-r--r-- | 4.7 KB |
| bitmap.h | -rw-r--r-- | 2.8 KB |
| collate.c | -rw-r--r-- | 2.8 KB |
| collate.h | -rw-r--r-- | 934 bytes |
| compress.c | -rw-r--r-- | 28.0 KB |
| debug.c | -rw-r--r-- | 4.0 KB |
| debug.h | -rw-r--r-- | 1.5 KB |
| dir.c | -rw-r--r-- | 50.8 KB |
| dir.h | -rw-r--r-- | 908 bytes |
| endian.h | -rw-r--r-- | 1.4 KB |
| file.c | -rw-r--r-- | 59.4 KB |
| index.c | -rw-r--r-- | 14.0 KB |
| index.h | -rw-r--r-- | 4.7 KB |
| inode.c | -rw-r--r-- | 96.3 KB |
| inode.h | -rw-r--r-- | 10.3 KB |
| layout.h | -rw-r--r-- | 96.2 KB |
| lcnalloc.c | -rw-r--r-- | 31.6 KB |
| lcnalloc.h | -rw-r--r-- | 4.9 KB |
| logfile.c | -rw-r--r-- | 27.4 KB |
| logfile.h | -rw-r--r-- | 12.8 KB |
| malloc.h | -rw-r--r-- | 2.3 KB |
| mft.c | -rw-r--r-- | 98.6 KB |
| mft.h | -rw-r--r-- | 3.2 KB |
| mst.c | -rw-r--r-- | 6.2 KB |
| namei.c | -rw-r--r-- | 13.3 KB |
| ntfs.h | -rw-r--r-- | 4.2 KB |
| quota.c | -rw-r--r-- | 2.9 KB |
| quota.h | -rw-r--r-- | 432 bytes |
| runlist.c | -rw-r--r-- | 58.7 KB |
| runlist.h | -rw-r--r-- | 2.6 KB |
| super.c | -rw-r--r-- | 98.7 KB |
| sysctl.c | -rw-r--r-- | 1.5 KB |
| sysctl.h | -rw-r--r-- | 613 bytes |
| time.h | -rw-r--r-- | 2.8 KB |
| types.h | -rw-r--r-- | 1.3 KB |
| unistr.c | -rw-r--r-- | 11.4 KB |
| upcase.c | -rw-r--r-- | 3.1 KB |
| usnjrnl.c | -rw-r--r-- | 1.9 KB |
| usnjrnl.h | -rw-r--r-- | 8.4 KB |
| volume.h | -rw-r--r-- | 6.1 KB |
Computing file changes ...
