Revision cdd97383e19d4afe29adc3376025a15ae3bab3a3 authored by Dan Carpenter on 07 December 2022, 07:06:31 UTC, committed by Jakub Kicinski on 08 December 2022, 17:09:36 UTC
In an earlier commit, I added a bounds check to prevent an out of bounds read and a WARN(). On further discussion and consideration that check was probably too aggressive. Instead of returning -EINVAL, a better fix would be to just prevent the out of bounds read but continue the process. Background: The value of "pp->rxq_def" is a number between 0-7 by default, or even higher depending on the value of "rxq_number", which is a module parameter. If the value is more than the number of available CPUs then it will trigger the WARN() in cpu_max_bits_warn(). Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()") Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed14e59
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 665 bytes |
Makefile | -rw-r--r-- | 288 bytes |
balloc.c | -rw-r--r-- | 18.4 KB |
dir.c | -rw-r--r-- | 6.1 KB |
directory.c | -rw-r--r-- | 5.8 KB |
ecma_167.h | -rw-r--r-- | 21.7 KB |
file.c | -rw-r--r-- | 7.5 KB |
ialloc.c | -rw-r--r-- | 3.6 KB |
inode.c | -rw-r--r-- | 67.0 KB |
lowlevel.c | -rw-r--r-- | 1.5 KB |
misc.c | -rw-r--r-- | 7.9 KB |
namei.c | -rw-r--r-- | 34.1 KB |
osta_udf.h | -rw-r--r-- | 8.8 KB |
partition.c | -rw-r--r-- | 8.7 KB |
super.c | -rw-r--r-- | 67.0 KB |
symlink.c | -rw-r--r-- | 4.3 KB |
truncate.c | -rw-r--r-- | 7.9 KB |
udf_i.h | -rw-r--r-- | 1.8 KB |
udf_sb.h | -rw-r--r-- | 4.1 KB |
udfdecl.h | -rw-r--r-- | 8.9 KB |
udfend.h | -rw-r--r-- | 1.6 KB |
udftime.c | -rw-r--r-- | 3.2 KB |
unicode.c | -rw-r--r-- | 9.2 KB |
Computing file changes ...