Revision cdd97383e19d4afe29adc3376025a15ae3bab3a3 authored by Dan Carpenter on 07 December 2022, 07:06:31 UTC, committed by Jakub Kicinski on 08 December 2022, 17:09:36 UTC
In an earlier commit, I added a bounds check to prevent an out of bounds read and a WARN(). On further discussion and consideration that check was probably too aggressive. Instead of returning -EINVAL, a better fix would be to just prevent the out of bounds read but continue the process. Background: The value of "pp->rxq_def" is a number between 0-7 by default, or even higher depending on the value of "rxq_number", which is a module parameter. If the value is more than the number of available CPUs then it will trigger the WARN() in cpu_max_bits_warn(). Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()") Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed14e59
File | Mode | Size |
---|---|---|
libxfs | ||
scrub | ||
Kconfig | -rw-r--r-- | 6.3 KB |
Makefile | -rw-r--r-- | 3.9 KB |
kmem.c | -rw-r--r-- | 681 bytes |
kmem.h | -rw-r--r-- | 1.9 KB |
mrlock.h | -rw-r--r-- | 1.6 KB |
xfs.h | -rw-r--r-- | 371 bytes |
xfs_acl.c | -rw-r--r-- | 6.3 KB |
xfs_acl.h | -rw-r--r-- | 864 bytes |
xfs_aops.c | -rw-r--r-- | 16.8 KB |
xfs_aops.h | -rw-r--r-- | 402 bytes |
xfs_attr_inactive.c | -rw-r--r-- | 9.7 KB |
xfs_attr_item.c | -rw-r--r-- | 23.7 KB |
xfs_attr_item.h | -rw-r--r-- | 1.7 KB |
xfs_attr_list.c | -rw-r--r-- | 13.2 KB |
xfs_bio_io.c | -rw-r--r-- | 1.2 KB |
xfs_bmap_item.c | -rw-r--r-- | 18.7 KB |
xfs_bmap_item.h | -rw-r--r-- | 2.2 KB |
xfs_bmap_util.c | -rw-r--r-- | 48.3 KB |
xfs_bmap_util.h | -rw-r--r-- | 2.6 KB |
xfs_buf.c | -rw-r--r-- | 57.9 KB |
xfs_buf.h | -rw-r--r-- | 11.7 KB |
xfs_buf_item.c | -rw-r--r-- | 28.6 KB |
xfs_buf_item.h | -rw-r--r-- | 2.4 KB |
xfs_buf_item_recover.c | -rw-r--r-- | 29.5 KB |
xfs_dir2_readdir.c | -rw-r--r-- | 13.7 KB |
xfs_discard.c | -rw-r--r-- | 5.5 KB |
xfs_discard.h | -rw-r--r-- | 229 bytes |
xfs_dquot.c | -rw-r--r-- | 34.7 KB |
xfs_dquot.h | -rw-r--r-- | 6.1 KB |
xfs_dquot_item.c | -rw-r--r-- | 5.2 KB |
xfs_dquot_item.h | -rw-r--r-- | 498 bytes |
xfs_dquot_item_recover.c | -rw-r--r-- | 5.1 KB |
xfs_error.c | -rw-r--r-- | 13.0 KB |
xfs_error.h | -rw-r--r-- | 3.3 KB |
xfs_export.c | -rw-r--r-- | 5.8 KB |
xfs_export.h | -rw-r--r-- | 1.4 KB |
xfs_extent_busy.c | -rw-r--r-- | 15.4 KB |
xfs_extent_busy.h | -rw-r--r-- | 1.9 KB |
xfs_extfree_item.c | -rw-r--r-- | 21.8 KB |
xfs_extfree_item.h | -rw-r--r-- | 2.9 KB |
xfs_file.c | -rw-r--r-- | 36.8 KB |
xfs_filestream.c | -rw-r--r-- | 8.7 KB |
xfs_filestream.h | -rw-r--r-- | 788 bytes |
xfs_fsmap.c | -rw-r--r-- | 25.9 KB |
xfs_fsmap.h | -rw-r--r-- | 1.0 KB |
xfs_fsops.c | -rw-r--r-- | 15.4 KB |
xfs_fsops.h | -rw-r--r-- | 705 bytes |
xfs_globals.c | -rw-r--r-- | 1.4 KB |
xfs_health.c | -rw-r--r-- | 9.4 KB |
xfs_icache.c | -rw-r--r-- | 55.3 KB |
xfs_icache.h | -rw-r--r-- | 2.8 KB |
xfs_icreate_item.c | -rw-r--r-- | 7.6 KB |
xfs_icreate_item.h | -rw-r--r-- | 585 bytes |
xfs_inode.c | -rw-r--r-- | 96.8 KB |
xfs_inode.h | -rw-r--r-- | 17.0 KB |
xfs_inode_item.c | -rw-r--r-- | 27.8 KB |
xfs_inode_item.h | -rw-r--r-- | 1.8 KB |
xfs_inode_item_recover.c | -rw-r--r-- | 16.1 KB |
xfs_ioctl.c | -rw-r--r-- | 49.5 KB |
xfs_ioctl.h | -rw-r--r-- | 1.5 KB |
xfs_ioctl32.c | -rw-r--r-- | 14.3 KB |
xfs_ioctl32.h | -rw-r--r-- | 7.1 KB |
xfs_iomap.c | -rw-r--r-- | 37.1 KB |
xfs_iomap.h | -rw-r--r-- | 1.5 KB |
xfs_iops.c | -rw-r--r-- | 33.9 KB |
xfs_iops.h | -rw-r--r-- | 613 bytes |
xfs_itable.c | -rw-r--r-- | 12.2 KB |
xfs_itable.h | -rw-r--r-- | 2.1 KB |
xfs_iunlink_item.c | -rw-r--r-- | 4.6 KB |
xfs_iunlink_item.h | -rw-r--r-- | 611 bytes |
xfs_iwalk.c | -rw-r--r-- | 20.6 KB |
xfs_iwalk.h | -rw-r--r-- | 1.8 KB |
xfs_linux.h | -rw-r--r-- | 6.6 KB |
xfs_log.c | -rw-r--r-- | 110.4 KB |
xfs_log.h | -rw-r--r-- | 4.8 KB |
xfs_log_cil.c | -rw-r--r-- | 58.5 KB |
xfs_log_priv.h | -rw-r--r-- | 25.7 KB |
xfs_log_recover.c | -rw-r--r-- | 97.5 KB |
xfs_message.c | -rw-r--r-- | 2.3 KB |
xfs_message.h | -rw-r--r-- | 3.5 KB |
xfs_mount.c | -rw-r--r-- | 37.1 KB |
xfs_mount.h | -rw-r--r-- | 20.1 KB |
xfs_mru_cache.c | -rw-r--r-- | 17.2 KB |
xfs_mru_cache.h | -rw-r--r-- | 1.1 KB |
xfs_notify_failure.c | -rw-r--r-- | 5.7 KB |
xfs_ondisk.h | -rw-r--r-- | 8.7 KB |
xfs_pnfs.c | -rw-r--r-- | 8.5 KB |
xfs_pnfs.h | -rw-r--r-- | 692 bytes |
xfs_pwork.c | -rw-r--r-- | 3.2 KB |
xfs_pwork.h | -rw-r--r-- | 1.4 KB |
xfs_qm.c | -rw-r--r-- | 45.4 KB |
xfs_qm.h | -rw-r--r-- | 4.6 KB |
xfs_qm_bhv.c | -rw-r--r-- | 3.6 KB |
xfs_qm_syscalls.c | -rw-r--r-- | 12.6 KB |
xfs_quota.h | -rw-r--r-- | 6.1 KB |
xfs_quotaops.c | -rw-r--r-- | 6.2 KB |
xfs_refcount_item.c | -rw-r--r-- | 19.5 KB |
xfs_refcount_item.h | -rw-r--r-- | 2.2 KB |
xfs_reflink.c | -rw-r--r-- | 48.1 KB |
xfs_reflink.h | -rw-r--r-- | 2.2 KB |
xfs_rmap_item.c | -rw-r--r-- | 19.3 KB |
xfs_rmap_item.h | -rw-r--r-- | 2.4 KB |
xfs_rtalloc.c | -rw-r--r-- | 37.8 KB |
xfs_rtalloc.h | -rw-r--r-- | 5.6 KB |
xfs_stats.c | -rw-r--r-- | 4.4 KB |
xfs_stats.h | -rw-r--r-- | 5.7 KB |
xfs_super.c | -rw-r--r-- | 59.8 KB |
xfs_super.h | -rw-r--r-- | 2.3 KB |
xfs_symlink.c | -rw-r--r-- | 12.1 KB |
xfs_symlink.h | -rw-r--r-- | 554 bytes |
xfs_sysctl.c | -rw-r--r-- | 5.6 KB |
xfs_sysctl.h | -rw-r--r-- | 3.2 KB |
xfs_sysfs.c | -rw-r--r-- | 14.0 KB |
xfs_sysfs.h | -rw-r--r-- | 1.3 KB |
xfs_trace.c | -rw-r--r-- | 1014 bytes |
xfs_trace.h | -rw-r--r-- | 131.6 KB |
xfs_trans.c | -rw-r--r-- | 38.7 KB |
xfs_trans.h | -rw-r--r-- | 9.9 KB |
xfs_trans_ail.c | -rw-r--r-- | 24.5 KB |
xfs_trans_buf.c | -rw-r--r-- | 20.2 KB |
xfs_trans_dquot.c | -rw-r--r-- | 20.4 KB |
xfs_trans_priv.h | -rw-r--r-- | 4.6 KB |
xfs_xattr.c | -rw-r--r-- | 6.7 KB |
xfs_xattr.h | -rw-r--r-- | 301 bytes |
Computing file changes ...