Revision cdd97383e19d4afe29adc3376025a15ae3bab3a3 authored by Dan Carpenter on 07 December 2022, 07:06:31 UTC, committed by Jakub Kicinski on 08 December 2022, 17:09:36 UTC
In an earlier commit, I added a bounds check to prevent an out of bounds read and a WARN(). On further discussion and consideration that check was probably too aggressive. Instead of returning -EINVAL, a better fix would be to just prevent the out of bounds read but continue the process. Background: The value of "pp->rxq_def" is a number between 0-7 by default, or even higher depending on the value of "rxq_number", which is a module parameter. If the value is more than the number of available CPUs then it will trigger the WARN() in cpu_max_bits_warn(). Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()") Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed14e59
File | Mode | Size |
---|---|---|
.gitignore | -rw-r--r-- | 810 bytes |
Makefile | -rw-r--r-- | 15.8 KB |
Makefile.target | -rw-r--r-- | 2.5 KB |
README.rst | -rw-r--r-- | 3.4 KB |
asm_goto_workaround.h | -rw-r--r-- | 725 bytes |
bpf_insn.h | -rw-r--r-- | 6.3 KB |
cookie_uid_helper_example.c | -rw-r--r-- | 9.4 KB |
cpustat_kern.c | -rw-r--r-- | 7.0 KB |
cpustat_user.c | -rw-r--r-- | 5.7 KB |
do_hbm_test.sh | -rwxr-xr-x | 12.0 KB |
fds_example.c | -rw-r--r-- | 4.3 KB |
hash_func01.h | -rw-r--r-- | 1.3 KB |
hbm.c | -rw-r--r-- | 13.6 KB |
hbm.h | -rw-r--r-- | 1.2 KB |
hbm_edt_kern.c | -rw-r--r-- | 5.3 KB |
hbm_kern.h | -rw-r--r-- | 5.7 KB |
hbm_out_kern.c | -rw-r--r-- | 5.5 KB |
ibumad_kern.c | -rw-r--r-- | 2.9 KB |
ibumad_user.c | -rw-r--r-- | 3.4 KB |
lathist_kern.c | -rw-r--r-- | 2.1 KB |
lathist_user.c | -rw-r--r-- | 2.6 KB |
lwt_len_hist.sh | -rwxr-xr-x | 1.0 KB |
lwt_len_hist_kern.c | -rw-r--r-- | 1.7 KB |
lwt_len_hist_user.c | -rw-r--r-- | 1.6 KB |
map_perf_test_kern.c | -rw-r--r-- | 6.7 KB |
map_perf_test_user.c | -rw-r--r-- | 11.5 KB |
offwaketime_kern.c | -rw-r--r-- | 3.8 KB |
offwaketime_user.c | -rw-r--r-- | 3.2 KB |
parse_ldabs.c | -rw-r--r-- | 1.2 KB |
parse_simple.c | -rw-r--r-- | 1.3 KB |
parse_varlen.c | -rw-r--r-- | 3.4 KB |
run_cookie_uid_helper_example.sh | -rwxr-xr-x | 341 bytes |
sampleip_kern.c | -rw-r--r-- | 915 bytes |
sampleip_user.c | -rw-r--r-- | 4.8 KB |
sock_example.c | -rw-r--r-- | 2.9 KB |
sock_example.h | -rw-r--r-- | 814 bytes |
sock_flags_kern.c | -rw-r--r-- | 1.2 KB |
sockex1_kern.c | -rw-r--r-- | 661 bytes |
sockex1_user.c | -rw-r--r-- | 1.4 KB |
sockex2_kern.c | -rw-r--r-- | 4.8 KB |
sockex2_user.c | -rw-r--r-- | 1.3 KB |
sockex3_kern.c | -rw-r--r-- | 6.2 KB |
sockex3_user.c | -rw-r--r-- | 2.4 KB |
spintest_kern.c | -rw-r--r-- | 2.1 KB |
spintest_user.c | -rw-r--r-- | 2.1 KB |
syscall_nrs.c | -rw-r--r-- | 337 bytes |
syscall_tp_kern.c | -rw-r--r-- | 1.4 KB |
syscall_tp_user.c | -rw-r--r-- | 3.2 KB |
task_fd_query_kern.c | -rw-r--r-- | 412 bytes |
task_fd_query_user.c | -rw-r--r-- | 11.3 KB |
tc_l2_redirect.sh | -rwxr-xr-x | 4.9 KB |
tc_l2_redirect_kern.c | -rw-r--r-- | 6.0 KB |
tc_l2_redirect_user.c | -rw-r--r-- | 1.3 KB |
tcbpf1_kern.c | -rw-r--r-- | 2.6 KB |
tcp_basertt_kern.c | -rw-r--r-- | 1.7 KB |
tcp_bpf.readme | -rw-r--r-- | 1.1 KB |
tcp_bufs_kern.c | -rw-r--r-- | 2.1 KB |
tcp_clamp_kern.c | -rw-r--r-- | 2.7 KB |
tcp_cong_kern.c | -rw-r--r-- | 1.9 KB |
tcp_dumpstats_kern.c | -rw-r--r-- | 1.3 KB |
tcp_iw_kern.c | -rw-r--r-- | 2.2 KB |
tcp_rwnd_kern.c | -rw-r--r-- | 1.7 KB |
tcp_synrto_kern.c | -rw-r--r-- | 1.7 KB |
tcp_tos_reflect_kern.c | -rw-r--r-- | 1.8 KB |
test_cgrp2_array_pin.c | -rw-r--r-- | 2.1 KB |
test_cgrp2_attach.c | -rw-r--r-- | 4.6 KB |
test_cgrp2_sock.c | -rw-r--r-- | 6.3 KB |
test_cgrp2_sock.sh | -rwxr-xr-x | 2.9 KB |
test_cgrp2_sock2.c | -rw-r--r-- | 2.0 KB |
test_cgrp2_sock2.sh | -rwxr-xr-x | 1.8 KB |
test_cgrp2_tc.sh | -rwxr-xr-x | 4.2 KB |
test_cgrp2_tc_kern.c | -rw-r--r-- | 1.8 KB |
test_cls_bpf.sh | -rwxr-xr-x | 915 bytes |
test_current_task_under_cgroup_kern.c | -rw-r--r-- | 1.1 KB |
test_current_task_under_cgroup_user.c | -rw-r--r-- | 2.4 KB |
test_lru_dist.c | -rw-r--r-- | 11.9 KB |
test_lwt_bpf.c | -rw-r--r-- | 6.0 KB |
test_lwt_bpf.sh | -rwxr-xr-x | 9.0 KB |
test_map_in_map_kern.c | -rw-r--r-- | 3.9 KB |
test_map_in_map_user.c | -rw-r--r-- | 4.3 KB |
test_overhead_kprobe_kern.c | -rw-r--r-- | 1.4 KB |
test_overhead_raw_tp_kern.c | -rw-r--r-- | 361 bytes |
test_overhead_tp_kern.c | -rw-r--r-- | 879 bytes |
test_overhead_user.c | -rw-r--r-- | 4.1 KB |
test_override_return.sh | -rwxr-xr-x | 276 bytes |
test_probe_write_user_kern.c | -rw-r--r-- | 1.8 KB |
test_probe_write_user_user.c | -rw-r--r-- | 3.3 KB |
trace_common.h | -rw-r--r-- | 286 bytes |
trace_event_kern.c | -rw-r--r-- | 2.3 KB |
trace_event_user.c | -rw-r--r-- | 7.8 KB |
trace_output_kern.c | -rw-r--r-- | 660 bytes |
trace_output_user.c | -rw-r--r-- | 2.2 KB |
tracex1_kern.c | -rw-r--r-- | 1.8 KB |
tracex1_user.c | -rw-r--r-- | 1.1 KB |
tracex2_kern.c | -rw-r--r-- | 2.3 KB |
tracex2_user.c | -rw-r--r-- | 4.0 KB |
tracex3_kern.c | -rw-r--r-- | 2.1 KB |
tracex3_user.c | -rw-r--r-- | 3.7 KB |
tracex4_kern.c | -rw-r--r-- | 1.2 KB |
tracex4_user.c | -rw-r--r-- | 2.0 KB |
tracex5_kern.c | -rw-r--r-- | 2.2 KB |
tracex5_user.c | -rw-r--r-- | 2.3 KB |
tracex6_kern.c | -rw-r--r-- | 1.4 KB |
tracex6_user.c | -rw-r--r-- | 5.5 KB |
tracex7_kern.c | -rw-r--r-- | 339 bytes |
tracex7_user.c | -rw-r--r-- | 1.2 KB |
xdp1_kern.c | -rw-r--r-- | 2.2 KB |
xdp1_user.c | -rw-r--r-- | 3.3 KB |
xdp2_kern.c | -rw-r--r-- | 2.5 KB |
xdp2skb_meta.sh | -rwxr-xr-x | 4.5 KB |
xdp2skb_meta_kern.c | -rw-r--r-- | 3.0 KB |
xdp_adjust_tail_kern.c | -rw-r--r-- | 3.8 KB |
xdp_adjust_tail_user.c | -rw-r--r-- | 4.6 KB |
xdp_fwd_kern.c | -rw-r--r-- | 4.5 KB |
xdp_fwd_user.c | -rw-r--r-- | 5.2 KB |
xdp_monitor.bpf.c | -rw-r--r-- | 218 bytes |
xdp_monitor_user.c | -rw-r--r-- | 2.7 KB |
xdp_redirect.bpf.c | -rw-r--r-- | 1.3 KB |
xdp_redirect_cpu.bpf.c | -rw-r--r-- | 12.0 KB |
xdp_redirect_cpu_user.c | -rw-r--r-- | 14.9 KB |
xdp_redirect_map.bpf.c | -rw-r--r-- | 2.5 KB |
xdp_redirect_map_multi.bpf.c | -rw-r--r-- | 1.7 KB |
xdp_redirect_map_multi_user.c | -rw-r--r-- | 5.7 KB |
xdp_redirect_map_user.c | -rw-r--r-- | 6.1 KB |
xdp_redirect_user.c | -rw-r--r-- | 4.3 KB |
xdp_router_ipv4.bpf.c | -rw-r--r-- | 4.0 KB |
xdp_router_ipv4_user.c | -rw-r--r-- | 17.0 KB |
xdp_rxq_info_kern.c | -rw-r--r-- | 3.2 KB |
xdp_rxq_info_user.c | -rw-r--r-- | 14.1 KB |
xdp_sample.bpf.c | -rw-r--r-- | 7.1 KB |
xdp_sample.bpf.h | -rw-r--r-- | 3.9 KB |
xdp_sample_pkts_kern.c | -rw-r--r-- | 1.5 KB |
xdp_sample_pkts_user.c | -rw-r--r-- | 3.9 KB |
xdp_sample_shared.h | -rw-r--r-- | 295 bytes |
xdp_sample_user.c | -rw-r--r-- | 42.4 KB |
xdp_sample_user.h | -rw-r--r-- | 4.4 KB |
xdp_tx_iptunnel_common.h | -rw-r--r-- | 485 bytes |
xdp_tx_iptunnel_kern.c | -rw-r--r-- | 5.6 KB |
xdp_tx_iptunnel_user.c | -rw-r--r-- | 7.4 KB |
Computing file changes ...