Revision cdf5b3962f33d0a05af040097173d8cc827a7d73 authored by Trent Apted on 12 March 2018, 04:02:04 UTC, committed by Blink WPT Bot on 12 March 2018, 04:10:37 UTC
This reverts commit af1c15b16f99d290799c83d34c111bce52447026.
Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1)
Unexpected Failures:
* external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
* external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
* external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
* external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html
* external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html
since
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761
errors like
15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines):
15:59:42.311 5904 CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md
15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644])
Original change's description:
> bluetooth: Use DeviceUUID in FakeBluetooth
>
> This change refactors the Web Bluetooth test API to use the
> DeviceUUIDs helper class defined in BluetoothDevice. Additionally,
> this change finishes the implementation of SimulateGATTServicesChanged,
> and as a result, tests are updated to set the next discovery response
> before calling this interface.
>
> BUG=719826
>
> Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d
> Reviewed-on: https://chromium-review.googlesource.com/939984
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541577}
TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 719826
Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104
Reviewed-on: https://chromium-review.googlesource.com/958741
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542421}
1 parent 9c9d8f2
RTCConfiguration-iceCandidatePoolSize.html
<!doctype html>
<meta charset="utf-8">
<!--
4.2.1 RTCConfiguration Dictionary
The RTCConfiguration defines a set of parameters to configure how the peer to peer communication established via RTCPeerConnection is established or re-established.
...
iceCandidatePoolSize of type octet, defaulting to 0
Size of the prefetched ICE pool as defined in [JSEP] (section 3.5.4. and section 4.1.1.).
-->
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
/*
dictionary RTCConfiguration {
...
[EnforceRange]
octet iceCandidatePoolSize = 0;
};
... of type octet
*/
test(() => {
const pc = new RTCPeerConnection();
assert_idl_attribute(pc, "getConfiguration");
assert_equals(pc.getConfiguration().iceCandidatePoolSize, 0);
}, "Initialize a new RTCPeerConnection with no iceCandidatePoolSize");
test(() => {
const pc = new RTCPeerConnection({
iceCandidatePoolSize: 0
});
assert_idl_attribute(pc, "getConfiguration");
assert_equals(pc.getConfiguration().iceCandidatePoolSize, 0);
}, "Initialize a new RTCPeerConnection with iceCandidatePoolSize: 0");
test(() => {
const pc = new RTCPeerConnection({
iceCandidatePoolSize: 255
});
assert_idl_attribute(pc, "getConfiguration");
assert_equals(pc.getConfiguration().iceCandidatePoolSize, 255);
}, "Initialize a new RTCPeerConnection with iceCandidatePoolSize: 255");
test(() => {
assert_throws(new TypeError(), () => {
new RTCPeerConnection({
iceCandidatePoolSize: -1
});
});
}, "Initialize a new RTCPeerConnection with iceCandidatePoolSize: -1 (Out Of Range)");
test(() => {
assert_throws(new TypeError(), () => {
new RTCPeerConnection({
iceCandidatePoolSize: 256
});
});
}, "Initialize a new RTCPeerConnection with iceCandidatePoolSize: 256 (Out Of Range)");
/*
Reconfiguration
*/
test(() => {
const pc = new RTCPeerConnection();
assert_idl_attribute(pc, "getConfiguration");
assert_idl_attribute(pc, "setConfiguration");
pc.setConfiguration({
iceCandidatePoolSize: 0
});
assert_equals(pc.getConfiguration().iceCandidatePoolSize, 0);
}, "Reconfigure RTCPeerConnection instance iceCandidatePoolSize to 0");
test(() => {
const pc = new RTCPeerConnection();
assert_idl_attribute(pc, "getConfiguration");
assert_idl_attribute(pc, "setConfiguration");
pc.setConfiguration({
iceCandidatePoolSize: 255
});
assert_equals(pc.getConfiguration().iceCandidatePoolSize, 255);
}, "Reconfigure RTCPeerConnection instance iceCandidatePoolSize to 255");
/*
The following tests include an explicit assertion for the existence of a
setConfiguration function to prevent the assert_throws from catching the
TypeError object that will be thrown when attempting to call the
non-existent setConfiguration method (in cases where it has not yet
been implemented). Without this check, these tests will pass incorrectly.
*/
test(() => {
const pc = new RTCPeerConnection();
assert_equals(typeof pc.setConfiguration, "function", "RTCPeerConnection.prototype.setConfiguration is not implemented");
assert_throws(new TypeError(), () => {
pc.setConfiguration({
iceCandidatePoolSize: -1
});
});
}, "Reconfigure RTCPeerConnection instance iceCandidatePoolSize to -1 (Out Of Range)");
test(() => {
const pc = new RTCPeerConnection();
assert_equals(typeof pc.setConfiguration, "function", "RTCPeerConnection.prototype.setConfiguration is not implemented");
assert_throws(new TypeError(), () => {
pc.setConfiguration({
iceCandidatePoolSize: 256
});
});
}, "Reconfigure RTCPeerConnection instance iceCandidatePoolSize to 256 (Out Of Range)");
</script>
Computing file changes ...
