Revision cdf5b3962f33d0a05af040097173d8cc827a7d73 authored by Trent Apted on 12 March 2018, 04:02:04 UTC, committed by Blink WPT Bot on 12 March 2018, 04:10:37 UTC
This reverts commit af1c15b16f99d290799c83d34c111bce52447026.
Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1)
Unexpected Failures:
* external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
* external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
* external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
* external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html
* external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html
since
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761
errors like
15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines):
15:59:42.311 5904 CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md
15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644])
Original change's description:
> bluetooth: Use DeviceUUID in FakeBluetooth
>
> This change refactors the Web Bluetooth test API to use the
> DeviceUUIDs helper class defined in BluetoothDevice. Additionally,
> this change finishes the implementation of SimulateGATTServicesChanged,
> and as a result, tests are updated to set the next discovery response
> before calling this interface.
>
> BUG=719826
>
> Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d
> Reviewed-on: https://chromium-review.googlesource.com/939984
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541577}
TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 719826
Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104
Reviewed-on: https://chromium-review.googlesource.com/958741
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542421}
1 parent 9c9d8f2
RTCPeerConnectionIceEvent-constructor.html
<!doctype html>
<meta charset="utf-8">
<!--
4.8.2 RTCPeerConnectionIceEvent
The icecandidate event of the RTCPeerConnection uses the RTCPeerConnectionIceEvent interface.
-->
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
/*
RTCPeerConnectionIceEvent
[Constructor(DOMString type, optional RTCPeerConnectionIceEventInit eventInitDict)]
interface RTCPeerConnectionIceEvent : Event {
readonly attribute RTCIceCandidate? candidate;
readonly attribute DOMString? url;
};
*/
test(() => {
assert_throws(new TypeError(), () => {
new RTCPeerConnectionIceEvent();
});
}, "RTCPeerConnectionIceEvent with no arguments throws TypeError");
test(() => {
const event = new RTCPeerConnectionIceEvent("type");
/*
candidate of type RTCIceCandidate, readonly, nullable
url of type DOMString, readonly, nullable
*/
assert_equals(event.candidate, null);
assert_equals(event.url, null);
/*
Firing an RTCPeerConnectionIceEvent event named e with an RTCIceCandidate
candidate means that an event with the name e, which does not bubble
(except where otherwise stated) and is not cancelable
(except where otherwise stated),
*/
assert_false(event.bubbles);
assert_false(event.cancelable);
}, "RTCPeerConnectionIceEvent with no eventInitDict (default)");
test(() => {
const event = new RTCPeerConnectionIceEvent("type", {});
/*
candidate of type RTCIceCandidate, readonly, nullable
url of type DOMString, readonly, nullable
*/
assert_equals(event.candidate, null);
assert_equals(event.url, null);
/*
Firing an RTCPeerConnectionIceEvent event named e with an RTCIceCandidate
candidate means that an event with the name e, which does not bubble
(except where otherwise stated) and is not cancelable
(except where otherwise stated),
*/
assert_false(event.bubbles);
assert_false(event.cancelable);
}, "RTCPeerConnectionIceEvent with empty object as eventInitDict (default)");
test(() => {
const event = new RTCPeerConnectionIceEvent("type", {
candidate: null
});
assert_equals(event.candidate, null);
}, "RTCPeerConnectionIceEvent.candidate is null when constructed with { candidate: null }");
test(() => {
const event = new RTCPeerConnectionIceEvent("type", {
candidate: undefined
});
assert_equals(event.candidate, null);
}, "RTCPeerConnectionIceEvent.candidate is null when constructed with { candidate: undefined }");
/*
4.8.1 RTCIceCandidate Interface
The RTCIceCandidate() constructor takes a dictionary argument, candidateInitDict,
whose content is used to initialize the new RTCIceCandidate object. When run, if
both the sdpMid and sdpMLineIndex dictionary members are null, throw a TypeError.
*/
const candidate = "";
const sdpMid = "sdpMid";
const sdpMLineIndex = 1;
const ufrag = "";
const url = "foo.bar";
test(() => {
const iceCandidate = new RTCIceCandidate({ candidate, sdpMid, sdpMLineIndex, ufrag });
const event = new RTCPeerConnectionIceEvent("type", {
candidate: iceCandidate,
url,
});
assert_equals(event.candidate, iceCandidate);
assert_false(event.bubbles);
assert_false(event.cancelable);
}, "RTCPeerConnectionIceEvent with RTCIceCandidate");
test(() => {
const plain = { candidate, sdpMid, sdpMLineIndex, ufrag };
assert_throws(new TypeError(), () => new RTCPeerConnectionIceEvent("type", { candidate: plain }));
}, "RTCPeerConnectionIceEvent with non RTCIceCandidate object throws");
/*
This will remain commented out until https://github.com/w3c/webrtc-pc/issues/1232
is resolved.
test(() => {
// When firing an RTCPeerConnectionIceEvent event that contains a RTCIceCandidate
// object, it must include values for both sdpMid and sdpMLineIndex.
assert_throws(new TypeError(), () => {
new RTCPeerConnectionIceEvent("type", {
candidate: new RTCIceCandidate({ candidate, sdpMid, ufrag })
});
});
assert_throws(new TypeError(), () => {
new RTCPeerConnectionIceEvent("type", {
candidate: new RTCIceCandidate({ candidate, sdpMLineIndex, ufrag })
});
});
}, "RTCIceCandidate must include values for both sdpMid and sdpMLineIndex");
*/
test(() => {
const event = new RTCPeerConnectionIceEvent("type", {
candidate: null,
bubbles: true,
cancelable: true,
});
assert_true(event.bubbles);
assert_true(event.cancelable);
}, "RTCPeerConnectionIceEvent bubbles and cancelable");
</script>
Computing file changes ...
