Revision ce48225fe3b1b0d1fc9fceb96ac3d8a879e45114 authored by Hugh Dickins on 03 March 2014, 23:38:24 UTC, committed by Linus Torvalds on 04 March 2014, 15:55:47 UTC
Commit 0eef615665ed ("memcg: fix css reference leak and endless loop in mem_cgroup_iter") got the interaction with the commit a few before it d8ad30559715 ("mm/memcg: iteration skip memcgs not yet fully initialized") slightly wrong, and we didn't notice at the time. It's elusive, and harder to get than the original, but for a couple of days before rc1, I several times saw a endless loop similar to that supposedly being fixed. This time it was a tighter loop in __mem_cgroup_iter_next(): because we can get here when our root has already been offlined, and the ordering of conditions was such that we then just cycled around forever. Fixes: 0eef615665ed ("memcg: fix css reference leak and endless loop in mem_cgroup_iter"). Signed-off-by: Hugh Dickins <hughd@google.com> Acked-by: Michal Hocko <mhocko@suse.cz> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Greg Thelen <gthelen@google.com> Cc: <stable@vger.kernel.org> [3.12+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5f30fc9
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 254 bytes |
af_rose.c | -rw-r--r-- | 37.5 KB |
rose_dev.c | -rw-r--r-- | 3.6 KB |
rose_in.c | -rw-r--r-- | 7.5 KB |
rose_link.c | -rw-r--r-- | 6.8 KB |
rose_loopback.c | -rw-r--r-- | 2.7 KB |
rose_out.c | -rw-r--r-- | 2.8 KB |
rose_route.c | -rw-r--r-- | 31.3 KB |
rose_subr.c | -rw-r--r-- | 12.3 KB |
rose_timer.c | -rw-r--r-- | 4.9 KB |
sysctl_net_rose.c | -rw-r--r-- | 3.3 KB |
Computing file changes ...