Skip to main content

Browse the archive

Revision cf5f3898987ec02aa02c02cb945c2abcc5307737 authored by Avi Drissman on 13 April 2018, 19:50:51 UTC, committed by Chromium WPT Sync on 13 April 2018, 19:50:51 UTC 
Revert "Web Animations: Fix bugs in procedure to process a keyframes argument"
 
This reverts commit 0ade0386aa4168b48234bc7f33d30a62140b95ea.

Reason for revert:
Unexpected Failures:
* bindings/sequence-type.html
* custom-elements/spec/define-element.html
* external/wpt/custom-elements/CustomElementRegistry.html

on
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/

Speculatively reverting this to see if it's the cause.

Original change's description:
> Web Animations: Fix bugs in procedure to process a keyframes argument
>
> There were three minor bugs left in the implementation:
>
>   - We threw on lists-in-custom-iterators instead of just ignoring them.
>   - We returned all properties on the keyframe rather than just those
>     defined on the keyframe itself (e.g. we would include prototype
>     properties, against spec).
>   - We didn't access the properties in ascending unicode order.
>
> Bug: 827573
> Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
> Reviewed-on: https://chromium-review.googlesource.com/989261
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550641}

TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org

Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827573
Reviewed-on: https://chromium-review.googlesource.com/1012857
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550721}
1 parent e6cffaa
Raw File
webkit-text-fill-color-property-004.html 
<!DOCTYPE html>
<meta charset="utf-8">
<title>webkit-text-fill-color should take effect while rendering MathML</title>
<link rel="author" title="Jeremy Chen" href="jeremychen@mozilla.com">
<link rel="author" title="Mozilla" href="https://www.mozilla.org">
<link rel="help" href="https://compat.spec.whatwg.org/#the-webkit-text-fill-color">
<meta name="assert" content="The color of MathML should be green">
<link rel="match" href="webkit-text-fill-color-property-004-ref.html">
<style>
math {
  font-size: 50px;
  color: red;
  -webkit-text-fill-color: green;
}
</style>
<body>
<p>Pass if color of operators and operands are all green!!!</p>
  <math>
    <mrow>
      <mrow>
        <msup>
          <mi>a</mi>
          <mn>2</mn>
        </msup>
        <mo>+</mo>
        <msup>
          <mi>b</mi>
          <mn>2</mn>
        </msup>
      </mrow>
      <mo>=</mo>
      <msup>
        <mi>c</mi>
        <mn>2</mn>
      </msup>
    </mrow>
  </math>
</body>
back to top