Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
Revision cf65ee17ac7d3d407674ac48733fbce50f25d087 authored by Matt Bauman on 16 March 2018, 20:45:04 UTC, committed by GitHub on 16 March 2018, 20:45:04 UTC 
Fix SparseVector broadcasting oddities (#26474)
 
* Fix SparseVector broadcasting oddities

Lots of SparseVector oddities fixed here, all by deleting code.  Previous behaviors that are now fixed include:

```julia
julia> spzeros(5) .* [1]
ERROR: DimensionMismatch("")
Stacktrace:
 [1] _binarymap(::typeof(*), ::SparseVector{Float64,Int64}, ::Array{Int64,1}, ::Int64) at /home/mbauman/julia-wip3/usr/share/julia/site/v0.7/SparseArrays/src/sparsevector.jl:1325
 [2] _vmul at /home/mbauman/julia-wip3/usr/share/julia/site/v0.7/SparseArrays/src/sparsevector.jl:1369 [inlined]
 [3] broadcast(::typeof(*), ::SparseVector{Float64,Int64}, ::Array{Int64,1}) at /home/mbauman/julia-wip3/usr/share/julia/site/v0.7/SparseArrays/src/sparsevector.jl:1388
 [4] top-level scope

julia> spzeros(5) .* ones(5)
5-element Array{Float64,1}:
 0.0
 0.0
 0.0
 0.0
 0.0

julia> spzeros(5) .* ones(5) .* 1 # this is as expected
5-element SparseVector{Float64,Int64} with 0 stored entries
```

Those all now behave as you'd expect, returning a SparseVector in all cases.

* Remove debugging code

[ci skip]
1 parent 83b0231
History
Tip revision: cf65ee17ac7d3d407674ac48733fbce50f25d087 authored by Matt Bauman on 16 March 2018, 20:45:04 UTC
Fix SparseVector broadcasting oddities (#26474)
Tip revision: cf65ee1
File Mode Size
.circleci
.github
base
contrib
deps
doc
etc
src
stdlib
test
ui
.freebsdci.sh -rwxr-xr-x 1.0 KB
.gitattributes -rw-r--r-- 67 bytes
.gitignore -rw-r--r-- 213 bytes
.mailmap -rw-r--r-- 9.5 KB
.travis.yml -rw-r--r-- 6.5 KB
CONTRIBUTING.md -rw-r--r-- 20.4 KB
DISTRIBUTING.md -rw-r--r-- 23.6 KB
HISTORY.md -rw-r--r-- 144.9 KB
LICENSE.md -rw-r--r-- 5.4 KB
Make.inc -rw-r--r-- 35.3 KB
Makefile -rw-r--r-- 25.5 KB
NEWS.md -rw-r--r-- 74.4 KB
README.arm.md -rw-r--r-- 5.7 KB
README.md -rw-r--r-- 29.5 KB
README.windows.md -rw-r--r-- 13.0 KB
VERSION -rw-r--r-- 10 bytes
Windows.inc -rw-r--r-- 1.5 KB
appveyor.yml -rw-r--r-- 2.2 KB

README.md

back to top