Revision cfb2417fecfff890ec19fb60405df0c709b89fa6 authored by Valentin Lorentz on 26 March 2021, 15:03:27 UTC, committed by Valentin Lorentz on 26 March 2021, 15:08:13 UTC
It did not make sense for multiple reasons:

1. two extids can point to the same target (eg. extids with type git and git-sha256;
   or two package managers with different checksums)
2. inserting two objects with the same target or extid in a single call actually
   wrote both, but would crash when reading
3. inserting extid1 then extid2 would write both to Kafka, but only extid1
   would be inserted. When replaying on a new DB, extid2 may be inserted
   and extid1 ignored

Points 2 and 3 are simply fixable bugs, but 1 is an issue by design,
and this commit fixes all of them at once.
1 parent ac6f642
History
File Mode Size
bin
docs
sql
swh
.gitignore -rw-r--r-- 136 bytes
.pre-commit-config.yaml -rw-r--r-- 1.2 KB
AUTHORS -rw-r--r-- 112 bytes
CODE_OF_CONDUCT.md -rw-r--r-- 3.3 KB
CONTRIBUTORS -rw-r--r-- 46 bytes
LICENSE -rw-r--r-- 34.3 KB
MANIFEST.in -rw-r--r-- 242 bytes
Makefile -rw-r--r-- 163 bytes
Makefile.local -rw-r--r-- 69 bytes
README.md -rw-r--r-- 4.9 KB
conftest.py -rw-r--r-- 323 bytes
mypy.ini -rw-r--r-- 1.3 KB
pyproject.toml -rw-r--r-- 237 bytes
pytest.ini -rw-r--r-- 395 bytes
requirements-swh-journal.txt -rw-r--r-- 21 bytes
requirements-swh.txt -rw-r--r-- 68 bytes
requirements-test.txt -rw-r--r-- 291 bytes
requirements.txt -rw-r--r-- 129 bytes
setup.cfg -rw-r--r-- 247 bytes
setup.py -rwxr-xr-x 2.4 KB
tox.ini -rw-r--r-- 682 bytes

README.md

back to top