https://github.com/torvalds/linux
Revision d096ad0f79a782935d2e06ae8fb235e8c5397775 authored by Michael Tokarev on 25 December 2012, 19:08:16 UTC, committed by Theodore Ts'o on 25 December 2012, 19:08:16 UTC
When a journal-less ext4 filesystem is mounted on a read-only block
device (blockdev --setro will do), each remount (for other, unrelated,
flags, like suid=>nosuid etc) results in a series of scary messages
from kernel telling about I/O errors on the device.
This is becauese of the following code ext4_remount():
if (sbi->s_journal == NULL)
ext4_commit_super(sb, 1);
at the end of remount procedure, which forces writing (flushing) of
a superblock regardless whenever it is dirty or not, if the filesystem
is readonly or not, and whenever the device itself is readonly or not.
We only need call ext4_commit_super when the file system had been
previously mounted read/write.
Thanks to Eric Sandeen for help in diagnosing this issue.
Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
1 parent 0875a2b
Tip revision: d096ad0f79a782935d2e06ae8fb235e8c5397775 authored by Michael Tokarev on 25 December 2012, 19:08:16 UTC
ext4: do not try to write superblock on ro remount w/o journal
ext4: do not try to write superblock on ro remount w/o journal
Tip revision: d096ad0
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| logfs | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 6.2 KB |
| Kconfig.binfmt | -rw-r--r-- | 6.7 KB |
| Makefile | -rw-r--r-- | 4.1 KB |
| aio.c | -rw-r--r-- | 45.7 KB |
| anon_inodes.c | -rw-r--r-- | 6.4 KB |
| attr.c | -rw-r--r-- | 7.0 KB |
| bad_inode.c | -rw-r--r-- | 7.7 KB |
| binfmt_aout.c | -rw-r--r-- | 11.8 KB |
| binfmt_elf.c | -rw-r--r-- | 57.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 48.5 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.7 KB |
| binfmt_misc.c | -rw-r--r-- | 15.1 KB |
| binfmt_script.c | -rw-r--r-- | 2.8 KB |
| binfmt_som.c | -rw-r--r-- | 7.1 KB |
| bio-integrity.c | -rw-r--r-- | 20.5 KB |
| bio.c | -rw-r--r-- | 40.2 KB |
| block_dev.c | -rw-r--r-- | 45.0 KB |
| buffer.c | -rw-r--r-- | 85.1 KB |
| char_dev.c | -rw-r--r-- | 14.0 KB |
| compat.c | -rw-r--r-- | 44.7 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.6 KB |
| compat_ioctl.c | -rw-r--r-- | 45.4 KB |
| coredump.c | -rw-r--r-- | 16.5 KB |
| coredump.h | -rw-r--r-- | 106 bytes |
| dcache.c | -rw-r--r-- | 80.5 KB |
| dcookies.c | -rw-r--r-- | 6.8 KB |
| direct-io.c | -rw-r--r-- | 37.3 KB |
| drop_caches.c | -rw-r--r-- | 1.5 KB |
| eventfd.c | -rw-r--r-- | 10.9 KB |
| eventpoll.c | -rw-r--r-- | 54.3 KB |
| exec.c | -rw-r--r-- | 39.4 KB |
| fcntl.c | -rw-r--r-- | 16.3 KB |
| fhandle.c | -rw-r--r-- | 6.4 KB |
| fifo.c | -rw-r--r-- | 3.2 KB |
| file.c | -rw-r--r-- | 23.6 KB |
| file_table.c | -rw-r--r-- | 12.2 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 39.3 KB |
| fs_struct.c | -rw-r--r-- | 3.6 KB |
| generic_acl.c | -rw-r--r-- | 3.9 KB |
| inode.c | -rw-r--r-- | 48.4 KB |
| internal.h | -rw-r--r-- | 2.9 KB |
| ioctl.c | -rw-r--r-- | 15.6 KB |
| ioprio.c | -rw-r--r-- | 5.0 KB |
| libfs.c | -rw-r--r-- | 25.8 KB |
| locks.c | -rw-r--r-- | 58.7 KB |
| mbcache.c | -rw-r--r-- | 16.4 KB |
| mount.h | -rw-r--r-- | 2.2 KB |
| mpage.c | -rw-r--r-- | 20.0 KB |
| namei.c | -rw-r--r-- | 98.8 KB |
| namespace.c | -rw-r--r-- | 64.8 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| open.c | -rw-r--r-- | 24.3 KB |
| pipe.c | -rw-r--r-- | 28.9 KB |
| pnode.c | -rw-r--r-- | 8.8 KB |
| pnode.h | -rw-r--r-- | 1.4 KB |
| posix_acl.c | -rw-r--r-- | 9.2 KB |
| proc_namespace.c | -rw-r--r-- | 7.5 KB |
| read_write.c | -rw-r--r-- | 21.6 KB |
| read_write.h | -rw-r--r-- | 632 bytes |
| readdir.c | -rw-r--r-- | 6.8 KB |
| select.c | -rw-r--r-- | 24.0 KB |
| seq_file.c | -rw-r--r-- | 19.6 KB |
| signalfd.c | -rw-r--r-- | 8.0 KB |
| splice.c | -rw-r--r-- | 46.4 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 11.1 KB |
| statfs.c | -rw-r--r-- | 5.2 KB |
| super.c | -rw-r--r-- | 34.6 KB |
| sync.c | -rw-r--r-- | 10.6 KB |
| timerfd.c | -rw-r--r-- | 8.5 KB |
| utimes.c | -rw-r--r-- | 5.6 KB |
| xattr.c | -rw-r--r-- | 22.3 KB |
| xattr_acl.c | -rw-r--r-- | 4.3 KB |
Computing file changes ...
