Revision d1908362ae0b97374eb8328fbb471576332f9fb1 authored by Minchan Kim on 22 September 2010, 20:05:01 UTC, committed by Linus Torvalds on 23 September 2010, 00:22:39 UTC
M.  Vefa Bicakci reported 2.6.35 kernel hang up when hibernation on his
32bit 3GB mem machine.
(https://bugzilla.kernel.org/show_bug.cgi?id=16771). Also he bisected
the regression to

  commit bb21c7ce18eff8e6e7877ca1d06c6db719376e3c
  Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
  Date:   Fri Jun 4 14:15:05 2010 -0700

     vmscan: fix do_try_to_free_pages() return value when priority==0 reclaim failure

At first impression, this seemed very strange because the above commit
only chenged function return value and hibernate_preallocate_memory()
ignore return value of shrink_all_memory().  But it's related.

Now, page allocation from hibernation code may enter infinite loop if the
system has highmem.  The reasons are that vmscan don't care enough OOM
case when oom_killer_disabled.

The problem sequence is following as.

1. hibernation
2. oom_disable
3. alloc_pages
4. do_try_to_free_pages
       if (scanning_global_lru(sc) && !all_unreclaimable)
               return 1;

If kswapd is not freozen, it would set zone->all_unreclaimable to 1 and
then shrink_zones maybe return true(ie, all_unreclaimable is true).  So at
last, alloc_pages could go to _nopage_.  If it is, it should have no
problem.

This patch adds all_unreclaimable check to protect in direct reclaim path,
too.  It can care of hibernation OOM case and help bailout
all_unreclaimable case slightly.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Reported-by: M. Vefa Bicakci <bicave@superonline.com>
Reported-by: <caiqian@redhat.com>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
Tested-by: <caiqian@redhat.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent eba93fc
History
File Mode Size
Kconfig -rw-r--r-- 2.7 KB
Makefile -rw-r--r-- 422 bytes
addr.c -rw-r--r-- 3.8 KB
addr.h -rw-r--r-- 615 bytes
atm_misc.c -rw-r--r-- 2.6 KB
atm_sysfs.c -rw-r--r-- 3.9 KB
br2684.c -rw-r--r-- 22.0 KB
clip.c -rw-r--r-- 24.2 KB
common.c -rw-r--r-- 20.9 KB
common.h -rw-r--r-- 1.6 KB
ioctl.c -rw-r--r-- 9.3 KB
lec.c -rw-r--r-- 63.6 KB
lec.h -rw-r--r-- 5.1 KB
lec_arpc.h -rw-r--r-- 2.9 KB
mpc.c -rw-r--r-- 38.3 KB
mpc.h -rw-r--r-- 1.9 KB
mpoa_caches.c -rw-r--r-- 14.7 KB
mpoa_caches.h -rw-r--r-- 3.0 KB
mpoa_proc.c -rw-r--r-- 7.2 KB
pppoatm.c -rw-r--r-- 10.7 KB
proc.c -rw-r--r-- 11.4 KB
protocols.h -rw-r--r-- 379 bytes
pvc.c -rw-r--r-- 3.7 KB
raw.c -rw-r--r-- 1.8 KB
resources.c -rw-r--r-- 9.8 KB
resources.h -rw-r--r-- 996 bytes
signaling.c -rw-r--r-- 6.9 KB
signaling.h -rw-r--r-- 838 bytes
svc.c -rw-r--r-- 16.4 KB

back to top