https://github.com/torvalds/linux
Revision d26f60703606ab425eee9882b32a1781a8bed74d authored by Badari Pulavarty on 21 August 2022, 18:08:53 UTC, committed by Andrew Morton on 28 August 2022, 21:02:45 UTC
When user tries to create a DAMON context via the DAMON debugfs interface
with a name of an already existing context, the context directory creation
fails but a new context is created and added in the internal data
structure, due to absence of the directory creation success check.  As a
result, memory could leak and DAMON cannot be turned on.  An example test
case is as below:

    # cd /sys/kernel/debug/damon/
    # echo "off" >  monitor_on
    # echo paddr > target_ids
    # echo "abc" > mk_context
    # echo "abc" > mk_context
    # echo $$ > abc/target_ids
    # echo "on" > monitor_on  <<< fails

Return value of 'debugfs_create_dir()' is expected to be ignored in
general, but this is an exceptional case as DAMON feature is depending
on the debugfs functionality and it has the potential duplicate name
issue.  This commit therefore fixes the issue by checking the directory
creation failure and immediately return the error in the case.

Link: https://lkml.kernel.org/r/20220821180853.2400-1-sj@kernel.org
Fixes: 75c1c2b53c78 ("mm/damon/dbgfs: support multiple contexts")
Signed-off-by: Badari Pulavarty <badari.pulavarty@intel.com>
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>	[ 5.15.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent ac733f6
History
Tip revision: d26f60703606ab425eee9882b32a1781a8bed74d authored by Badari Pulavarty on 21 August 2022, 18:08:53 UTC
mm/damon/dbgfs: avoid duplicate context directory creation
Tip revision: d26f607
File Mode Size
Kconfig -rw-r--r-- 62.3 KB
Makefile -rw-r--r-- 1.2 KB
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 15.5 KB
do_mounts.h -rw-r--r-- 908 bytes
do_mounts_initrd.c -rw-r--r-- 3.9 KB
do_mounts_rd.c -rw-r--r-- 7.7 KB
init_task.c -rw-r--r-- 6.1 KB
initramfs.c -rw-r--r-- 17.2 KB
main.c -rw-r--r-- 39.6 KB
noinitramfs.c -rw-r--r-- 862 bytes
version.c -rw-r--r-- 1.6 KB

back to top