Revision d344873c4cbde249b7152d36a273bcc45864001e authored by Richard Fitzgerald on 08 May 2024, 10:08:11 UTC, committed by Takashi Iwai on 08 May 2024, 16:18:29 UTC
The cs_dsp instance is initialized in the driver probe() so it
should be freed in the driver remove(). Also fix a missing call
to cs_dsp_remove() in the error path of cs35l56_hda_common_probe().
The call to cs_dsp_remove() was being done in the component unbind
callback cs35l56_hda_unbind(). This meant that if the driver was
unbound and then re-bound it would be using an uninitialized cs_dsp
instance.
It is best to initialize the cs_dsp instance in probe() so that it
can return an error if it fails. The component binding API doesn't
have any error handling so there's no way to handle a failure if
cs_dsp was initialized in the bind.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Link: https://lore.kernel.org/r/20240508100811.49514-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent ec6f32b
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| LICENSES | ||
| arch | ||
| block | ||
| certs | ||
| crypto | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| io_uring | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| rust | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .clang-format | -rw-r--r-- | 21.7 KB |
| .cocciconfig | -rw-r--r-- | 59 bytes |
| .editorconfig | -rw-r--r-- | 672 bytes |
| .get_maintainer.ignore | -rw-r--r-- | 194 bytes |
| .gitattributes | -rw-r--r-- | 105 bytes |
| .gitignore | -rw-r--r-- | 2.0 KB |
| .mailmap | -rw-r--r-- | 38.3 KB |
| .rustfmt.toml | -rw-r--r-- | 369 bytes |
| COPYING | -rw-r--r-- | 496 bytes |
| CREDITS | -rw-r--r-- | 101.8 KB |
| Kbuild | -rw-r--r-- | 2.5 KB |
| Kconfig | -rw-r--r-- | 555 bytes |
| MAINTAINERS | -rw-r--r-- | 730.4 KB |
| Makefile | -rw-r--r-- | 66.2 KB |
| README | -rw-r--r-- | 726 bytes |
Computing file changes ...
