https://github.com/torvalds/linux
Revision d5421ea43d30701e03cadc56a38854c36a8b4433 authored by Thomas Gleixner on 26 January 2018, 13:54:32 UTC, committed by Thomas Gleixner on 27 January 2018, 14:12:22 UTC
The hrtimer interrupt code contains a hang detection and mitigation
mechanism, which prevents that a long delayed hrtimer interrupt causes a
continous retriggering of interrupts which prevent the system from making
progress. If a hang is detected then the timer hardware is programmed with
a certain delay into the future and a flag is set in the hrtimer cpu base
which prevents newly enqueued timers from reprogramming the timer hardware
prior to the chosen delay. The subsequent hrtimer interrupt after the delay
clears the flag and resumes normal operation.

If such a hang happens in the last hrtimer interrupt before a CPU is
unplugged then the hang_detected flag is set and stays that way when the
CPU is plugged in again. At that point the timer hardware is not armed and
it cannot be armed because the hang_detected flag is still active, so
nothing clears that flag. As a consequence the CPU does not receive hrtimer
interrupts and no timers expire on that CPU which results in RCU stalls and
other malfunctions.

Clear the flag along with some other less critical members of the hrtimer
cpu base to ensure starting from a clean state when a CPU is plugged in.

Thanks to Paul, Sebastian and Anna-Maria for their help to get down to the
root cause of that hard to reproduce heisenbug. Once understood it's
trivial and certainly justifies a brown paperbag.

Fixes: 41d2e4949377 ("hrtimer: Tune hrtimer_interrupt hang logic")
Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Sewior <bigeasy@linutronix.de>
Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.20.1801261447590.2067@nanos

1 parent 993ca20
History
Tip revision: d5421ea43d30701e03cadc56a38854c36a8b4433 authored by Thomas Gleixner on 26 January 2018, 13:54:32 UTC
hrtimer: Reset hrtimer cpu base proper on CPU hotplug
Tip revision: d5421ea
File Mode Size
9p
adfs
affs
afs
autofs4
befs
bfs
btrfs
cachefiles
ceph
cifs
coda
configfs
cramfs
crypto
debugfs
devpts
dlm
ecryptfs
efivarfs
efs
exofs
exportfs
ext2
ext4
f2fs
fat
freevxfs
fscache
fuse
gfs2
hfs
hfsplus
hostfs
hpfs
hugetlbfs
isofs
jbd2
jffs2
jfs
kernfs
lockd
minix
ncpfs
nfs
nfs_common
nfsd
nilfs2
nls
notify
ntfs
ocfs2
omfs
openpromfs
orangefs
overlayfs
proc
pstore
qnx4
qnx6
quota
ramfs
reiserfs
romfs
squashfs
sysfs
sysv
tracefs
ubifs
udf
ufs
xfs
Kconfig -rw-r--r-- 7.1 KB
Kconfig.binfmt -rw-r--r-- 7.2 KB
Makefile -rw-r--r-- 4.3 KB
aio.c -rw-r--r-- 46.5 KB
anon_inodes.c -rw-r--r-- 4.9 KB
attr.c -rw-r--r-- 9.2 KB
bad_inode.c -rw-r--r-- 5.3 KB
binfmt_aout.c -rw-r--r-- 10.8 KB
binfmt_elf.c -rw-r--r-- 63.1 KB
binfmt_elf_fdpic.c -rw-r--r-- 47.3 KB
binfmt_em86.c -rw-r--r-- 2.8 KB
binfmt_flat.c -rw-r--r-- 27.7 KB
binfmt_misc.c -rw-r--r-- 18.2 KB
binfmt_script.c -rw-r--r-- 3.0 KB
block_dev.c -rw-r--r-- 53.1 KB
buffer.c -rw-r--r-- 93.1 KB
char_dev.c -rw-r--r-- 16.7 KB
compat.c -rw-r--r-- 5.1 KB
compat_binfmt_elf.c -rw-r--r-- 3.4 KB
compat_ioctl.c -rw-r--r-- 42.7 KB
coredump.c -rw-r--r-- 21.2 KB
dax.c -rw-r--r-- 43.9 KB
dcache.c -rw-r--r-- 94.5 KB
dcookies.c -rw-r--r-- 6.9 KB
direct-io.c -rw-r--r-- 40.4 KB
drop_caches.c -rw-r--r-- 1.6 KB
eventfd.c -rw-r--r-- 12.9 KB
eventpoll.c -rw-r--r-- 62.9 KB
exec.c -rw-r--r-- 45.9 KB
fcntl.c -rw-r--r-- 23.0 KB
fhandle.c -rw-r--r-- 6.8 KB
file.c -rw-r--r-- 23.3 KB
file_table.c -rw-r--r-- 8.6 KB
filesystems.c -rw-r--r-- 6.5 KB
fs-writeback.c -rw-r--r-- 70.8 KB
fs_pin.c -rw-r--r-- 2.0 KB
fs_struct.c -rw-r--r-- 3.3 KB
inode.c -rw-r--r-- 55.1 KB
internal.h -rw-r--r-- 4.7 KB
ioctl.c -rw-r--r-- 17.3 KB
iomap.c -rw-r--r-- 25.4 KB
libfs.c -rw-r--r-- 30.6 KB
locks.c -rw-r--r-- 73.7 KB
mbcache.c -rw-r--r-- 11.9 KB
mount.h -rw-r--r-- 3.9 KB
mpage.c -rw-r--r-- 20.9 KB
namei.c -rw-r--r-- 120.9 KB
namespace.c -rw-r--r-- 85.5 KB
no-block.c -rw-r--r-- 688 bytes
nsfs.c -rw-r--r-- 5.6 KB
open.c -rw-r--r-- 28.4 KB
pipe.c -rw-r--r-- 27.3 KB
pnode.c -rw-r--r-- 15.3 KB
pnode.h -rw-r--r-- 1.9 KB
posix_acl.c -rw-r--r-- 21.4 KB
proc_namespace.c -rw-r--r-- 7.8 KB
read_write.c -rw-r--r-- 46.8 KB
readdir.c -rw-r--r-- 11.2 KB
select.c -rw-r--r-- 34.4 KB
seq_file.c -rw-r--r-- 22.8 KB
signalfd.c -rw-r--r-- 8.8 KB
splice.c -rw-r--r-- 39.6 KB
stack.c -rw-r--r-- 2.5 KB
stat.c -rw-r--r-- 19.2 KB
statfs.c -rw-r--r-- 9.4 KB
super.c -rw-r--r-- 39.0 KB
sync.c -rw-r--r-- 9.9 KB
timerfd.c -rw-r--r-- 13.4 KB
userfaultfd.c -rw-r--r-- 50.6 KB
utimes.c -rw-r--r-- 7.1 KB
xattr.c -rw-r--r-- 23.5 KB

back to top