Revision d615628c354ad2aaf3f3f37b3f84ddcc7c3537c6 authored by Matthieu Moy on 31 May 2016, 13:24:43 UTC, committed by Junio C Hamano on 31 May 2016, 17:01:51 UTC
The DEVELOPER knob was introduced in 658df95 (add DEVELOPER makefile knob to check for acknowledged warnings, 2016-02-25), and works well when used as "make DEVELOPER=1", and when the configure script was not used. However, the advice given in CodingGuidelines to add DEVELOPER=1 to config.mak does not: config.mak is included after testing for DEVELOPER in the Makefile, and at least GNU Make's manual specifies "Conditional directives are parsed immediately", hence the config.mak declaration is not visible at the time the conditional is evaluated. Also, when using the configure script to generate a config.mak.autogen, the later file contained a "CFLAGS = <flags>" initialization, which overrode the "CFLAGS += -W..." triggered by DEVELOPER. This patch fixes both issues. Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent b051c59
| File | Mode | Size |
|---|---|---|
| static | ||
| INSTALL | -rw-r--r-- | 14.4 KB |
| Makefile | -rw-r--r-- | 5.5 KB |
| README | -rw-r--r-- | 2.3 KB |
| gitweb.perl | -rwxr-xr-x | 246.0 KB |
Computing file changes ...
