Skip to main content

Browse the archive

Revision d64ea0f83bd7e676778f833c57f969a94518a28d authored by Jeff King on 13 January 2015, 01:57:37 UTC, committed by Junio C Hamano on 13 January 2015, 18:03:30 UTC 
git-compat-util: add xstrdup_or_null helper
 
It's a common idiom to duplicate a string if it is non-NULL,
or pass a literal NULL through. This is already a one-liner
in C, but you do have to repeat the name of the string
twice. So if there's a function call, you must write:

  const char *x = some_fun(...);
  return x ? xstrdup(x) : NULL;

instead of (with this patch) just:

  return xstrdup_or_null(some_fun(...));

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 1da1e07
Raw File
check_bindir 
#!/bin/sh
bindir="$1"
gitexecdir="$2"
gitcmd="$3"
if test "$bindir" != "$gitexecdir" && test -x "$gitcmd"
then
	echo
	echo "!! You have installed git-* commands to new gitexecdir."
	echo "!! Old version git-* commands still remain in bindir."
	echo "!! Mixing two versions of Git will lead to problems."
	echo "!! Please remove old version commands in bindir now."
	echo
fi
back to top