| d6ff318 | Sergey Linev | 06 December 2023, 07:28:32 UTC | [http] do not expose current dir for webgui webgui uses THttpServer with limited functionality. Normally files from current directory can be read via THttpServer, but not in case of webgui where it opens potential security problem | 29 January 2024, 17:05:48 UTC |
| 642ceb8 | Sergey Linev | 06 December 2023, 16:48:58 UTC | [webgui] RWebWindowsManager::SetLoopbackMode() Introduce such method to let switch it off - for very special cases. | 29 January 2024, 17:05:48 UTC |
| 64e7969 | Danilo Piparo | 26 January 2024, 07:34:36 UTC | [Core] Change logo date from 2023 to 2024 | 26 January 2024, 07:41:57 UTC |
| 2779669 | Bertrand Bellenot | 25 January 2024, 07:55:09 UTC | [v6-30][core][backport] Fix random crashes on Windows Fix random crashes of the `imt101_parTreeProcessing` tutorial on Windows | 25 January 2024, 11:20:15 UTC |
| bbfce2a | Giulio Eulisse | 06 October 2023, 12:08:38 UTC | [llvm-project] Introduce paged vector The goal of the class is to be an (almost) drop in replacement for SmallVector and std::vector when those are presized and filled later, as it happens in SourceManager and ASTReader. By doing so, sparsely accessed PagedVector can profit from reduced memory footprint. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> (cherry picked from commit 9c7bac05ea52cea6757f083fec8e2b794f8b79d6) | 24 January 2024, 09:31:26 UTC |
| af32bb9 | Bertrand Bellenot | 19 January 2024, 15:48:35 UTC | Set builtin_afterimage=ON for all platforms See the Github issue #14247 | 23 January 2024, 10:25:17 UTC |
| d5ceb51 | Carsten Burgard | 20 December 2023, 20:26:01 UTC | [RF][HS3] Improved error reporting, using new populate feature The list of variables in the workspace is now no longer just filled from the parameter_points, but also from the domains, allowing cases where no parameter points are given to be imported successfully. Also, the HS3 version tag has been correctly updated to 0.2. | 23 January 2024, 09:03:26 UTC |
| 61af517 | Carsten Burgard | 20 December 2023, 20:25:36 UTC | [RF][HS3] Add method to fill workspace with all variables in "domains" | 23 January 2024, 09:03:26 UTC |
| 543c5be | Carsten Burgard | 20 December 2023, 20:25:06 UTC | [RF][HS3] Improved robustness, removed warnings The implementation is a bit more lenient when missing some values (e.g. ignoring cases where the histfactory modifier name has been omitted and instead just numbers the systematics) | 23 January 2024, 09:03:26 UTC |
| bfecdf6 | Carsten Burgard | 20 December 2023, 20:24:12 UTC | [RF][HS3] Improved error reporting from JSON parsing errors Errors from the nlohmann_json importer are now correctly forwarded to the user, rather than giving an unspecific "std_exception". | 23 January 2024, 09:03:26 UTC |
| 92cbb0f | Carsten Burgard | 20 December 2023, 20:23:31 UTC | [RF][HS3] Added importer for `normal_dist` Gaussians can now be imported with "normal_dist" as well, as described by the standard. | 23 January 2024, 09:03:26 UTC |
| 5dbbb5f | Carsten Burgard | 15 December 2023, 15:25:47 UTC | [RF] Error message in ParamHistFunc::getParameter() for invalid index | 23 January 2024, 09:03:26 UTC |
| 8ed6e82 | moneta | 22 January 2024, 11:18:39 UTC | [math][mathmore] Use suggestions by Jonas from PR review use MakeIOptions() instead of operator() | 23 January 2024, 09:03:26 UTC |
| 3c26dbc | moneta | 14 November 2023, 15:26:35 UTC | [math][mathmore] Fix setting optional parameters for GSLMCIntegrator Calling GSLMCIntegrator::SetMode crashed because the internal workspace wss not yet created. This is now fixed and also the way the extra option parameters are retrieved and set. Avoid now potential memory leak by using a unique_ptr | 23 January 2024, 09:03:26 UTC |
| e2d7a4f | moneta | 16 January 2024, 16:58:55 UTC | [hist] Fix the option X in TH1::KSTest Use as parent distribution for generating the toys for the NULL distribution of the test statistics the histogram with higer statistics. If it is a function use that one as parent. This commit takes into account the comment of Jonas in the PR | 23 January 2024, 09:03:26 UTC |
| 8edf95b | moneta | 06 October 2023, 15:46:54 UTC | [hist] Fix TH1::KolmogorovTest with option X when one histogram has zero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue #13697 | 23 January 2024, 09:03:26 UTC |
| 3296e68 | Sergey Linev | 07 December 2023, 10:34:31 UTC | [cmake] clarify search for nlohmann_json if find_package(ROOT) command list required components like: find_package(ROOT REQUIRED COMPONENTS Gpad) one can decide if external nlohmann/json really needed. If no components specified - always search for external, of course if builtin is not used | 22 January 2024, 12:34:49 UTC |
| 19699b2 | ferdymercury | 04 January 2024, 09:24:36 UTC | [gui] Editable combo box nullptr access if SetEnabled is called Fix bug introduced in https://github.com/root-project/root/commit/bc4e3d3787a30a5e4ccad5371044975f4481232e fSelEntry is a nullptr or not, depending on which constructor is called. Editable-combo-box constructor leaves fSelEntry as a nullptr, thus guards are needed. | 22 January 2024, 09:43:51 UTC |
| 4c37e18 | Philippe Canal | 11 December 2023, 10:05:06 UTC | Core: Add missing typeid name demangling | 19 January 2024, 20:38:23 UTC |
| 0744986 | Philippe Canal | 08 December 2023, 20:55:20 UTC | Core: Avoid (indirect) memory hoarding in TPluginManager. This was reported at https://github.com/art-framework-suite/art/issues/142 and is due to the combination of (a) We do not generate dictionary for std::tuple instances (b) When TClass::GetClass is called it tries to load the dictonary until there is a full TClass object is in memory (c) The emulated std::tuple TClass are marked as 'not loaded' (d) Searching for the TClass for a templated class will cost memory (during the lookup of the instantiation). (e) TPluginManager::ExecPluginImpl was looking up the TClass for the typle `std::type< list of arguments>` The lookup induced in (e) in the user's case (root built with runtime cxx module on) lead to some memory allocation in Clang while trying to find out if there was now a library or dictionary to load. | 19 January 2024, 20:38:23 UTC |
| bd5c08e | Sergey Linev | 07 December 2023, 12:52:24 UTC | Provide initializer for TROOT web display flags | 19 January 2024, 07:59:06 UTC |
| adb7ec0 | Sergey Linev | 07 December 2023, 12:47:52 UTC | Disable rc parameter for web based tree viewer If in rootrc file web-based tree viewer stored and web mode is not active, it will be disabled with warning message | 19 January 2024, 07:59:06 UTC |
| afe6e20 | Sergey Linev | 06 December 2023, 16:31:12 UTC | Let start web browser only in web mode | 19 January 2024, 07:59:06 UTC |
| b3d759c | Sergey Linev | 06 December 2023, 16:30:36 UTC | Do not create web canvas and browser from rootrc Handling in normal TRootGuiFactory, where normal classes are created as well | 19 January 2024, 07:59:06 UTC |
| af11360 | Sergey Linev | 06 December 2023, 16:30:02 UTC | Do not create web browser from rootrc without web | 19 January 2024, 07:59:06 UTC |
| 48e6005 | Sergey Linev | 06 December 2023, 16:29:11 UTC | Disable WebGui.Display rootrc parameter | 19 January 2024, 07:59:06 UTC |
| 0c8b8cc | Sergey Linev | 06 December 2023, 16:28:41 UTC | Disable --web args for TApplication | 19 January 2024, 07:59:06 UTC |
| 560a615 | ferdymercury | 18 January 2024, 15:53:35 UTC | [mysql] alternative for deprecated or removed methods in v8 (#14378) * [sql] alternative for deprecated or removed methods Fixes https://github.com/root-project/root/issues/14376 See https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal * fix syntax | 19 January 2024, 07:53:42 UTC |
| ab4e9b0 | moneta | 17 January 2024, 09:22:28 UTC | [tmva][tutorial] Fix a potential issue when creating the test data sets When creating the test data sets for the CNN and RNN tutorials, it is better to create the TTree attached to the output file so we can avoid a potential issue when deleting the file and the TTree's | 17 January 2024, 23:29:53 UTC |
| be7addb | Vincenzo Eduardo Padulano | 16 January 2024, 20:49:44 UTC | [core] Fix statements at global scope in TCling test `TInterpreter::Declare` does not support issuing statements on the global scope, while `TInterpreter::ProcessLine` does. This test was first introduced in a development version of ROOT (6.31), where the upgrade to LLVM16 was already in place. In that scenario, clang supports global scope statements (thanks to changes made for clang-repl). Applying the test to ROOT 6.30 uncovered the problem, since the clang of LLVM13 does not support global scope statements. Fix the test by using `ProcessLine` instead of `Declare` which does the intended thing independently from the ROOT version. Co-authored-by: Vassil Vassilev <vasil.georgiev.vasilev@cern.ch> | 17 January 2024, 12:13:52 UTC |
| 0286aa7 | Vincenzo Eduardo Padulano | 08 January 2024, 10:53:20 UTC | [core] Make some constants constexpr This allows us to avoid generating symbols in libCore for these constants keeping the same amount of open calls at ROOT startup time. | 17 January 2024, 12:13:52 UTC |
| 0fda995 | Vassil Vassilev | 20 December 2023, 18:24:47 UTC | Revert "[core] Materialize symbols for TError variables" This reverts commit 329fb5ae0c5717aec95fe50ec276f07450ac7f11. | 17 January 2024, 12:13:52 UTC |
| 183f3fe | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Prefer variable initializer over symbol search Symbol lookup is a quite expensive operation and might result in JIT compilation and library loading. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 17 January 2024, 12:13:52 UTC |
| 6a854cb | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Evaluate initializer of constant variables Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 17 January 2024, 12:13:52 UTC |
| 25f4e17 | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Reduce symbol search only to when autoloading is enabled. The llvm9 JIT issued callbacks when a symbol was missing and we reacted on it by loading the relevant library. In root-project/root@9b2041e3 we have kept the logic but now the JIT started querying more often even for symbols which are okay to be missing. In turn that leads to scanning all libraries causing performance issues. This patch tries to limit this functionality only in contexts where automatic loading is allowed. | 17 January 2024, 12:13:52 UTC |
| c8781ce | will-cern | 08 January 2024, 19:16:32 UTC | [RF] Update xroofit (#14292) Latest updates for xRooFit API. Includes a bug fix for jupyter notebook plot display in 6.30 onwards. Due to changes in the 6.30 jupyter notebook behaviour, this PR is required to fix the display of plots in these notebooks. Also includes a new method for creating a hypoSpace for limit calculations, with explicit specification of the test statistic type. Some other minor improvements are included. Also, remove physical range for all test statistics other than qmutilde. | 17 January 2024, 12:05:57 UTC |
| 0f289cc | Bertrand Bellenot | 12 January 2024, 14:29:06 UTC | Fix JupyROOT crash on Windows. Fixes the issue #14302 Remove `#include <cassert>` from `TGeoExtension.h` and move it to the `TGeoExtension.cxx` source file, fixing a potential crash of JupyROOT when running on a machine with a different version of the Windows SDK than the one used to build ROOT, as described in the Github issue #14302 and as shown below. The issue comes from this code in `JupyROOT\helpers\utils.py`: ``` def GetGeometryDrawer(): if not hasattr(ROOT,'gGeoManager'): return if not ROOT.gGeoManager: return if not ROOT.gGeoManager.GetUserPaintVolume(): return vol = ROOT.gGeoManager.GetTopVolume() if vol: return NotebookDrawer(vol) ``` triggering the autoloading of libGeom, leading to this error: ``` In file included from libGeom dictionary payload:17: In file included from C:/root-dev/root\include\TGeoExtension.h:15: In file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt.h:260:12: error: redefinition of '_CrtEnableIf<true, _Ty>' struct _CrtEnableIf<true, _Ty> ^~~~~~~~~~~~~~~~~~~~~~~ C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt\corecrt.h:260:12: note: previous definition is here struct _CrtEnableIf<true, _Ty> ^ In file included from libGeom dictionary payload:17: In file included from C:/root-dev/root\include\TGeoExtension.h:15: In file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt.h:610:16: error: redefinition of '__crt_locale_data_public' typedef struct __crt_locale_data_public ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt\corecrt.h:610:16: note: previous definition is here typedef struct __crt_locale_data_public ^ In file included from libGeom dictionary payload:17: In file included from C:/root-dev/root\include\TGeoExtension.h:15: In file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt.h:617:16: error: redefinition of '__crt_locale_pointers' typedef struct __crt_locale_pointers ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt\corecrt.h:617:16: note: previous definition is here typedef struct __crt_locale_pointers ^ In file included from libGeom dictionary payload:17: In file included from C:/root-dev/root\include\TGeoExtension.h:15: In file included from C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt.h:625:16: error: redefinition of '_Mbstatet' typedef struct _Mbstatet ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ucrt\corecrt.h:625:16: note: previous definition is here typedef struct _Mbstatet ^ Error in <TInterpreter::AutoParse>: Error parsing payload code for class gGeoManager with content: ... Assertion failed: !m_Unloading && "Must not nest within unloading transaction", file C:\root-dev\git\master\interpreter\cling\lib\Interpreter\Transaction.cpp, line 98 *** Break *** abort ========================================== =============== STACKTRACE =============== ========================================== ... ``` | 15 January 2024, 15:05:14 UTC |
| 8b1aad3 | Vincenzo Eduardo Padulano | 01 November 2023, 23:19:41 UTC | [relnotes] Add students to 6.30 release notes | 12 January 2024, 13:40:50 UTC |
| 38cc267 | moneta | 07 November 2023, 15:28:43 UTC | Update release notes for 6.30 for new contributors | 12 January 2024, 13:40:50 UTC |
| 0df1c6a | Sanjiban Sengupta | 05 November 2023, 00:22:43 UTC | feat: update release notes with SOFIE changes and implementations | 12 January 2024, 13:40:50 UTC |
| 7312bda | Axel Naumann | 15 December 2023, 10:38:55 UTC | [cmake] gitinfo.txt: also provide commit line for tags. | 09 January 2024, 15:49:51 UTC |
| d2a9b57 | Axel Naumann | 14 December 2023, 11:40:44 UTC | [root-config] Fix --git-revision: Fixes https://github.com/root-project/root/issues/14229 | 09 January 2024, 15:49:51 UTC |
| 0541c6f | Vincenzo Eduardo Padulano | 19 December 2023, 17:14:16 UTC | [core] Materialize symbols for TError variables The variables present in TError.h are used throughout the ROOT libraries. Anytime one of these variables is requested, e.g. with a simple test such as `python -c "import ROOT; ROOT.kError"`, the interpreter will lookup the corresponding symbol. Previously, the variables were declared and defined in the header directly but were not generating any symbol since the linkage was internal. With this commit, provide external linkage to these variables so that the corresponding symbols are materialized in libCore.so. As a consequence, a huge number of extra lookups by cling is avoided. | 20 December 2023, 08:49:59 UTC |
| 793371f | will-cern | 14 December 2023, 15:23:04 UTC | ensure globalObservables is always created, even if no lumiError | 19 December 2023, 22:02:43 UTC |
| 8656e35 | Jonas Rembser | 18 December 2023, 13:02:29 UTC | [RF] Avoid `nlohmann_json` as a public dependency of RooFit Multiprocess Using `nlohmann_json` as a public dependency of ROOT can result in different troubles, like #14188. That's why it's better to avoid this dependency if we can, also to minimize the dependency of RooFit on the interface level. In the case of RooFit, the only reason for this dependency was the `HeatmapAnalyzer::getMetadata()` function. However, it just returned a json with a vector of string lables. We can also return a `std::vector<std::string>` here. I already talked with @Zeff020 about this change, and he is completely fine with it. The class was also only used by the RooFit Multiprocess developers so far, so changing the interface is fine. With this interface change, only some refactoring was necessary to avoid including `nlohmann_json` in the RooFit headers. This commit is similar to 9d7aa4a96e. | 19 December 2023, 22:02:43 UTC |
| 0c4afd3 | Jonas Rembser | 18 December 2023, 13:19:22 UTC | [RF] Make dependency of RooFit JSON Interface on `nlohmann` private In the RooFit `json_interface`, the calls to the actual JSON library are abstracted away, such that the libraries like `nlohmann_json` are not included in the headers. Therefore, `nlohmann_json` is a private dependency of the RooFit JSON interface, not a public one. | 19 December 2023, 22:02:43 UTC |
| 34afaae | Jonas Rembser | 18 December 2023, 10:52:58 UTC | [tmva] Fix new warning in TMVA with gcc 13.2 When compiling with gcc 13.2, there is a new warning in TMVA that is fixed by this commit: ```c++ In static member function ‘static constexpr _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = long unsigned int; _Up = long unsigned int; bool _IsMove = true]’, inlined from ‘constexpr _OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = true; _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13.2.1/bits/stl_algobase.h:506:30, inlined from ‘constexpr _OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = true; _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13.2.1/bits/stl_algobase.h:533:42, inlined from ‘constexpr _OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = true; _II = long unsigned int*; _OI = long unsigned int*]’ at /usr/include/c++/13.2.1/bits/stl_algobase.h:540:31, inlined from ‘constexpr _OI std::copy(_II, _II, _OI) [with _II = move_iterator<long unsigned int*>; _OI = long unsigned int*]’ at /usr/include/c++/13.2.1/bits/stl_algobase.h:633:7, inlined from ‘static _ForwardIterator std::__uninitialized_copy<true>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = std::move_iterator<long unsigned int*>; _ForwardIterator = long unsigned int*]’ at /usr/include/c++/13.2.1/bits/stl_uninitialized.h:147:27, inlined from ‘_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = move_iterator<long unsigned int*>; _ForwardIterator = long unsigned int*]’ at /usr/include/c++/13.2.1/bits/stl_uninitialized.h:185:15, inlined from ‘constexpr _ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, allocator<_Tp>&) [with _InputIterator = move_iterator<long unsigned int*>; _ForwardIterator = long unsigned int*; _Tp = long unsigned int]’ at /usr/include/c++/13.2.1/bits/stl_uninitialized.h:373:37, inlined from ‘constexpr _ForwardIterator std::__uninitialized_move_if_noexcept_a(_InputIterator, _InputIterator, _ForwardIterator, _Allocator&) [with _InputIterator = long unsigned int*; _ForwardIterator = long unsigned int*; _Allocator = allocator<long unsigned int>]’ at /usr/include/c++/13.2.1/bits/stl_uninitialized.h:399:2, inlined from ‘constexpr void std::vector<_Tp, _Alloc>::_M_range_insert(iterator, _ForwardIterator, _ForwardIterator, std::forward_iterator_tag) [with _ForwardIterator = const long unsigned int*; _Tp = long unsigned int; _Alloc = std::allocator<long unsigned int>]’ at /usr/include/c++/13.2.1/bits/vector.tcc:819:9, inlined from ‘constexpr std::vector<_Tp, _Alloc>::iterator std::vector<_Tp, _Alloc>::insert(const_iterator, std::initializer_list<_Tp>) [with _Tp = long unsigned int; _Alloc = std::allocator<long unsigned int>]’ at /usr/include/c++/13.2.1/bits/stl_vector.h:1411:17, inlined from ‘void TMVA::MethodDL::ParseInputLayout()’ at /home/rembserj/spaces/master/root/src/root/tmva/tmva/src/MethodDL.cxx:470:24: /usr/include/c++/13.2.1/bits/stl_algobase.h:437:30: error: ‘void* __builtin_memmove(void*, const void*, long unsigned int)’ forming offset 32 is out of the bounds [0, 32] [-Werror=array-bounds=] 437 | __builtin_memmove(__result, __first, sizeof(_Tp) * _Num); | ``` The fix suggested in this commit is to directly assign from a full initializer list, which is also more readable in the code. | 19 December 2023, 22:02:43 UTC |
| f97e7bb | Jonas Rembser | 16 December 2023, 20:02:49 UTC | [RF] Fix ownership problem in `RooGenProdProj` At some point in `RooGenProdProj::createIntegral()`, an intermediate integral object that should only live during the scope of the function is accidentally put in the `saveSet` output parameter. This needs to be fixed. Thanks to the following forum post for noticing this: https://root-forum.cern.ch/t/error-inputarguments-rooargset-error-argument-with-name-is-already-in-this-set-in-roomcstudy/57571 | 19 December 2023, 22:02:43 UTC |
| 5a892ec | ferdymercury | 18 December 2023, 09:16:27 UTC | [nfc] fix alignment doxygen | 19 December 2023, 22:02:43 UTC |
| ee9d8de | ferdymercury | 18 December 2023, 09:14:35 UTC | fix explanation of docu setticks | 19 December 2023, 22:02:43 UTC |
| a47bf6d | ferdymercury | 17 December 2023, 17:48:10 UTC | GetTicks should be the analogous of SetTicks Fixes https://github.com/root-project/root/issues/14256 | 19 December 2023, 22:02:43 UTC |
| 030a632 | Wouter Deconinck | 15 December 2023, 18:55:37 UTC | thisroot.sh: if exe contains qemu, use /proc/$$/comm instead | 19 December 2023, 22:02:43 UTC |
| 469cf95 | Tomas Dado | 15 December 2023, 17:05:37 UTC | Fixing issue 14225 Fixing a crash in HistoToWorkspaceFactoryFast.cxx where a parameter that was globally set to be constant was not found a given region, but the code was still accessing the parameter even when it was nullptr. Now the parameter is set to constant only when found in a given region. Also demoting the error to warning as this does not always indicate a wrong setup. | 19 December 2023, 22:02:43 UTC |
| d7a0419 | Carsten Burgard | 15 December 2023, 15:25:58 UTC | [RF][HS3] Force exporting also empty ShapeSys In the current implementation, shapesys with no valid data (all constraints constant) are written out in an invalid way, making it impossible for the reader to then instantiate the correct number of parameters. This PR fixes this by forcing the write-out of data with all-zeros for such invalid shapesys. Alternatively, one could imagine dropping these shapesys completely, but that's maybe something of a policy decision that I don't want to make in a bugfix patch :) | 19 December 2023, 22:02:43 UTC |
| 8f21f0b | Atri Bhattacharya | 05 December 2023, 02:34:33 UTC | Minuit2: Install libs to CMAKE_INSTALL_LIBDIR. Instead of hard-coding 'lib' as the path to which minuit2 is installed as a standalone library, use the user configurable CMAKE_INSTALL_LIBDIR. As a particularly common example, this allows a user to specify the library installation path to '${_prefix}/lib64' on 64-bit machines from the cmake command line. | 19 December 2023, 22:02:43 UTC |
| 1bf2833 | Nicolas Morange | 27 June 2023, 15:17:11 UTC | Fix bug in DiagProd calculation Fixes a small bug in calculation of product of diagonal terms in LU matrix decompositions. A unit test to cover the former bug is also implemented. | 19 December 2023, 22:02:43 UTC |
| f0a3020 | Vincenzo Eduardo Padulano | 18 December 2023, 07:50:06 UTC | [core] Properly define TString::kNPOS data member according to standard C++ A declaration of a static data member *is not* also a definition, even if the data member is default-initialized in the class body. The definition must be explicitly written in one TU, which also ensures proper ODR use. See https://en.cppreference.com/w/cpp/language/definition. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 19 December 2023, 13:30:24 UTC |
| 146f08e | Vincenzo Eduardo Padulano | 01 November 2023, 17:06:10 UTC | [tmva][NFC] Add RBatchGenerator to release notes | 19 December 2023, 07:46:29 UTC |
| 74adc6d | Vincenzo Eduardo Padulano | 01 November 2023, 16:59:39 UTC | [tmva][NFC] Make RBatchGenerator tutorials visible on website | 19 December 2023, 07:46:29 UTC |
| cfcbf32 | Attila Krasznahorkay | 05 December 2023, 10:18:20 UTC | Explicitly set Vdt_ROOT when builtin_vdt was used for the build. This way, a default location would be provided for VDT, which the user could still override if they wanted to. | 19 December 2023, 06:59:32 UTC |
| b65f812 | Attila Krasznahorkay | 05 December 2023, 13:45:52 UTC | Require CMP0074 to be NEW for ROOTConfig.cmake. | 19 December 2023, 06:59:32 UTC |
| c983a63 | Dmitry Kalinkin | 15 December 2023, 01:23:21 UTC | interpreter/CMakeLists.txt: correct CLANG_INCLUDE_DIRS This looks like a regression from https://github.com/root-project/root/commit/7a1cc8ffe576490b2f977ba2c262e10ec53a797a#diff-93558e500b17901f800fbb40a2c2fdfd6ee229077db63413bd4a91ee7ec66ea7. It seems like interpreter/llvm-project/llvm/tools/clang would not be a thing, while a following compilation error is observed: In file included from interpreter/cling/lib/Utils/AST.cpp:12: In file included from interpreter/llvm-project/clang/include/clang/AST/ASTContext.h:18: interpreter/llvm-project/clang/include/clang/AST/ASTFwd.h:21:10: fatal error: 'clang/AST/DeclNodes.inc' file not found #include "clang/AST/DeclNodes.inc" ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. (cherry picked from commit 1477d3adebf27a19f3a8b85f21c27a0a5649c7ff) | 18 December 2023, 12:29:24 UTC |
| fb34130 | Bertrand Bellenot | 14 December 2023, 08:10:32 UTC | Add a safety check on `std::multimap::empty()` Prevent a potential crash on Windows in Debug mode when the multimap is empty | 15 December 2023, 09:07:25 UTC |
| cddfb0d | Bertrand Bellenot | 11 December 2023, 14:40:44 UTC | Use the correct parameter types for `NetLocalGroupEnum` and `NetLocalGroupGetMembers` | 13 December 2023, 16:31:31 UTC |
| 56083e2 | Axel Naumann | 08 December 2023, 10:30:11 UTC | Revert "[Cling] Simplify std::tuple/pair value printer" This reverts commit bfbb58e6f74c38b883ce6e6e096b6c6e44028869. (backported as c49d7924555eea22ce8f7c0fa70870e144b17845) cling needs to be able to interpret C++11, even if built with C++17. (cherry picked from commit 06cdb2ae613624847ab6edd146f57b6447e046a7) | 13 December 2023, 13:26:06 UTC |
| 079dd90 | Jonas Hahnfeld | 05 December 2023, 13:28:02 UTC | [cling] Provide fallback for LLVM_INCLUDE_DIRS In standalone builds, it could otherwise happen that the variable is not set during the first CMake invocation and tests fail because they are unable to locate the LLVM headers. (cherry picked from commit e84a7964b4b10f9fd3c751af9e8562cabcf1fb97) | 13 December 2023, 13:26:06 UTC |
| a1ddff6 | Axel Naumann | 05 December 2023, 14:10:46 UTC | [cling] test/Driver/CommandHistory.C: `env -u` also works on macOS. (cherry picked from commit 7a0481bc0a7f6260e207f7de3c5114a9f703b3aa) | 13 December 2023, 13:26:06 UTC |
| dab6106 | Vassil Vassilev | 21 July 2023, 11:59:08 UTC | [cling] Correctly infer the SDKROOT. This fixes the -lSystem issues we saw on recent osx platforms. (cherry picked from commit 51c26e882d8e1704e2c8936df50a455dcb8730e8) | 13 December 2023, 13:26:06 UTC |
| 972e9dd | Vassil Vassilev | 21 July 2023, 11:58:46 UTC | [cling] Handle llvm::Errors correctly. This fixes several tests on osx. (cherry picked from commit 10510eddef1591956aba86e878beda36967403e5) | 13 December 2023, 13:26:06 UTC |
| d3a084b | Jonas Hahnfeld | 24 November 2023, 13:39:34 UTC | [cling] DeclUnloader: Remove extra check isInstantiatedInPCH This effectively reverts commit 74472caaa9 ("[cling] Fixes issue in DeclUnloader: do not unload templates intantiated in the PCH"), it's not needed anymore, all tests pass and the snippet in the summary of https://github.com/root-project/root/pull/4447 works, but it filters too many declarations from the unloader. (cherry picked from commit 1c3ea0a068bc22eacf0dee087d8e3e2801b8018d) | 13 December 2023, 13:26:06 UTC |
| 4b89409 | Javier Lopez-Gomez | 29 August 2023, 14:43:05 UTC | [cling] DeclUnloader: do not delete instantiated member functions The body of member functions of a templated class only gets instantiated when the function is used. These `CXXMethodDecl` should not be deleted from the AST; instead return them to the 'instantiation pending' state. (cherry picked from commit afba1d737aeafd554ac4763fcc2d542de961be2a) | 13 December 2023, 13:26:06 UTC |
| ce28d24 | Javier Lopez-Gomez | 29 August 2023, 14:43:05 UTC | [cling] DeclUnloader: remove StaticVarCollector StaticVarCollector recursively visited descendants of a `FunctionDecl` node to collect static local variables. However, these always appear in the enclosing DeclContext. (cherry picked from commit bd28a5b793947c1b777edb376c35062da409281b) | 13 December 2023, 13:26:06 UTC |
| 699678e | Jonas Rembser | 04 December 2023, 13:22:16 UTC | [RF] Make `RooFFTConfPdf` also work if ROOT was built with `fftw3=OFF` Since ROOT 6.30, we are not building ROOT with the `math/fftw` subpackage anymore (`fftw3=OFF`). It is the interface between ROOT and fftw3, but is incompatible with fftws GPL license. That means that for default ROOT builds, the `RooFFTConvPdf` class for FFT convolutions is not working anymore, because it uses `math/fftw`. This commit implements a solution to make the `RooFFTConvPdf` work again in this situation: the routine that uses fftw is declared on-the-fly to the interpreter. This will work if the user has an external install of `fftw3`, which is usually available in all Linux distributions. | 11 December 2023, 08:32:47 UTC |
| a9ac02c | Jonas Rembser | 05 December 2023, 16:30:49 UTC | [RF] Again skip overflow bins correctly in HistFactory in 2D and 3D case In the 6.30 dev cycle, I made a mistake when refactoring the HistFactory code in 3c68044c257: https://github.com/root-project/root/commit/3c68044c257e9ee7207e23e7cceb69d7eda596e9#diff-42ea09980f1ed2bacde4381f212c35d78be6ddedccf746953dc99d6455525d8aL1801-L1804 The robust way to skip overflow bins in 2D and 3D was replaced with something that only worked in 1D. Thanks to Veronica for reporting this on the ROOT forum! https://root-forum.cern.ch/t/discrepancy-in-2d-histfactory-fit-results-between-root-versions-6-28-06-vs-nightlies-with-beeston-barlow-method-activated I validated now that the fit results with the reproducer on the forum are the same with 6.28 and 6.30. To be backported to the 6.30 branch. | 11 December 2023, 08:32:47 UTC |
| fd72fc5 | Mattias Ellert | 02 December 2023, 17:50:04 UTC | Adjust test for failures on aarch64, ppc64le and s390x [ RUN ] RooTruthModel.IntegrateSubrange [#1] INFO:Eval -- RooRealVar::setRange(dt) new range named 'integral' created with bounds [2,2] /builddir/build/BUILD/root-6.30.02/roofit/roofitcore/test/testRooTruthModel.cxx:38: Failure Expected equality of these values: integ->getVal() Which is: -2.8822093e-17 0.0 Which is: 0 [ FAILED ] RooTruthModel.IntegrateSubrange (194 ms) | 11 December 2023, 08:32:47 UTC |
| 33f75f0 | Axel Naumann | 04 December 2023, 16:02:37 UTC | [relnotes] Mention the version number layout change: v6.30.00 instead of v6.30/00. Fixes https://github.com/root-project/root/issues/14068 | 04 December 2023, 16:02:37 UTC |
| 07f69d5 | Axel Naumann | 04 December 2023, 15:58:35 UTC | [relones] I meant to say GCC *13* is now supported. | 04 December 2023, 15:58:35 UTC |
| 1210ee4 | Atri Bhattacharya | 01 December 2023, 16:30:32 UTC | Minuit2: Fix VERSION_FILE path for standalone mode Fixes #14157. When building minuit2 standalone with root 6.30/02 (-Dminuit2_standalone=ON), cmake errors out when looking for the version file 'RVersion.hxx' in 'core/foundation/inc/ROOT/RVersion.hxx' whereas it is copied to the top-level dir (i.e. 'math/minuit2/'). This is because the variable VERSION_FILE is incorrectly set to the file path matching the full path of the file. Fixed by setting the parent dir path of 'RVersion.hxx' as the `SOURCE` in `copy_standalone()` so that `VERSION_FILE` is set to just the base file name. | 02 December 2023, 10:30:43 UTC |
| a6ff42a | Sergey Linev | 30 November 2023, 12:54:35 UTC | [webgui] do not compile without http | 01 December 2023, 07:14:22 UTC |
| 8b6c850 | Axel Naumann | 30 November 2023, 09:56:48 UTC | [ci] Remove `--shm-size=1g -m 16`: I suspect that this is the cause of the error: ``` Resource limits are not supported and ignored on cgroups V1 rootless systems aaa674cabd09a8ff746c97b6c9b065865428b74ddcbcbe54a9892fc3c47d7407 /bin/docker start aaa674cabd09a8ff746c97b6c9b065865428b74ddcbcbe54a9892fc3c47d7407 Error: OCI runtime error: unable to start container "aaa674cabd09a8ff746c97b6c9b065865428b74ddcbcbe54a9892fc3c47d7407": runc: runc create failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: cannot set memory limit: container could not join or create cgroup Error: Docker start fail with exit code 125 ``` (cherry picked from commit 1e3e8e178ee439163001d615545eba2391cbab33) | 30 November 2023, 10:29:08 UTC |
| 325614f | Axel Naumann | 27 November 2023, 18:29:01 UTC | [foundation] Update version file to 6.30.03: dev phase for next patch release cycle. | 27 November 2023, 18:29:01 UTC |
| 49ae85f | Axel Naumann | 27 November 2023, 18:27:38 UTC | [foundation] Update version file to 6.30.02. | 27 November 2023, 18:27:38 UTC |
| 7e399bf | Axel Naumann | 27 November 2023, 18:09:03 UTC | [relnotes] Update for 6.30/02. | 27 November 2023, 18:25:48 UTC |
| 4a9f156 | Sergey Linev | 27 November 2023, 15:38:41 UTC | [webgui] always use classical browser by default RBrowser only can be enabled when specify --web parameter | 27 November 2023, 17:20:50 UTC |
| 3a8fab7 | Sergey Linev | 27 November 2023, 12:12:47 UTC | [webgui] always use loopback Disregard of rootrc parameters always assign loopback. The only valid alternative - unix socket. FastCGI is also disabled for the moment; it is alternative to civetweb | 27 November 2023, 16:36:24 UTC |
| 971c466 | Sergey Linev | 27 November 2023, 11:59:21 UTC | [webgui] change TWebCanvas warning | 27 November 2023, 16:36:24 UTC |
| b72d709 | Sergey Linev | 27 November 2023, 11:59:03 UTC | [webgui] change RBrowser warning | 27 November 2023, 16:36:24 UTC |
| f5e3967 | Axel Naumann | 27 November 2023, 08:36:30 UTC | Package names: keep minor version number for Ubuntu | 27 November 2023, 10:25:38 UTC |
| 3f1f801 | Axel Naumann | 27 November 2023, 08:14:38 UTC | Fix argument order for lowercasing OS ID. | 27 November 2023, 10:25:38 UTC |
| 46009c8 | Axel Naumann | 27 November 2023, 08:13:35 UTC | Make sure quotes are not included in the VERSION_ID. | 27 November 2023, 10:25:38 UTC |
| 0a26b3c | Axel Naumann | 24 November 2023, 12:48:22 UTC | CPack: Simplify; allow CentOS minor versions. (cherry picked from commit f5f6b1dc4eaa6af733f7b3d1a58d0809c194abac) | 26 November 2023, 14:42:20 UTC |
| d843327 | Axel Naumann | 24 November 2023, 12:43:59 UTC | CPack: add missing hyphen in general Linux package name. (cherry picked from commit 8399038a57375d6d76f7aff9aeb1720d237a55e4) | 26 November 2023, 14:42:20 UTC |
| e6663d6 | Axel Naumann | 24 November 2023, 12:43:28 UTC | Remove SLC: it is superseded by Alma. (cherry picked from commit 1fa9cb0d90fb96c3f2815f2441fb37478d5f43bf) | 26 November 2023, 14:42:20 UTC |
| 4a0794d | Axel Naumann | 24 November 2023, 07:56:39 UTC | [cpack] Remove "VERSION_ID" from package names: Newer Fedoras do not quote the version number anymore, make that optional. Fixes #14103. (cherry picked from commit f49706fcba5096f84d3d73f5cac780f4aaa23a89) | 26 November 2023, 14:42:20 UTC |
| baa6ff7 | Axel Naumann | 07 November 2023, 14:35:55 UTC | [ci] Build the binaries for workflow dispatch! (cherry picked from commit a3ff83fa29df7fe851ba6cb0dde9db913b11ea05) | 26 November 2023, 14:42:20 UTC |
| 2f86c47 | Sergey Linev | 21 November 2023, 11:32:41 UTC | [webgui] improve handling of embed widgets In RBrowser different widgets are embed. Add dummy pending connection handle to get possibility for widget wait for such connection been established | 24 November 2023, 15:14:51 UTC |
| 9f086bd | Sergey Linev | 21 November 2023, 07:32:09 UTC | [webgui] use loopback by default Default value is on in C++ code, but was remained off in system.rootrc and over-rulling C++ | 24 November 2023, 15:14:35 UTC |
| 515a162 | Jonas Rembser | 23 November 2023, 15:50:56 UTC | [CMake] Always build Minuit2 In the discussion thread to JIRA ticket ROOT-10864, Axel suggested the removal of the option to disable minuit2 as a possible solution. I think this is a very good idea good idea, because: * Minuit2 only depends on `Hist` and `MathCore` anyway. * Now that Minuit2 is the default for *all* minimization in ROOT, building ROOT without Minuit2 changes the behavior of ROOT way too much, in a ways that people that set `minuit2=OFF` probably are not intending or aware of. This closes the following JIRA ticket: https://sft.its.cern.ch/jira/browse/ROOT-10864 | 24 November 2023, 14:04:26 UTC |
| be2f4e3 | Mattias Ellert | 14 October 2023, 13:51:16 UTC | src/RBDT.cxx is a source file of libTMVAUtils and should not also be a source file of libTMVA. Remove it. Adjust test using symbols defined in this source file to link to libTMVAUtils instead of libTMVA. | 24 November 2023, 14:04:26 UTC |
| e94a285 | Jonas Rembser | 07 November 2023, 12:36:23 UTC | [math][minuit2] Don't try to copy non-existing file in standalone build Follows up on 8ce465cc41c. That commit introduced two months ago a copying of the `ROOTConfig-version.cmake` file to the Minuit 2 standalone build dir. However, this file is only available after building ROOT, as it's generated from the `ROOTConfig-version.cmake.in` template. A ROOT build should not be required for Minuit 2 standalone. Therefore, this commit suggests a different way to get the ROOT version number: by inspecting the header files from the ROOT source. | 24 November 2023, 14:04:26 UTC |
