https://github.com/thinkaurelius/titan
Revision d78a0801de473a1943061ef616d0252b55b98f66 authored by Dan LaRocque on 13 February 2015, 20:35:46 UTC, committed by Dan LaRocque on 13 February 2015, 20:51:20 UTC
278d8b988058183ed032b03959771864f6b37a0c introduced an exception during graph startup when configured to use HBase with Metrics. This causes setup errors in HBaseOperationCountingTest, but it's not just an issue of updating some outdated expectation numbers as in ee8f75a604071db919f0a18a11a1bc72cc1c883f. This is actually a problem with Titan proper. The commit that introduced this regression wraps the backend with MetricsInstrumentedStoreManager early in startup, before wrapping with TTLKCVSManager. TTLKCVSManager expects `instanceof CustomizeKCVSManager` on its encapsulated backend to be true unless it implements cell-level TTL; this is true of HBaseSM, but not of MetricsInstrumentedSM. Doing instanceof <some manager-extension interface> in wrappers is generally problematic since we have so many manager/store wrapper classes. The typecasts prevent the compiler from helping us catch this stuff. However, this is (hopefully) the last commit before the next bugfix release, so I don't want to go overboard with hurried refactoring and break something else. I made TTLKCVSManager implement CustomizeStoreKCVSManager and check that its wrapped backend is instanceof same when the openDatabase(name, ttl) method is invoked.
1 parent 5f2a016
Tip revision: d78a0801de473a1943061ef616d0252b55b98f66 authored by Dan LaRocque on 13 February 2015, 20:35:46 UTC
Fix HBase + TTL + Metrics
Fix HBase + TTL + Metrics
Tip revision: d78a080
File | Mode | Size |
---|---|---|
docs | ||
titan-all | ||
titan-berkeleyje | ||
titan-cassandra | ||
titan-core | ||
titan-dist | ||
titan-es | ||
titan-hadoop-parent | ||
titan-hbase-parent | ||
titan-lucene | ||
titan-rexster | ||
titan-solr | ||
titan-test | ||
.gitignore | -rw-r--r-- | 1.1 KB |
CHANGELOG.asc | -rw-r--r-- | 24.8 KB |
LICENSE.txt | -rw-r--r-- | 11.1 KB |
NOTICE.txt | -rw-r--r-- | 5.8 KB |
README.textile | -rw-r--r-- | 2.0 KB |
RELEASING.md | -rw-r--r-- | 3.5 KB |
TESTING.md | -rw-r--r-- | 3.7 KB |
UPGRADE.asc | -rw-r--r-- | 16.8 KB |
jre6.xslt | -rw-r--r-- | 1.5 KB |
pom.xml | -rw-r--r-- | 69.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...