Revision d80e731ecab420ddcb79ee9d0ac427acbc187b4b authored by Oleg Nesterov on 24 February 2012, 19:07:11 UTC, committed by Linus Torvalds on 24 February 2012, 19:42:50 UTC
This patch is intentionally incomplete to simplify the review.
It ignores ep_unregister_pollwait() which plays with the same wqh.
See the next change.

epoll assumes that the EPOLL_CTL_ADD'ed file controls everything
f_op->poll() needs. In particular it assumes that the wait queue
can't go away until eventpoll_release(). This is not true in case
of signalfd, the task which does EPOLL_CTL_ADD uses its ->sighand
which is not connected to the file.

This patch adds the special event, POLLFREE, currently only for
epoll. It expects that init_poll_funcptr()'ed hook should do the
necessary cleanup. Perhaps it should be defined as EPOLLFREE in
eventpoll.

__cleanup_sighand() is changed to do wake_up_poll(POLLFREE) if
->signalfd_wqh is not empty, we add the new signalfd_cleanup()
helper.

ep_poll_callback(POLLFREE) simply does list_del_init(task_list).
This make this poll entry inconsistent, but we don't care. If you
share epoll fd which contains our sigfd with another process you
should blame yourself. signalfd is "really special". I simply do
not know how we can define the "right" semantics if it used with
epoll.

The main problem is, epoll calls signalfd_poll() once to establish
the connection with the wait queue, after that signalfd_poll(NULL)
returns the different/inconsistent results depending on who does
EPOLL_CTL_MOD/signalfd_read/etc. IOW: apart from sigmask, signalfd
has nothing to do with the file, it works with the current thread.

In short: this patch is the hack which tries to fix the symptoms.
It also assumes that nobody can take tasklist_lock under epoll
locks, this seems to be true.

Note:

	- we do not have wake_up_all_poll() but wake_up_poll()
	  is fine, poll/epoll doesn't use WQ_FLAG_EXCLUSIVE.

	- signalfd_cleanup() uses POLLHUP along with POLLFREE,
	  we need a couple of simple changes in eventpoll.c to
	  make sure it can't be "lost".

Reported-by: Maxime Bizon <mbizon@freebox.fr>
Cc: <stable@kernel.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 855a85f
History
File Mode Size
.gitignore -rw-r--r-- 6 bytes
3CCFEM556.cis.ihex -rw-r--r-- 469 bytes
3CXEM556.cis.ihex -rw-r--r-- 463 bytes
COMpad2.cis.ihex -rw-r--r-- 363 bytes
COMpad4.cis.ihex -rw-r--r-- 276 bytes
DP83903.cis.ihex -rw-r--r-- 499 bytes
LA-PCM.cis.ihex -rw-r--r-- 758 bytes
MT5634ZLX.cis.ihex -rw-r--r-- 363 bytes
NE2K.cis.ihex -rw-r--r-- 233 bytes
PCMLM28.cis.ihex -rw-r--r-- 662 bytes
PE-200.cis.ihex -rw-r--r-- 255 bytes
PE520.cis.ihex -rw-r--r-- 266 bytes
RS-COM-2P.cis.ihex -rw-r--r-- 307 bytes
SW_555_SER.cis.ihex -rw-r--r-- 412 bytes
SW_7xx_SER.cis.ihex -rw-r--r-- 460 bytes
SW_8xx_SER.cis.ihex -rw-r--r-- 444 bytes
tamarack.cis.ihex -rw-r--r-- 311 bytes

back to top