Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.
The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.
Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
checkdeclares.pl
#!/usr/bin/env perl
# SPDX-License-Identifier: GPL-2.0
#
# checkdeclares: find struct declared more than once
#
# Copyright 2021 Wan Jiabing<wanjiabing@vivo.com>
# Inspired by checkincludes.pl
#
# This script checks for duplicate struct declares.
# Note that this will not take into consideration macros so
# you should run this only if you know you do have real dups
# and do not have them under #ifdef's.
# You could also just review the results.
use strict;
sub usage {
print "Usage: checkdeclares.pl file1.h ...\n";
print "Warns of struct declaration duplicates\n";
exit 1;
}
if ($#ARGV < 0) {
usage();
}
my $dup_counter = 0;
foreach my $file (@ARGV) {
open(my $f, '<', $file)
or die "Cannot open $file: $!.\n";
my %declaredstructs = ();
while (<$f>) {
if (m/^\s*struct\s*(\w*);$/o) {
++$declaredstructs{$1};
}
}
close($f);
foreach my $structname (keys %declaredstructs) {
if ($declaredstructs{$structname} > 1) {
print "$file: struct $structname is declared more than once.\n";
++$dup_counter;
}
}
}
if ($dup_counter == 0) {
print "No duplicate struct declares found.\n";
}
Computing file changes ...
