Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.

The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.

Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
History
File Mode Size
bebob
dice
digi00x
fireface
fireworks
motu
oxfw
tascam
Kconfig -rw-r--r-- 6.0 KB
Makefile -rw-r--r-- 664 bytes
amdtp-am824.c -rw-r--r-- 11.8 KB
amdtp-am824.h -rw-r--r-- 1.6 KB
amdtp-stream-trace.h -rw-r--r-- 2.5 KB
amdtp-stream.c -rw-r--r-- 56.3 KB
amdtp-stream.h -rw-r--r-- 10.0 KB
cmp.c -rw-r--r-- 9.6 KB
cmp.h -rw-r--r-- 1.5 KB
fcp.c -rw-r--r-- 10.3 KB
fcp.h -rw-r--r-- 1.0 KB
isight.c -rw-r--r-- 17.5 KB
iso-resources.c -rw-r--r-- 6.5 KB
iso-resources.h -rw-r--r-- 1.2 KB
lib.c -rw-r--r-- 2.1 KB
lib.h -rw-r--r-- 683 bytes
packets-buffer.c -rw-r--r-- 2.1 KB
packets-buffer.h -rw-r--r-- 786 bytes

back to top