Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.

The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.

Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
History
File Mode Size
ext
Kconfig -rw-r--r-- 1.9 KB
Makefile -rw-r--r-- 749 bytes
array.c -rw-r--r-- 1.2 KB
hda_bus_type.c -rw-r--r-- 2.1 KB
hdac_bus.c -rw-r--r-- 7.4 KB
hdac_component.c -rw-r--r-- 9.7 KB
hdac_controller.c -rw-r--r-- 16.9 KB
hdac_device.c -rw-r--r-- 27.5 KB
hdac_i915.c -rw-r--r-- 4.4 KB
hdac_regmap.c -rw-r--r-- 15.2 KB
hdac_stream.c -rw-r--r-- 22.4 KB
hdac_sysfs.c -rw-r--r-- 11.2 KB
hdmi_chmap.c -rw-r--r-- 24.2 KB
intel-dsp-config.c -rw-r--r-- 15.0 KB
intel-nhlt.c -rw-r--r-- 8.5 KB
intel-sdw-acpi.c -rw-r--r-- 4.7 KB
local.h -rw-r--r-- 1.4 KB
trace.c -rw-r--r-- 107 bytes
trace.h -rw-r--r-- 2.3 KB

back to top