Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.

The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.

Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
History
File Mode Size
ad1816a
ad1848
cs423x
es1688
galaxy
gus
msnd
opti9xx
sb
wavefront
wss
Kconfig -rw-r--r-- 12.7 KB
Makefile -rw-r--r-- 892 bytes
adlib.c -rw-r--r-- 2.4 KB
als100.c -rw-r--r-- 9.0 KB
azt2320.c -rw-r--r-- 8.4 KB
cmi8328.c -rw-r--r-- 13.2 KB
cmi8330.c -rw-r--r-- 21.4 KB
es18xx.c -rw-r--r-- 66.5 KB
opl3sa2.c -rw-r--r-- 27.5 KB
sc6000.c -rw-r--r-- 16.7 KB
sscape.c -rw-r--r-- 30.9 KB

back to top