Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.
The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.
Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 160 bytes |
| pcxhr.c | -rw-r--r-- | 45.9 KB |
| pcxhr.h | -rw-r--r-- | 6.1 KB |
| pcxhr_core.c | -rw-r--r-- | 36.5 KB |
| pcxhr_core.h | -rw-r--r-- | 6.3 KB |
| pcxhr_hwdep.c | -rw-r--r-- | 10.6 KB |
| pcxhr_hwdep.h | -rw-r--r-- | 702 bytes |
| pcxhr_mix22.c | -rw-r--r-- | 27.2 KB |
| pcxhr_mix22.h | -rw-r--r-- | 1.6 KB |
| pcxhr_mixer.c | -rw-r--r-- | 35.1 KB |
| pcxhr_mixer.h | -rw-r--r-- | 352 bytes |
Computing file changes ...
