Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.

The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.

Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
History
File Mode Size
Kconfig -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 824 bytes
ac97c.c -rw-r--r-- 8.3 KB
db1000.c -rw-r--r-- 1.4 KB
db1200.c -rw-r--r-- 5.3 KB
dbdma2.c -rw-r--r-- 9.1 KB
dma.c -rw-r--r-- 8.6 KB
i2sc.c -rw-r--r-- 7.4 KB
psc-ac97.c -rw-r--r-- 12.5 KB
psc-i2s.c -rw-r--r-- 10.6 KB
psc.h -rw-r--r-- 1014 bytes

back to top