Revision d81916910f7498fe7a768697e0101d488f9fe665 authored by Yang Yingliang on 29 October 2022, 08:29:31 UTC, committed by Huacai Chen on 29 October 2022, 08:29:31 UTC
Currently the return value of 'sub_driver->init' is not checked. If
sparse_keymap_setup() called in the init function fails, 'generic_
inputdev' is freed, then it will lead a UAF when using it in generic_
acpi_laptop_init(). Fix it by checking the return value and setting
generic_inputdev to NULL after free, so as to avoid double free it.

The error code in generic_subdriver_init() is always negative, so the
return of generic_subdriver_init() can be simplified.

Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
1 parent fbe605a
History
File Mode Size
Kconfig -rw-r--r-- 3.7 KB
Makefile -rw-r--r-- 2.3 KB
aiu-acodec-ctrl.c -rw-r--r-- 6.4 KB
aiu-codec-ctrl.c -rw-r--r-- 4.6 KB
aiu-encoder-i2s.c -rw-r--r-- 8.5 KB
aiu-encoder-spdif.c -rw-r--r-- 5.7 KB
aiu-fifo-i2s.c -rw-r--r-- 4.5 KB
aiu-fifo-spdif.c -rw-r--r-- 4.8 KB
aiu-fifo.c -rw-r--r-- 5.4 KB
aiu-fifo.h -rw-r--r-- 1.5 KB
aiu.c -rw-r--r-- 9.1 KB
aiu.h -rw-r--r-- 2.2 KB
axg-card.c -rw-r--r-- 9.6 KB
axg-fifo.c -rw-r--r-- 9.9 KB
axg-fifo.h -rw-r--r-- 2.9 KB
axg-frddr.c -rw-r--r-- 13.5 KB
axg-pdm.c -rw-r--r-- 16.9 KB
axg-spdifin.c -rw-r--r-- 13.3 KB
axg-spdifout.c -rw-r--r-- 12.1 KB
axg-tdm-formatter.c -rw-r--r-- 9.7 KB
axg-tdm-formatter.h -rw-r--r-- 1.2 KB
axg-tdm-interface.c -rw-r--r-- 13.6 KB
axg-tdm.h -rw-r--r-- 1.9 KB
axg-tdmin.c -rw-r--r-- 7.5 KB
axg-tdmout.c -rw-r--r-- 9.9 KB
axg-toddr.c -rw-r--r-- 10.8 KB
g12a-toacodec.c -rw-r--r-- 10.5 KB
g12a-tohdmitx.c -rw-r--r-- 8.6 KB
gx-card.c -rw-r--r-- 3.6 KB
meson-card-utils.c -rw-r--r-- 8.1 KB
meson-card.h -rw-r--r-- 1.4 KB
meson-codec-glue.c -rw-r--r-- 3.7 KB
meson-codec-glue.h -rw-r--r-- 937 bytes
t9015.c -rw-r--r-- 8.7 KB

back to top