| d825776 | David Grogan | 06 July 2018, 23:21:12 UTC | [css-tables] Test for table width when cell is sized between its min/max Note this is a test only, the bug persists. Bug: 860084 Change-Id: I89d0cabda6018beaef2ec33ee8eb96b44a86e1c8 | 06 July 2018, 23:21:12 UTC |
| e7283ac | Luke Bjerring | 06 July 2018, 22:07:45 UTC | Auto-update the appmanifest IDL file (#11765) | 06 July 2018, 22:07:45 UTC |
| 4b54599 | Raphael Kubo da Costa | 06 July 2018, 21:01:40 UTC | sensors: Fix flakiness in the same-origin access check tests Commit f73dfaffe ("[sensors] Check that sensor frame and focused frame of same origin") added a few same-origin access check tests for sensors in generic-sensor-iframe-tests.sub.js. The test that checks that a sensor is not suspended when focus changes to another same-origin frame was flaky though, especially on the Mac bots. The actual fix is a one-liner: we were missing a call to Sensor.stop() so that the sensor in the top-level document wouldn't continue to push 'reading' events to our EventWatcher while we were waiting for the "is_sensor_suspended" command to be processed in iframe_sensor_handler.html. I'm also taking the opportunity to make a few other minor improvements: * Fix a few typos in the comments, and improve the comment explaining why we can end up sending more "reading" events than originally expected. * Create the sensor belonging to the top-level document with a higher frequency than the default 5Hz. This makes it a lot easier to reproduce the error we were having and will hopefully make the test consistently fail in the future instead of being flaky should another related bug occur. * Make the EventWatcher instances we create also watch for "error" events; if an error event ever gets sent, the test should now fail instead of just timing out waiting for a "reading" event that is never delivered. Bug: 855222, 857520 Change-Id: I945bb19d74e608089aa9aee82a4e74e05fae37ae Reviewed-on: https://chromium-review.googlesource.com/1127048 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573062} | 06 July 2018, 21:11:04 UTC |
| 323ad59 | Brandon Jones | 06 July 2018, 19:57:26 UTC | XRDevice should not extend EventTarget. The spec removed any events that were fired on the XRDevice a while ago, but our implementation forgot to clean this up. Bug: 859706 Change-Id: I086813a5a2cbf6ebbf7faf576b066fa3957ad5dc Reviewed-on: https://chromium-review.googlesource.com/1123645 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#573048} | 06 July 2018, 20:06:38 UTC |
| 3bfcfe4 | Luke Bjerring | 06 July 2018, 17:32:20 UTC | Add idl_test helper to idlharness.js (#11833) | 06 July 2018, 17:32:20 UTC |
| dbd7ce9 | Luke Bjerring | 06 July 2018, 17:23:46 UTC | Rename ServiceWorker to service-workers and update (#11821) | 06 July 2018, 17:23:46 UTC |
| 3c9fd9d | Jonathon Kereliuk | 06 July 2018, 15:57:56 UTC | Merge pull request #11832 from web-platform-tests/media-capabilities-update-idl Update the media-capabilities IDL file | 06 July 2018, 15:57:56 UTC |
| a7affd5 | Jonathon Kereliuk | 06 July 2018, 15:33:07 UTC | update test | 06 July 2018, 15:33:07 UTC |
| 8c77bf2 | Jonathon Kereliuk | 06 July 2018, 15:19:19 UTC | Update the page-visibility IDL file (#11830) | 06 July 2018, 15:19:19 UTC |
| f334bb5 | Bogdan Tara | 06 July 2018, 14:24:00 UTC | Backed out changeset 9c75cab2e322 (bug 733530) for breaking artifact builds gecko-commit: a9dc5dc8e2b8513686ad1b1f28c9e4da6de62226 gecko-integration-branch: central | 06 July 2018, 14:31:20 UTC |
| 9f00a60 | Luke Bjerring | 06 July 2018, 10:43:37 UTC | Update the IndexedDB IDL file (#11820) | 06 July 2018, 10:43:37 UTC |
| efea733 | Morten Stenshorne | 06 July 2018, 10:08:21 UTC | Correctly pick the block-end margin when calculating overflow. We need to use the writing mode of the containing block to do this, not that of the child, which is completely irrelevant. Change-Id: Ia5907d9ce60d00ad453f48fb72193e2eab1aaa3e Reviewed-on: https://chromium-review.googlesource.com/1127047 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#572931} | 06 July 2018, 10:16:06 UTC |
| c9c1a7d | Wanming Lin | 06 July 2018, 07:06:00 UTC | [sensors] Check that sensor frame and focused frame of same origin (#11803) #11426 introduced new tests for mitigation stragegy defined in [1] for partial concrete sensors. This PR add the same tests for remain concrete sensors: Ambient Light Sensor, Geolocation Sensor, and Proximity. [1] https://www.w3.org/TR/generic-sensor/#focused-area | 06 July 2018, 07:06:00 UTC |
| e6ac489 | Yoav Weiss | 06 July 2018, 06:13:20 UTC | Make preload play nice with CSP strict-dynamic Dynamically loaded preloaded scripts were not loaded when a strict-dynamic CSP directive was used. This was because the state regarding whether the element was parser created or not was not properly propoagated to the CSP checks. This CL fixes that and adds tests that make sure that such scripts can be preloaded (and that markup based preloaded scripts with no nonce cannot). Bug: 752922 Change-Id: Ib4f3bce8583ccc9770c261d76167243033e5a112 Reviewed-on: https://chromium-review.googlesource.com/1125064 Reviewed-by: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#572908} | 06 July 2018, 06:21:09 UTC |
| 5869dcc | Luke Bjerring | 06 July 2018, 02:07:00 UTC | Update the longtask-timing IDL file (#11815) | 06 July 2018, 02:07:00 UTC |
| 597d738 | Eric Willigers | 06 July 2018, 00:28:53 UTC | Merge pull request #11585 from ewilligers/transform-property-renders SVG: transform properties affect rendering | 06 July 2018, 00:28:53 UTC |
| 2b9ac24 | Eric Willigers | 06 July 2018, 00:28:34 UTC | Merge pull request #11583 from ewilligers/z-index-test SVG: Test that z-index controls rendering order | 06 July 2018, 00:28:34 UTC |
| 0ffa5aa | Sandra Sun | 06 July 2018, 00:07:22 UTC | Change parsing order for scroll-snap-align to block/inline. As in the newest spec[1], the parsing order for scroll-snap-align is changed to block/inline. [1] https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align Bug: 854379 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70d2e9d526ffa0564e260faacdb5f79857a69324 Reviewed-on: https://chromium-review.googlesource.com/1115701 Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572869} | 06 July 2018, 00:15:57 UTC |
| dfca519 | Dave Tapuska | 05 July 2018, 20:27:33 UTC | Add an API to query whether the window has seen a user gesture. Add a variable on the navigator object to query whether the frame has seen a user activation ever. The postMessage part of the proposal will be done in a separate patch, this change is limited to just adding the object definition and exposing it on navigator. https://github.com/dtapuska/useractivation https://github.com/whatwg/html/issues/1983 BUG=846858 Change-Id: I6ca4c80f4096bfae9ca13b175b46df6b4486a6dd Reviewed-on: https://chromium-review.googlesource.com/1076979 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#572847} | 05 July 2018, 20:36:46 UTC |
| a204983 | Raphael Kubo da Costa | 05 July 2018, 16:39:56 UTC | webrtc: Fix bogus merge from #11789 PR #11789 upstreamed some Mozilla changes that were originally committed downstream before #11177 landed in this repository. The resulting pull request had some unresolved conflicts that did not prevent it from being merged, resulting in a bogus file. | 05 July 2018, 19:10:57 UTC |
| a199bb3 | Jonathon Kereliuk | 05 July 2018, 18:37:58 UTC | Update the gamepad IDL file (#11814) | 05 July 2018, 18:37:58 UTC |
| 8e62dee | Jonathon Kereliuk | 05 July 2018, 18:36:56 UTC | Update the audio-output IDL file (#11812) | 05 July 2018, 18:36:56 UTC |
| dfe2b1c | jimevans | 05 July 2018, 16:17:30 UTC | webdriver: correct expected exception type for delete session test (#11809) The SessionNotCreatedException should be thrown if an attempt to create a session fails. If a user tries to access a session that existed, but has already been deleted, the correct exception is InvalidSessionIdException. | 05 July 2018, 16:17:30 UTC |
| 273e3f0 | moz-wptsync-bot | 28 March 2018, 19:30:44 UTC | Correct readyState in WebSocket when worker goes away, bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1446366 gecko-commit: fdd61cf07d83133d4a2a719586d1af5bda24c6be gecko-integration-branch: central gecko-reviewers: smaug | 05 July 2018, 13:17:40 UTC |
| 234137e | Andreas Tolfsen | 04 July 2018, 12:30:14 UTC | Turn some WebDriver client assertions into errors. In Python, assert only raises AssertException when __debug__ is true which it isn't for optimised code. There are some cases in the WebDriver client where we genuinely want to stop the user from performing certain actions, and this patch turns those into raised exceptions. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1408509 gecko-commit: f97b37943daf0984915f756bad693ebe08c534fb gecko-integration-branch: central gecko-reviewers: whimboo | 05 July 2018, 12:22:43 UTC |
| e456408 | Andreas Tolfsen | 04 July 2018, 12:30:08 UTC | Add initial support for web frame and web window to WPT WebDriver client. This adds marshalling support for web frames and web windows to the WPT WebDriver client. It can now receive and send complex objects representing DOM frames and WindowProxies. The support for these new objects is preliminary as they are not used in practice yet. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1408509 gecko-commit: b9f5d65674842ca120cf63bfc538f3180006ba9b gecko-integration-branch: central gecko-reviewers: whimboo | 05 July 2018, 12:22:43 UTC |
| 4ee4180 | Andreas Tolfsen | 05 July 2018, 10:51:33 UTC | Log parent test result stacks. Parent tests may also have stacktraces and this patch adds a new, optional keyword argument to the Result class for logging the stack to the test_end log entry. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1465527 gecko-commit: 2492931ce122e95206ce2653f8adf107c99019f5 gecko-integration-branch: central gecko-reviewers: jgraham | 05 July 2018, 12:22:26 UTC |
| b5ab999 | James Graham | 05 July 2018, 11:47:38 UTC | Readd new_disabled flag on expectation manifest root This was unintentionally removed in Bug 1265584. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1466124 gecko-commit: 1fbf7e0d341d86ec4b188769ae074f30bbc8c0ac gecko-integration-branch: central gecko-reviewers: maja_zf | 05 July 2018, 12:22:12 UTC |
| 6562ed0 | Morten Stenshorne | 05 July 2018, 10:39:12 UTC | [LayoutNG] Support anonymous table cells natively. Use LayoutObjectFactory when creating anonymous table cells, just like we already do for non-anonymous cells. We used to create legacy LayoutTableCell objects for anonymous cells, but allowed children to be NG. This was bad, since we should only switch engines at formatting context boundaries. One NG change was necessary here: Only anonymous *blocks* should inherit % resolution size. Anonymous table cells should NOT. This prevents fast/table/percent-height-inside-anonymous-cell.html from regressing. This made one existing test pass. Also added a new one. Two tests not related to tables regressed. Separate bugs reported. Some rebaselining was also necessary, since NG handles text runs and whitespace slightly differently. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibbb77073f1fbe1841ebf102c8bce440046f73319 Reviewed-on: https://chromium-review.googlesource.com/1122218 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#572753} | 05 July 2018, 10:46:56 UTC |
| 6d3fda5 | Jan-Ivar Bruaroey | 04 July 2018, 13:49:09 UTC | s/assert_session_desc_(not_)equals/assert_session_desc_(not_)similar bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1461712 gecko-commit: 14fb6876d99650f5fbcca42c000703fc198abe59 gecko-integration-branch: central gecko-reviewers: bwc | 05 July 2018, 09:16:36 UTC |
| ac8b495 | Anders Hartvoll Ruud | 05 July 2018, 08:12:47 UTC | [css-properties-values-api] Require PropertyDescriptor.inherits. As of a recent spec change, the 'inherits' field must now be set. See https://drafts.css-houdini.org/css-properties-values-api-1/#registering-custom-properties. This patch changes all calls to CSS.registerProperty (that are missing 'inherits') such that 'inherits' is explicitly set to 'false', which was the old default. In wpt/css/css-properties-values-api/register-property.html, I have added a new test to very that we throw an exception if it's omitted. Note that CSS.registerProperty API is an unshipped feature behind the CSSVariables2 flag. R=mstensho@chromium.org Bug: 860289 Change-Id: I14aa02d40c69e0ff6d1160160a8f772cb5159092 Reviewed-on: https://chromium-review.googlesource.com/1126303 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#572731} | 05 July 2018, 08:21:56 UTC |
| fc77ed0 | Eric Willigers | 05 July 2018, 06:10:18 UTC | Merge pull request #10296 from dstorey/types-svg-to-dom-changes Test removed interfaces and SVG* -> DOM* in Types chapter | 05 July 2018, 06:10:18 UTC |
| 889e4a1 | Alice Boxhall | 05 July 2018, 05:50:38 UTC | Match :focus-visible after programmatic focus depending on previous user interaction Bug: 817199 Change-Id: I930a0711153039b6fd7712371c346771c2a749a9 Reviewed-on: https://chromium-review.googlesource.com/1101310 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#572712} | 05 July 2018, 06:00:24 UTC |
| f2fdea2 | Tarun Bansal | 05 July 2018, 05:20:21 UTC | WPT tests for http-equiv Accept-CH-Lifetime WPT tests are added for: (i) When ACL http-equiv header is sent by a same-origin iframe. (ii) When ACL http-equiv header is sent by a cross-origin iframe. (iii) When ACL http-equiv header is sent by a subresource. (iv) When ACL http-equiv header is sent on the main frame. Change-Id: Ie4adce0c1b5983a66ce3dce7bb6b77e30f63c03a Bug: 852484 Reviewed-on: https://chromium-review.googlesource.com/1125212 Reviewed-by: Yoav Weiss <yoav@yoav.ws> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572706} | 05 July 2018, 05:39:40 UTC |
| 9d17d36 | Eric Willigers | 05 July 2018, 05:19:43 UTC | Merge pull request #11801 from ewilligers/currentColor [css-backgrounds] don't serialize as currentColor | 05 July 2018, 05:19:43 UTC |
| e9f7e15 | Eric Willigers | 05 July 2018, 04:34:41 UTC | [css-backgrounds] don't serialize as currentColor CSS keywords serialize as lower case. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/16905526/ | 05 July 2018, 05:01:40 UTC |
| 30c6839 | Emilio Cobos Álvarez | 05 July 2018, 03:31:26 UTC | Merge pull request #11800 from birtles/update-web-animations-reviewers [web-animations] Update reviewers for Web Animations tests | 05 July 2018, 03:31:26 UTC |
| 250d864 | Yutaka Hirano | 05 July 2018, 01:55:56 UTC | Unflake wpt/fetch/security/redirect-to-url-with-credentials.https.html The test is flaky because of step_timeout. This CL removes that, and marks the test as consistent TIMEOUT. Bug: 846497, 626703 Change-Id: Iaa8b0e275d1d4fc9db6cb77db5399d06744fd60a Reviewed-on: https://chromium-review.googlesource.com/1125548 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572688} | 05 July 2018, 02:05:31 UTC |
| adaa7b6 | Cameron McCormack | 05 July 2018, 01:59:43 UTC | Test that will-change:will-change has no effect. (#11798) * Test that will-change:will-change has no effect. * Add test owners. | 05 July 2018, 01:59:43 UTC |
| 31a13ed | Brian Birtles | 05 July 2018, 01:57:05 UTC | [web-animations] Update reviewers for Web Animations tests | 05 July 2018, 01:57:05 UTC |
| 39f866d | Alice Boxhall | 05 July 2018, 00:29:04 UTC | Make focus-visible tests easier to eyeball Bug: 817199 Change-Id: Iea196f7b7679c2edee47e5d17b0cab39d28c2aeb Reviewed-on: https://chromium-review.googlesource.com/1125552 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#572681} | 05 July 2018, 00:38:16 UTC |
| 7997e96 | Luke Bjerring | 04 July 2018, 21:30:13 UTC | Update the WebCryptoAPI IDL file (#11793) | 04 July 2018, 21:30:13 UTC |
| cf4bcf1 | James Graham | 04 July 2018, 16:38:04 UTC | Fix flake8 failures | 04 July 2018, 21:03:17 UTC |
| ac0f200 | James Graham | 25 May 2018, 16:55:10 UTC | Add a test for wpttest metadata bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: b021a8615326a99919fe62b493874ac9d49441da gecko-integration-branch: mozilla-inbound gecko-reviewers: maja_zf | 04 July 2018, 21:03:17 UTC |
| 642bfb6 | James Graham | 25 May 2018, 16:52:52 UTC | Output asserts to wptreport.json In the future we want to update metadata using the wptreport.json data, since that's much much smaller and easier to parse. In addition, this is required to determine if a test fully passed, so it makes sense to store it here. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: b7716dedbf5a24e0e9a940a907225f7b3dd7d35c gecko-integration-branch: mozilla-inbound gecko-reviewers: maja_zf | 04 July 2018, 21:03:17 UTC |
| af25577 | James Graham | 25 May 2018, 16:52:49 UTC | Use ujson where possible for faster metadata update Profiling shows that switching to this library means we no longer spend most of the update time parsing json (vs 80% or so before), making other optimisations worthwhile. This is never used in automation (except wptsync) so availability of the library in the internal pypi isn't a problem. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: 605324b9d70e822a9d25e1c6ff7ca2bcbff6085c gecko-integration-branch: mozilla-inbound gecko-reviewers: maja_zf | 04 July 2018, 21:03:17 UTC |
| 67010d9 | James Graham | 25 May 2018, 16:52:46 UTC | Support updating asserts with wpt-update With support for asserts, it's also necessary to be able to update the expected number of asserts automatically using wpt-update. Unfortunately asserts don't work quite like test statuses, so this involves a reasonable amount of refactoring. For asserts the desired behaviour is that the max asserts is either one plus the highest recorded number of asserts, or the current value, whichever is higher, and for the minimm asserts, it's the minumum of the current value and one lower than the lowest recorded value (clamped at zero). Instead of creating per-platform expectations, the code only updates the defaults (or any existing conditional that happens to match). It's not clear that we have enough information to meaningfully make per-platform expectations, and we want to reduce the risk of intermittents. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: cc9b28394533a30a6ae33def5ce1117882653134 gecko-integration-branch: mozilla-inbound gecko-reviewers: maja_zf | 04 July 2018, 21:03:17 UTC |
| 29fc712 | James Graham | 25 May 2018, 16:52:43 UTC | Reverse the order of metadata iteration wptrunner previously iterated over properties from least significant to most significant. However this was broken since it caused per-directory properties to override per-test properties, which wasn't expected. Therefore we reverse the order of iteration from most significant to least. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: cc1d47bf0aa7efe3e770316c9ea5d895beafcaba gecko-integration-branch: mozilla-inbound gecko-reviewers: maja_zf | 04 July 2018, 21:03:17 UTC |
| e462113 | James Graham | 25 May 2018, 16:52:40 UTC | Add support for recording asserts in wptrunner Gecko has an API for producing a non-fatal "assert". For quality control, it should be possible to annotate the range of possible numbers of these asserts produced during a test execution, and fail if the actual number of asserts falls outside this range. This patch adds assert checking by default in debug builds. It adds two metadata properties; max-asserts and min-asserts for specifying the range of possible asserts produced in a test. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: bc43ae3ccc9f203268a2b495b99515c617306c88 gecko-integration-branch: mozilla-inbound gecko-reviewers: ato, maja_zf | 04 July 2018, 21:03:17 UTC |
| d675750 | James Graham | 25 May 2018, 16:52:36 UTC | Make base_executor_kwargs arguments match executor_kwargs bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: b99661f1fcc56bca0176bd813c166525a4ebf2e4 gecko-integration-branch: mozilla-inbound gecko-reviewers: ato | 04 July 2018, 21:03:17 UTC |
| 7204b31 | James Graham | 25 May 2018, 16:51:05 UTC | Move wptrunner marionette usage onto a single thread Running marionette on a background thread is problematic in the case that a test times out. In this case the background thread is not terminated. If we then call into marionette again on the main thread we may race with something that happens on the runner thread. The marionette client isn't threadsafe, so this leads to buggy behaviour. The simplest fx for the problem is just to move all the marionette calls onto the main thread and instead of waiting on the main thread, spin up a thread with a timer. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584 gecko-commit: 9b8539a9a2a6c20220cdcb07e19b7bf3a91c7436 gecko-integration-branch: mozilla-inbound gecko-reviewers: ato | 04 July 2018, 21:03:17 UTC |
| 11bf2ce | Dominic Farolino | 04 July 2018, 16:39:38 UTC | Console: update countReset() link | 04 July 2018, 16:39:38 UTC |
| 8dba144 | Oriol Brufau | 04 July 2018, 15:42:41 UTC | [css-logical] Implement flow-relative margin, padding and border shorthand properties They are implemented behind the CSSLogical runtime flag. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ Spec: https://drafts.csswg.org/css-logical/#box BUG=850004 TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html TEST=external/wpt/css/css-logical/logical-box-border-color.html TEST=external/wpt/css/css-logical/logical-box-border-style.html TEST=external/wpt/css/css-logical/logical-box-border-width.html TEST=external/wpt/css/css-logical/logical-box-margin.html TEST=external/wpt/css/css-logical/logical-box-padding.html The tests still have some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ibe3d7f39e1ce17de465aa635388b3f8510ed82a3 Reviewed-on: https://chromium-review.googlesource.com/1122872 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by: Anders Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#572576} | 04 July 2018, 16:00:41 UTC |
| 5488054 | Jonathan Kingston | 04 July 2018, 13:50:21 UTC | Add support for Element.toggleAttribute. Differential Revision: https://phabricator.services.mozilla.com/D1710 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1469592 gecko-commit: 72cacb766a6f9f5401392384e7c681e35e318cd3 gecko-integration-branch: central gecko-reviewers: bzbarsky, smaug | 04 July 2018, 15:00:28 UTC |
| d5c9016 | Chris AtLee | 04 July 2018, 13:47:44 UTC | Use .tar.gz for test archives Differential Revision: https://phabricator.services.mozilla.com/D1743 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=733530 gecko-commit: 9c75cab2e32295ee037f0a8f1af2f61ac86f8b8c gecko-integration-branch: central gecko-reviewers: gps | 04 July 2018, 14:43:22 UTC |
| 7fb7c34 | Hiroyuki Ikezoe | 03 July 2018, 05:11:00 UTC | Dispatch web animation events at the same time when CSS animations/transitions events are dispatched. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1354501 gecko-commit: 8beb2cbc6b2538a51f5bbc8f91fee17091fa93ba gecko-integration-branch: autoland gecko-reviewers: birtles | 04 July 2018, 13:31:18 UTC |
| 56381a4 | Hiroyuki Ikezoe | 03 July 2018, 05:10:57 UTC | Add test cases that animation event is fired for the animation on an orphaned element. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1354501 gecko-commit: 5aa0a52055ce4e543c38fa4e2dad8d1cd05eeef7 gecko-integration-branch: autoland gecko-reviewers: birtles | 04 July 2018, 13:31:18 UTC |
| e43d085 | Hiroyuki Ikezoe | 03 July 2018, 05:10:53 UTC | Rewrite promise_test in onfinish.html with async/await. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1354501 gecko-commit: 6979ef3af92194da8085debfd5c3bab6461f92f4 gecko-integration-branch: autoland gecko-reviewers: birtles | 04 July 2018, 13:31:18 UTC |
| 3634f42 | Ms2ger | 04 July 2018, 11:51:57 UTC | Add a test for the bounds-checking in createImageBitmap. | 04 July 2018, 12:08:07 UTC |
| 6e559a6 | Henrik Skupin | 12 June 2018, 20:51:04 UTC | [geckodriver] Add support for all unhandledPromptBehavior options. geckodriver currently only supports "accept" and "dismiss". But to be compliant with the WebDriver specification all allowed options have to be supported. Given that Marionette uses the hard-coded dismiss and notify behavior for unexpected prompts, inappropriately marked as failed tests for accept/dismiss + notify for execute_(async_)script will pass now. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1468185 gecko-commit: 0cdcd92a013fedb1f6fc80e4194a321151620a86 gecko-integration-branch: autoland gecko-reviewers: ato | 04 July 2018, 09:08:29 UTC |
| bfba9da | Adam Rice | 04 July 2018, 06:36:23 UTC | Don't crash when aborting a fetch in a destroyed context Once the context in which a fetch is executing has been destroyed the fetch cannot be aborted. blink::BodyStreamBuffer was attempting to abort the fetch anyway, leading to a crash. Check that the context hasn't been destroyed before attempting the abort. BUG=860063 Change-Id: I593dcbfe2f2dacd7be9df456399cd0328da7af39 Reviewed-on: https://chromium-review.googlesource.com/1125543 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#572493} | 04 July 2018, 06:44:15 UTC |
| eff6365 | Dominic Farolino | 04 July 2018, 04:16:08 UTC | Add console timing manual tests | 04 July 2018, 04:16:08 UTC |
| 025f01b | Dominic Farolino | 04 July 2018, 04:08:34 UTC | Address domenic's feedback | 04 July 2018, 04:08:34 UTC |
| cffbd07 | Xiaocheng Hu | 03 July 2018, 01:56:28 UTC | [LayoutNG] Fix hit test clipping by fragmented border with round corner Current NG hit test code decides whether a hit test location is clipped by rounded border by adding border radius to all four corners and then compare with the hit test location. This is wrong if the box is fragmented, where it may have only two or zero rounded corners. This patch changes HitTestClippedOutByBorder() to take the above into consideration. By utilizing |border_edges_|, it can generate the corrected rounded border to be hit tested. Test: This patch slightly modifies WPT hit-test-inline-fragmentation-with-border-radius.html as a workaround of some rounding issue, which is out of the scope of this patch. Bug: 855279, 859233 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e3193f9fc2d5e52ff53d6cb2fcc2a0ae2b3aa43 Reviewed-on: https://chromium-review.googlesource.com/1123265 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#572079} | 04 July 2018, 01:12:33 UTC |
| bf35451 | Victor Costan | 04 July 2018, 00:18:37 UTC | Async Cookies: Expose oncookiechange on ServiceWorkerGlobalScope. cookiechange events have been dispatched to ServiceWorkerGlobalScope since https://crrev.com/c/979334 landed, and can be observed using addEventListener, as shown by the WPT test at cookie-store/serviceworker_cookieStore_subscriptions_basic.tentative.https.html This CL adds the oncookiechange attribute to ServiceWorkerGlobalScope, allowing the event to be handled by a DOM0-style event handler. Bug: 729800 Change-Id: Ic27979d94934abf833c116787cdad5243422324b Reviewed-on: https://chromium-review.googlesource.com/1123766 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#572400} | 04 July 2018, 00:35:47 UTC |
| 8f6ed28 | Marijn Kruisselbrink | 03 July 2018, 21:45:48 UTC | Rewrite BlobBytesConsumer to not rely on blob URLs. The existing implementation depended on the non-mojo blob URL code path, and so would break soon after mojo blob URLs ship when the old code gets deleted. So rewrite the implementation to read blobs more directly rather than going through a blob URL. Bug: 859109 Change-Id: Ia6f2432e48ac5304ea8f5598d293e31c2c1e1905 Reviewed-on: https://chromium-review.googlesource.com/1120679 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572363} | 03 July 2018, 21:56:31 UTC |
| 59d4a41 | Tarun Bansal | 03 July 2018, 17:53:33 UTC | Add more WPT tests for client hints The WPT tests check the Accept-CH-Lifetime (ACL) header functionality. Add tests for: (i) When ACL header is sent by a same-origin iframe. (ii) When ACL header is sent by a cross-origin iframe. (iii) When ACL header is sent by a subresource. (iv) When ACL header is sent on the main frame. Also, change the ACL persistence time-duration from 20 seconds to 5 seconds to make it easier to run multiple tests quickly and without waiting too long. Change-Id: I31047598bbb1e7c64cadf3e6845bf850c29aca8b Bug: 856700 Reviewed-on: https://chromium-review.googlesource.com/1119848 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#572273} | 03 July 2018, 18:12:31 UTC |
| 0294ce4 | Luke Bjerring | 03 July 2018, 16:46:14 UTC | Update the picture-in-picture IDL file (#9811) | 03 July 2018, 16:46:14 UTC |
| 5c8e16d | Joshua Bell | 03 July 2018, 15:49:43 UTC | Deflake cache-storage/script-tests/cache-storage-match.js WPT The test assumed no cache named 'foo' existed, but another test cache-keys-attributes-for-service-worker creates a cache by that name, so the test would flakily fail in some runs depending on the ordering of the tests. Make the test defensive by deleting such a cache before proceeding. Bug: 840850 Change-Id: Ia349706c9a32af309cfadf9a63ba5cffea11998d Reviewed-on: https://chromium-review.googlesource.com/1119104 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#572232} | 03 July 2018, 15:58:50 UTC |
| 5c05fc0 | Luke Bjerring | 03 July 2018, 13:12:37 UTC | Clean up the css-font-loading IDL test (#9771) | 03 July 2018, 13:12:37 UTC |
| 5d0c4eb | Yoshifumi Inoue | 03 July 2018, 10:45:02 UTC | Add a new test case for Element#innerText in Web Platform Test This patch introduces a new test case for Element#innerText to verify that result has a collapsed whitespace due by soft line break. In the test case, the layout object associated to space character between <span> elements, doesn't have neither InlineTextBox and NGPhysicalTextFragment. Thus, Element#innerText implementation should detect this and handle it. Bug: 651764 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia25d06a2a3fe993f2e966188b81f9e9c1d0fe982 Reviewed-on: https://chromium-review.googlesource.com/1124264 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572164} | 03 July 2018, 10:53:53 UTC |
| a04dd99 | Zhuoyu Qian | 03 July 2018, 09:01:00 UTC | Background-size should not accept negative values. Follow the spec[1], negative values are not allowed. We should reject the negative values of background-size during parsing. [1]: https://drafts.csswg.org/css-backgrounds/#background-size Bug: 825549 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ib260bafa421249aed471ff801c8b49a4b97aba1e Reviewed-on: https://chromium-review.googlesource.com/989529 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#572149} | 03 July 2018, 09:10:44 UTC |
| 0630b46 | Anders Hartvoll Ruud | 03 July 2018, 08:43:26 UTC | [css-properties-values-api]: Drop .tentative from URL resolution test. R=eae@chromium.org Bug: 851490 Change-Id: I0090986f81763d3c84f1245d5340286f9a3a1dff Reviewed-on: https://chromium-review.googlesource.com/1121463 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#572145} | 03 July 2018, 08:51:58 UTC |
| 2937bc4 | Tarun Bansal | 02 July 2018, 20:45:33 UTC | WPT tests for http-equiv accept-ch header This CL adds WPT tests for http-equiv accept-ch header: (1) The header is not honored on HTTP pages (2) Malformed header is not honored (3) When the header is present, client hints are attached only on the same-origin subresources, and not on cross-origin subresources in the same navigation. (4) When the header is present, client hints are attached only on the same origin subresources, and not on subresources in a new navigation. Bug: 856700 Change-Id: I3f82df8cd02816b06542256062eb291577ebe8b7 Reviewed-on: https://chromium-review.googlesource.com/1120953 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#571986} | 02 July 2018, 20:55:39 UTC |
| 8213774 | Xiaocheng Hu | 02 July 2018, 19:37:32 UTC | Add layout test for hit testing fragmented inline with rounded border Bug: 859233 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifefe2b4f1b25627c53a467c27937271de9efe450 Reviewed-on: https://chromium-review.googlesource.com/1121584 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571963} | 02 July 2018, 19:47:53 UTC |
| f1587a3 | Ms2ger | 02 July 2018, 13:37:07 UTC | Don't use six.string_types in wptserve. In python 2, it's defined as basestring, so it matches both str and unicode, but in python 3, it matches only str (and not bytes). This does not seem like a useful approach as we add python 3 support, and the now-passing tests support that view. | 02 July 2018, 19:07:29 UTC |
| 8bb14e8 | Eric Willigers | 02 July 2018, 18:02:15 UTC | Merge pull request #11636 from ewilligers/css-color-parsing [css-color] Parsing color and opacity | 02 July 2018, 18:02:15 UTC |
| 05cbe14 | Henrik Skupin | 09 May 2018, 19:37:52 UTC | marionette] Firefox has to automatically dismiss "beforeunload" prompts. As requested by the WebDriver specification any beforeunload prompt has to be automatically dismissed for the close and navigate commands. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1434872 gecko-commit: 2ec04569f9bdc1fe3dc838e4a544a41120f73225 gecko-integration-branch: autoland gecko-reviewers: ato | 02 July 2018, 17:57:31 UTC |
| 2f5ea35 | Henrik Skupin | 09 May 2018, 19:37:49 UTC | wdclient] Store original capabilities as used for the driver. To allow Session.start() to be called multiple times the originally requested capabilities for the driver have to be stored. Currently those are overwritten with the ones as returned by the driver. That means that custom entries which are getting extracted by the driver (eg preferences) to setup the browser profile, are lost and tests themselves cannot internally end a session and start it again. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1434872 gecko-commit: 14c67a3e28d5f400b85d47763b13b949a8b04502 gecko-integration-branch: autoland gecko-reviewers: ato | 02 July 2018, 17:57:31 UTC |
| 2e9febe | Henrik Skupin | 09 May 2018, 19:37:46 UTC | wdclient] Handle SessionNotCreatedException in session.send_command(). In case the driver already deleted the session (eg last window closed) make sure to also invalidate the internal session id. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1434872 gecko-commit: f22e8468bc8503d101ce54b94d31ddde3c0be098 gecko-integration-branch: autoland gecko-reviewers: ato | 02 July 2018, 17:57:31 UTC |
| 166253b | Jon Coppeard | 23 May 2018, 09:18:38 UTC | Implement import.meta in the browser bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1427610 gecko-commit: 9a5e8a990f0abb3be62858082bf82b18a9925949 gecko-integration-branch: mozilla-inbound gecko-reviewers: bkelly | 02 July 2018, 17:55:42 UTC |
| ce035e9 | Maja Frydrychowicz | 15 June 2018, 18:31:42 UTC | Ctrl+click should synthesize a contextmenu event Except on Windows. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1421323 gecko-commit: d62ce3e3ee8ad7ed946c6b5bf6d7a793dcbecfe0 gecko-integration-branch: autoland gecko-reviewers: ato | 02 July 2018, 17:54:08 UTC |
| c88d124 | pyup-bot | 14 June 2018, 15:52:28 UTC | Update requests from 2.18.4 to 2.19.1 | 02 July 2018, 17:28:45 UTC |
| 1b5a507 | pyup-bot | 14 June 2018, 15:52:27 UTC | Update requests from 2.18.4 to 2.19.1 | 02 July 2018, 17:28:45 UTC |
| 786a123 | Emilio Cobos Álvarez | 29 June 2018, 04:29:06 UTC | Make :host() and ::slotted() account for the inner selector's specificity. As resolved in https://github.com/w3c/csswg-drafts/issues/1915. Differential Revision: https://phabricator.services.mozilla.com/D1849 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1454165 gecko-commit: ca14c36e4280927a10e43e95b8f459e767fc8178 gecko-integration-branch: autoland gecko-reviewers: xidorn | 02 July 2018, 14:59:57 UTC |
| 31a51c7 | Mike Pennisi | 29 June 2018, 15:27:58 UTC | [fullscreen] Do not return value from cleanup fns Today, the return value of functions provided to the global `add_cleanup` function has no effect on the behavior of the test runner. An upcoming feature addition to testharness.js will cause the return value to influence test results [1]. Despite this, some existing tests have already been authored to return a value: the result of `document.exitFullScreen`. Although this is expected to be a Promise in conforming implementations, some browsers do not yet implement this functionality. To allow the new test harness feature to land without introducing harness errors, refactor existing tests to omit a return value. Additionally, use `Promise.prototype.catch` to avoid race conditions resulting from unhandled Promise rejections (which trigger a harness error in testharness.js today). [1] https://github.com/web-platform-tests/wpt/issues/6075 | 02 July 2018, 14:31:05 UTC |
| 21369c1 | Mike Pennisi | 29 June 2018, 22:56:58 UTC | [html] Do not return value from cleanup fns Today, the return value of functions provided to the `Test#add_cleanup` function has no effect on the behavior of the test runner. Despite this, some existing tests have already been authored to return a value: the result of `Element#removeChild`. An upcoming feature addition to testharness.js will cause the return value to influence test results [1]. To allow the new test harness feature to land without introducing harness errors, refactor existing tests to omit a return value. [1] https://github.com/web-platform-tests/wpt/issues/6075 | 02 July 2018, 14:25:50 UTC |
| 86455a6 | Mike Pennisi | 29 June 2018, 23:46:14 UTC | [fetch] Do not return value from cleanup fns Today, the return value of functions provided to the `Test#add_cleanup` function has no effect on the behavior of the test runner. Despite this, some existing tests have already been authored to return the `null` value. An upcoming feature addition to testharness.js will cause the return value to influence test results [1]. To allow the new test harness feature to land without introducing harness errors, refactor existing tests to omit a return value. [1] https://github.com/web-platform-tests/wpt/issues/6075 | 02 July 2018, 14:25:31 UTC |
| 27406c9 | Kagami Sascha Rosylight | 30 June 2018, 15:49:22 UTC | Fix Python 3 errors for wpt lint/serve (#11706) | 30 June 2018, 15:49:22 UTC |
| 1bcca71 | Eric Willigers | 30 June 2018, 12:32:10 UTC | Merge pull request #11728 from ewilligers/css-cascade-parsing [css-cascade] parsing tests for 'all' property | 30 June 2018, 12:32:10 UTC |
| 6e186ec | Florian Rivoal | 30 June 2018, 10:14:07 UTC | Merge pull request #11702 from frivoal/css-text-2465 [css-text] Update break-spaces text to white-space property | 30 June 2018, 10:14:07 UTC |
| f83787e | Emilio Cobos Álvarez | 30 June 2018, 04:21:28 UTC | Implement content: url(..) for elements. Dynamic changes are handled correctly because content property changes already cause a reframe. This implements the same bits as Blink / WebKit do (single content item which is an image, otherwise gets ignored), except for the edge cases where you use this on an image. In order to handle the edge cases right, we completely isolate the nsImageLoadingContent usage based on `mKind`. Blink's and WebKit's behavior there makes no sense and it's erratic, what I implemented is consistent (we apply to images as long as they don't generate a box, and we don't look at alt text or broken icons), though I'll update to whatever the WG decides in https://github.com/w3c/csswg-drafts/issues/2831 / https://github.com/w3c/csswg-drafts/issues/2832. I don't think it matters in terms of web compat in any case. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=215083 gecko-commit: 2ca43c308ce1c5063fd1f2be7984dc781ab70c0c gecko-integration-branch: mozilla-inbound gecko-reviewers: tnikkel, dholbert | 30 June 2018, 10:12:20 UTC |
| e2dcb12 | Kagami Sascha Rosylight | 30 June 2018, 03:07:46 UTC | fix(resources/testdriver): correct syntax (#11743) | 30 June 2018, 03:07:46 UTC |
| 0e96b1f | Victor Costan | 30 June 2018, 01:56:02 UTC | Async Cookies: Update Cookie Store API to match spec. This CL changes the signatures of cookieStore.{get,getAll,set,delete} and introduces the CookieStoreDeleteOptions and CookieStoreSetExtraOptions dictionary. The CL also updates the CookieListItem dictionary. TBR=haraken Bug: 729800 Change-Id: Iaa62b5a51cc79b19cb567be30a2f0dda54e326d8 Reviewed-on: https://chromium-review.googlesource.com/1117868 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571736} | 30 June 2018, 02:06:41 UTC |
| a2027fd | Mrunal Kapade | 30 June 2018, 00:46:03 UTC | Remove duplicate test keyboard-map-two-parallel-requests.https.html navigator-keyboard-map-two-parallel-requests.https.html also does same thing. BUG= Change-Id: If5acfe46aada93528f8821030996a9745bc19168 Reviewed-on: https://chromium-review.googlesource.com/1121346 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Cr-Commit-Position: refs/heads/master@{#571723} | 30 June 2018, 00:54:55 UTC |
| ec35b03 | Rune Lillesveen | 29 June 2018, 22:17:37 UTC | [Squad] Generate ::before/::after/::backdrop in style recalc. We used to create these pseudo elements and their computed styles in Element::AttachLayoutTree when building the layout tree. Now we create or dispose these elements from style recalc, that is, UpdatePseudoElement. To make pseudo elements live through a style recalc with a layout tree re-attach we no longer clear the pseudo elements during DetachLayoutTree for performing_reattach=true. We do however need to clear the pseudo elements which do not get a layout object for the re-attach. That is done in AttachLayoutTree for the originating element when the originating element does not generate a layout box. We stop using the pseudo style cache on ComputedStyle for PseudoElements and instead return the ComputedStyle when creating the pseudo element and store it as non-attached style which can later be retrieved when attaching the layout object. An effect of this change is that we can detect transitions on pseudo elements when ancestors display types changes and causes re-attachment. That is issue 836140. ::first-letter may still be generated during layout tree building, and the ::first-letter layout structure may still be updated during style recalc. Bug: 836126, 836140 Change-Id: Iafad705b7a7b988d4c1598e8a126ce0d79c5873d Reviewed-on: https://chromium-review.googlesource.com/1112244 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571665} | 29 June 2018, 22:26:52 UTC |
| c360ca0 | Koji Ishii | 29 June 2018, 21:50:07 UTC | [LayoutNG] Allow epsilon when fitting into a line When NGLineBreaker tries to fit items into a line, rounding errors are hard to avoid. One case is to fit `monospace` font into a container whose `width` is set by `ch` unit. Blink computes `ch` units in float, then round to LayoutUnit. This rounding often prevents the specified number of characters to fit into the line. All 4 impls pass this test for `3ch` to `100ch`. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9fe68a8bb44820aa15c7eb8c564776688c8320ee Reviewed-on: https://chromium-review.googlesource.com/1116409 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#571642} | 29 June 2018, 21:59:50 UTC |
| 8b8082f | jugglinmike | 29 June 2018, 17:28:24 UTC | [testdriver.js] Implement `bless` method (#11511) A common use case for the testdriver.js library is to create a task that was triggered by user interaction [1]. Doing so using the current API requires a fair amount of logic which is unrelated to the behavior under test. This has a number of drawbacks: - it makes tests less descriptive - it makes tests less uniform both in terms of implementation and in terms of user experience (in non-automated scenarios, human operators may be prompted to provide the necessary input) - it makes tests more susceptible to bugs Define a utility method as a consistent and concise way to facilitate the common use case. Require descriptive text via the `intent` parameter in order to encourage test authors to explicitly describe the rationale for requesting additional privileges. [1] https://html.spec.whatwg.org/#triggered-by-user-activation | 29 June 2018, 17:28:24 UTC |
| 02cfdfe | Rune Lillesveen | 29 June 2018, 16:53:44 UTC | Make sure stacking context is always updated for ::first-letter. ::first-letter sadly has at least three code paths for computing its computed style. Two of them were lacking stacking context update. There is work in progress for Squad to mend this, but let's fix the current code paths for now. Bug: 856806 Change-Id: Ifeea799643bfa266e58c948f476bc23481fcdd5e Reviewed-on: https://chromium-review.googlesource.com/1120249 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571512} | 29 June 2018, 17:11:19 UTC |
| 7706fe6 | Luke Bjerring | 29 June 2018, 16:07:09 UTC | Update trivial IDL changes (#11732) | 29 June 2018, 16:07:09 UTC |
