https://github.com/torvalds/linux
Revision d83c49f3e36cecd2e8823b6c48ffba083b8a5704 authored by Al Viro on 30 April 2010, 21:17:09 UTC, committed by Al Viro on 15 May 2010, 11:16:33 UTC
1) i_flags simply doesn't work for mount/unlink race prevention; we may have many links to file and rm on one of those obviously shouldn't prevent bind on top of another later on. To fix it right way we need to mark _dentry_ as unsuitable for mounting upon; new flag (DCACHE_CANT_MOUNT) is protected by d_flags and i_mutex on the inode in question. Set it (with dont_mount(dentry)) in unlink/rmdir/etc., check (with cant_mount(dentry)) in places in namespace.c that used to check for S_DEAD. Setting S_DEAD is still needed in places where we used to set it (for directories getting killed), since we rely on it for readdir/rmdir race prevention. 2) rename()/mount() protection has another bogosity - we unhash the target before we'd checked that it's not a mountpoint. Fixed. 3) ancient bogosity in pivot_root() - we locked i_mutex on the right directory, but checked S_DEAD on the different (and wrong) one. Noticed and fixed. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent 6a251b0
Tip revision: d83c49f3e36cecd2e8823b6c48ffba083b8a5704 authored by Al Viro on 30 April 2010, 21:17:09 UTC
Fix the regression created by "set S_DEAD on unlink()..." commit
Fix the regression created by "set S_DEAD on unlink()..." commit
Tip revision: d83c49f
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| firmware | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .gitignore | -rw-r--r-- | 930 bytes |
| .mailmap | -rw-r--r-- | 3.9 KB |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 91.8 KB |
| Kbuild | -rw-r--r-- | 2.4 KB |
| MAINTAINERS | -rw-r--r-- | 166.4 KB |
| Makefile | -rw-r--r-- | 51.9 KB |
| README | -rw-r--r-- | 17.0 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.3 KB |
Computing file changes ...
