Revision d9724772e69cb8076231202292665ca74eec13e1 authored by Or Gerlitz on 22 December 2016, 12:28:15 UTC, committed by David S. Miller on 23 December 2016, 16:59:56 UTC
When matching on flags, we should require the user to provide the
mask and avoid using an all-ones mask. Not doing so causes matching
on flags provided w.o mask to hit on the value being unset for all
flags, which may not what the user wanted to happen.
Fixes: faa3ffce7829 ('net/sched: cls_flower: Add support for matching on flags')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reported-by: Paul Blakey <paulb@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent dc594ec
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 6.3 KB |
| README.rst | -rw-r--r-- | 1.9 KB |
| bpf_helpers.h | -rw-r--r-- | 6.1 KB |
| bpf_load.c | -rw-r--r-- | 12.4 KB |
| bpf_load.h | -rw-r--r-- | 921 bytes |
| cgroup_helpers.c | -rw-r--r-- | 4.4 KB |
| cgroup_helpers.h | -rw-r--r-- | 436 bytes |
| fds_example.c | -rw-r--r-- | 4.0 KB |
| lathist_kern.c | -rw-r--r-- | 2.1 KB |
| lathist_user.c | -rw-r--r-- | 2.0 KB |
| libbpf.c | -rw-r--r-- | 3.9 KB |
| libbpf.h | -rw-r--r-- | 5.6 KB |
| lwt_len_hist.sh | -rw-r--r-- | 921 bytes |
| lwt_len_hist_kern.c | -rw-r--r-- | 1.8 KB |
| lwt_len_hist_user.c | -rw-r--r-- | 1.6 KB |
| map_perf_test_kern.c | -rw-r--r-- | 3.3 KB |
| map_perf_test_user.c | -rw-r--r-- | 4.0 KB |
| offwaketime_kern.c | -rw-r--r-- | 3.5 KB |
| offwaketime_user.c | -rw-r--r-- | 2.4 KB |
| parse_ldabs.c | -rw-r--r-- | 1.2 KB |
| parse_simple.c | -rw-r--r-- | 1.3 KB |
| parse_varlen.c | -rw-r--r-- | 3.5 KB |
| sampleip_kern.c | -rw-r--r-- | 924 bytes |
| sampleip_user.c | -rw-r--r-- | 4.2 KB |
| sock_example.c | -rw-r--r-- | 2.7 KB |
| sock_flags_kern.c | -rw-r--r-- | 986 bytes |
| sockex1_kern.c | -rw-r--r-- | 648 bytes |
| sockex1_user.c | -rw-r--r-- | 979 bytes |
| sockex2_kern.c | -rw-r--r-- | 4.7 KB |
| sockex2_user.c | -rw-r--r-- | 1.0 KB |
| sockex3_kern.c | -rw-r--r-- | 6.1 KB |
| sockex3_user.c | -rw-r--r-- | 1.4 KB |
| spintest_kern.c | -rw-r--r-- | 2.1 KB |
| spintest_user.c | -rw-r--r-- | 1.0 KB |
| tc_l2_redirect.sh | -rwxr-xr-x | 4.9 KB |
| tc_l2_redirect_kern.c | -rw-r--r-- | 6.0 KB |
| tc_l2_redirect_user.c | -rw-r--r-- | 1.5 KB |
| tcbpf1_kern.c | -rw-r--r-- | 2.5 KB |
| tcbpf2_kern.c | -rw-r--r-- | 8.1 KB |
| test_cgrp2_array_pin.c | -rw-r--r-- | 2.2 KB |
| test_cgrp2_attach.c | -rw-r--r-- | 4.4 KB |
| test_cgrp2_attach2.c | -rw-r--r-- | 2.6 KB |
| test_cgrp2_sock.c | -rw-r--r-- | 1.8 KB |
| test_cgrp2_sock.sh | -rwxr-xr-x | 1.0 KB |
| test_cgrp2_sock2.c | -rw-r--r-- | 1.3 KB |
| test_cgrp2_sock2.sh | -rwxr-xr-x | 1.4 KB |
| test_cgrp2_tc.sh | -rwxr-xr-x | 4.1 KB |
| test_cgrp2_tc_kern.c | -rw-r--r-- | 1.8 KB |
| test_cls_bpf.sh | -rwxr-xr-x | 880 bytes |
| test_current_task_under_cgroup_kern.c | -rw-r--r-- | 1.1 KB |
| test_current_task_under_cgroup_user.c | -rw-r--r-- | 1.7 KB |
| test_ipip.sh | -rwxr-xr-x | 5.6 KB |
| test_lru_dist.c | -rw-r--r-- | 12.0 KB |
| test_lwt_bpf.c | -rw-r--r-- | 6.0 KB |
| test_lwt_bpf.sh | -rw-r--r-- | 8.9 KB |
| test_overhead_kprobe_kern.c | -rw-r--r-- | 1.0 KB |
| test_overhead_tp_kern.c | -rw-r--r-- | 828 bytes |
| test_overhead_user.c | -rw-r--r-- | 3.2 KB |
| test_probe_write_user_kern.c | -rw-r--r-- | 1.6 KB |
| test_probe_write_user_user.c | -rw-r--r-- | 2.4 KB |
| test_tunnel_bpf.sh | -rwxr-xr-x | 4.2 KB |
| trace_event_kern.c | -rw-r--r-- | 1.7 KB |
| trace_event_user.c | -rw-r--r-- | 4.6 KB |
| trace_output_kern.c | -rw-r--r-- | 609 bytes |
| trace_output_user.c | -rw-r--r-- | 4.0 KB |
| tracex1_kern.c | -rw-r--r-- | 1.4 KB |
| tracex1_user.c | -rw-r--r-- | 403 bytes |
| tracex2_kern.c | -rw-r--r-- | 2.3 KB |
| tracex2_user.c | -rw-r--r-- | 3.0 KB |
| tracex3_kern.c | -rw-r--r-- | 2.1 KB |
| tracex3_user.c | -rw-r--r-- | 3.1 KB |
| tracex4_kern.c | -rw-r--r-- | 1.2 KB |
| tracex4_user.c | -rw-r--r-- | 1.4 KB |
| tracex5_kern.c | -rw-r--r-- | 1.9 KB |
| tracex5_user.c | -rw-r--r-- | 1.1 KB |
| tracex6_kern.c | -rw-r--r-- | 611 bytes |
| tracex6_user.c | -rw-r--r-- | 1.4 KB |
| xdp1_kern.c | -rw-r--r-- | 2.1 KB |
| xdp1_user.c | -rw-r--r-- | 1.7 KB |
| xdp2_kern.c | -rw-r--r-- | 2.4 KB |
| xdp_tx_iptunnel_common.h | -rw-r--r-- | 634 bytes |
| xdp_tx_iptunnel_kern.c | -rw-r--r-- | 5.6 KB |
| xdp_tx_iptunnel_user.c | -rw-r--r-- | 5.9 KB |
Computing file changes ...
