Revision d98e56315d308c2b427b62b5dc8b55d91ad36428 authored by Abhishek Kona on 10 May 2013, 20:19:39 UTC, committed by Abhishek Kona on 10 May 2013, 20:19:39 UTC
Summary:
Our ticker was not atomic. This was based on the assumption that we will increment counts at places only protected by Mutex. This is hard to program for and easy to make mistakes (mutex may be held a few layers above etc).
Also this increases the instructions executed when the mutex is held.

Test Plan: make check

Reviewers: haobo, dhruba

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D10569
1 parent 85cccc5
History
File Mode Size
VALGRIND_LOGS
db
doc
hdfs
helpers
include
java
linters
port
scribe
snappy
table
thrift
tools
util
utilities
.arcconfig -rw-r--r-- 243 bytes
.gitignore -rw-r--r-- 174 bytes
LICENSE -rw-r--r-- 1.4 KB
Makefile -rw-r--r-- 11.1 KB
README -rw-r--r-- 2.2 KB
README.fb -rw-r--r-- 98 bytes
build_detect_platform -rwxr-xr-x 8.9 KB
build_detect_version -rwxr-xr-x 1.2 KB
build_java.sh -rwxr-xr-x 1.9 KB
e -rw-r--r-- 51 bytes
fbcode.clang31.sh -rw-r--r-- 3.1 KB
fbcode.gcc471.sh -rw-r--r-- 2.9 KB
regression_build_test.sh -rwxr-xr-x 2.3 KB
valgrind_test.sh -rwxr-xr-x 428 bytes

README

back to top