Revision d9a9f4849fe0c9d560851ab22a85a666cddfdd24 authored by Al Viro on 12 March 2020, 22:25:20 UTC, committed by Al Viro on 12 March 2020, 22:25:20 UTC
several iterations of ->atomic_open() calling conventions ago, we used to need fput() if ->atomic_open() failed at some point after successful finish_open(). Now (since 2016) it's not needed - struct file carries enough state to make fput() work regardless of the point in struct file lifecycle and discarding it on failure exits in open() got unified. Unfortunately, I'd missed the fact that we had an instance of ->atomic_open() (cifs one) that used to need that fput(), as well as the stale comment in finish_open() demanding such late failure handling. Trivially fixed... Fixes: fe9ec8291fca "do_last(): take fput() on error after opening to out:" Cc: stable@kernel.org # v4.7+ Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent 2103913
File | Mode | Size |
---|---|---|
mdev | ||
pci | ||
platform | ||
Kconfig | -rw-r--r-- | 1.4 KB |
Makefile | -rw-r--r-- | 402 bytes |
vfio.c | -rw-r--r-- | 55.3 KB |
vfio_iommu_spapr_tce.c | -rw-r--r-- | 32.1 KB |
vfio_iommu_type1.c | -rw-r--r-- | 57.0 KB |
vfio_spapr_eeh.c | -rw-r--r-- | 2.6 KB |
virqfd.c | -rw-r--r-- | 5.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...