Revision - d9d5420 - mlxsw: spectrum_router: Remove inappropriate usage of WARN_ON() - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

16 September 2024, 20:19:31 UTC

Revision d9d5420273997664a1c09151ca86ac993f2f89c1 authored by Ido Schimmel on 10 July 2020, 13:41:38 UTC, committed by David S. Miller on 10 July 2020, 21:33:34 UTC

mlxsw: spectrum_router: Remove inappropriate usage of WARN_ON()

We should not trigger a warning when a memory allocation fails. Remove
the WARN_ON().

The warning is constantly triggered by syzkaller when it is injecting
faults:

[ 2230.758664] FAULT_INJECTION: forcing a failure.
[ 2230.758664] name failslab, interval 1, probability 0, space 0, times 0
[ 2230.762329] CPU: 3 PID: 1407 Comm: syz-executor.0 Not tainted 5.8.0-rc2+ #28
...
[ 2230.898175] WARNING: CPU: 3 PID: 1407 at drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:6265 mlxsw_sp_router_fib_event+0xfad/0x13e0
[ 2230.898179] Kernel panic - not syncing: panic_on_warn set ...
[ 2230.898183] CPU: 3 PID: 1407 Comm: syz-executor.0 Not tainted 5.8.0-rc2+ #28
[ 2230.898190] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014

Fixes: 3057224e014c ("mlxsw: spectrum_router: Implement FIB offload in deferred work")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 parent f9f41e3

Files
Changes

Permalinks

Tip revision: d9d5420273997664a1c09151ca86ac993f2f89c1 authored by Ido Schimmel on 10 July 2020, 13:41:38 UTC
mlxsw: spectrum_router: Remove inappropriate usage of WARN_ON()

Tip revision: d9d5420

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	15.8 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	71 bytes
.gitattributes	-rw-r--r--	62 bytes
.gitignore	-rw-r--r--	1.8 KB
.mailmap	-rw-r--r--	15.4 KB
COPYING	-rw-r--r--	496 bytes
CREDITS	-rw-r--r--	97.4 KB
Kbuild	-rw-r--r--	1.3 KB
Kconfig	-rw-r--r--	555 bytes
MAINTAINERS	-rw-r--r--	547.8 KB
Makefile	-rw-r--r--	60.4 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

mlxsw: spectrum_router: Remove inappropriate usage of WARN_ON()

README