Skip to main content

Browse the archive

Revision da1fbed3fff6ed2d64399ff26d8a9ab3bcf00540 authored by Johannes Sixt on 30 March 2010, 17:36:03 UTC, committed by Junio C Hamano on 30 March 2010, 21:46:33 UTC 
diff: fix textconv error zombies
 
To make the code simpler, run_textconv lumps all of its
error checking into one conditional. However, the
short-circuit means that an error in reading will prevent us
from calling finish_command, leaving a zombie child.
Clean up properly after errors.

Based-on-work-by: Jeff King <peff@peff.net>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 657ab61
Raw File
fetch-pack.h 
#ifndef FETCH_PACK_H
#define FETCH_PACK_H

struct fetch_pack_args
{
	const char *uploadpack;
	int unpacklimit;
	int depth;
	unsigned quiet:1,
		keep_pack:1,
		lock_pack:1,
		use_thin_pack:1,
		fetch_all:1,
		verbose:1,
		no_progress:1,
		include_tag:1,
		stateless_rpc:1;
};

struct ref *fetch_pack(struct fetch_pack_args *args,
		int fd[], struct child_process *conn,
		const struct ref *ref,
		const char *dest,
		int nr_heads,
		char **heads,
		char **pack_lockfile);

#endif
back to top