Revision da353fac65fede6b8b4cfe207f0d9408e3121105 authored by Daniel Jordan on 27 October 2021, 21:59:20 UTC, committed by David S. Miller on 28 October 2021, 13:41:20 UTC
sk->sk_err appears to expect a positive value, a convention that ktls doesn't always follow and that leads to memory corruption in other code. For instance, [kworker] tls_encrypt_done(..., err=<negative error from crypto request>) tls_err_abort(.., err) sk->sk_err = err; [task] splice_from_pipe_feed ... tls_sw_do_sendpage if (sk->sk_err) { ret = -sk->sk_err; // ret is positive splice_from_pipe_feed (continued) ret = actor(...) // ret is still positive and interpreted as bytes // written, resulting in underflow of buf->len and // sd->len, leading to huge buf->offset and bogus // addresses computed in later calls to actor() Fix all tls_err_abort() callers to pass a negative error code consistently and centralize the error-prone sign flip there, throwing in a warning to catch future misuse and uninlining the function so it really does only warn once. Cc: stable@vger.kernel.org Fixes: c46234ebb4d1e ("tls: RX path for ktls") Reported-by: syzbot+b187b77c8474f9648fae@syzkaller.appspotmail.com Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a32f07d
File | Mode | Size |
---|---|---|
aoe | ||
drbd | ||
mtip32xx | ||
null_blk | ||
paride | ||
rnbd | ||
rsxx | ||
xen-blkback | ||
zram | ||
Kconfig | -rw-r--r-- | 14.9 KB |
Makefile | -rw-r--r-- | 1.3 KB |
amiflop.c | -rw-r--r-- | 50.2 KB |
ataflop.c | -rw-r--r-- | 55.2 KB |
brd.c | -rw-r--r-- | 12.6 KB |
cryptoloop.c | -rw-r--r-- | 4.4 KB |
floppy.c | -rw-r--r-- | 133.6 KB |
loop.c | -rw-r--r-- | 66.4 KB |
loop.h | -rw-r--r-- | 2.6 KB |
n64cart.c | -rw-r--r-- | 3.8 KB |
nbd.c | -rw-r--r-- | 62.7 KB |
pktcdvd.c | -rw-r--r-- | 71.8 KB |
ps3disk.c | -rw-r--r-- | 13.0 KB |
ps3vram.c | -rw-r--r-- | 21.7 KB |
rbd.c | -rw-r--r-- | 183.4 KB |
rbd_types.h | -rw-r--r-- | 2.5 KB |
sunvdc.c | -rw-r--r-- | 28.3 KB |
swim.c | -rw-r--r-- | 19.4 KB |
swim3.c | -rw-r--r-- | 31.6 KB |
swim_asm.S | -rw-r--r-- | 4.4 KB |
sx8.c | -rw-r--r-- | 37.0 KB |
virtio_blk.c | -rw-r--r-- | 25.6 KB |
xen-blkfront.c | -rw-r--r-- | 71.0 KB |
z2ram.c | -rw-r--r-- | 9.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...