Revision da353fac65fede6b8b4cfe207f0d9408e3121105 authored by Daniel Jordan on 27 October 2021, 21:59:20 UTC, committed by David S. Miller on 28 October 2021, 13:41:20 UTC
sk->sk_err appears to expect a positive value, a convention that ktls doesn't always follow and that leads to memory corruption in other code. For instance, [kworker] tls_encrypt_done(..., err=<negative error from crypto request>) tls_err_abort(.., err) sk->sk_err = err; [task] splice_from_pipe_feed ... tls_sw_do_sendpage if (sk->sk_err) { ret = -sk->sk_err; // ret is positive splice_from_pipe_feed (continued) ret = actor(...) // ret is still positive and interpreted as bytes // written, resulting in underflow of buf->len and // sd->len, leading to huge buf->offset and bogus // addresses computed in later calls to actor() Fix all tls_err_abort() callers to pass a negative error code consistently and centralize the error-prone sign flip there, throwing in a warning to catch future misuse and uninlining the function so it really does only warn once. Cc: stable@vger.kernel.org Fixes: c46234ebb4d1e ("tls: RX path for ktls") Reported-by: syzbot+b187b77c8474f9648fae@syzkaller.appspotmail.com Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a32f07d
File | Mode | Size |
---|---|---|
.kunitconfig | -rw-r--r-- | 90 bytes |
Kconfig | -rw-r--r-- | 5.0 KB |
Makefile | -rw-r--r-- | 338 bytes |
cache.c | -rw-r--r-- | 9.4 KB |
dir.c | -rw-r--r-- | 35.0 KB |
fat.h | -rw-r--r-- | 15.2 KB |
fat_test.c | -rw-r--r-- | 4.8 KB |
fatent.c | -rw-r--r-- | 20.6 KB |
file.c | -rw-r--r-- | 14.4 KB |
inode.c | -rw-r--r-- | 51.1 KB |
misc.c | -rw-r--r-- | 9.7 KB |
namei_msdos.c | -rw-r--r-- | 16.9 KB |
namei_vfat.c | -rw-r--r-- | 25.5 KB |
nfs.c | -rw-r--r-- | 7.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...