Revision da353fac65fede6b8b4cfe207f0d9408e3121105 authored by Daniel Jordan on 27 October 2021, 21:59:20 UTC, committed by David S. Miller on 28 October 2021, 13:41:20 UTC
sk->sk_err appears to expect a positive value, a convention that ktls doesn't always follow and that leads to memory corruption in other code. For instance, [kworker] tls_encrypt_done(..., err=<negative error from crypto request>) tls_err_abort(.., err) sk->sk_err = err; [task] splice_from_pipe_feed ... tls_sw_do_sendpage if (sk->sk_err) { ret = -sk->sk_err; // ret is positive splice_from_pipe_feed (continued) ret = actor(...) // ret is still positive and interpreted as bytes // written, resulting in underflow of buf->len and // sd->len, leading to huge buf->offset and bogus // addresses computed in later calls to actor() Fix all tls_err_abort() callers to pass a negative error code consistently and centralize the error-prone sign flip there, throwing in a warning to catch future misuse and uninlining the function so it really does only warn once. Cc: stable@vger.kernel.org Fixes: c46234ebb4d1e ("tls: RX path for ktls") Reported-by: syzbot+b187b77c8474f9648fae@syzkaller.appspotmail.com Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a32f07d
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 5.5 KB |
LICENCE | -rw-r--r-- | 1.4 KB |
Makefile | -rw-r--r-- | 786 bytes |
README.Locking | -rw-r--r-- | 6.9 KB |
acl.c | -rw-r--r-- | 6.8 KB |
acl.h | -rw-r--r-- | 1015 bytes |
background.c | -rw-r--r-- | 4.2 KB |
build.c | -rw-r--r-- | 12.6 KB |
compr.c | -rw-r--r-- | 11.6 KB |
compr.h | -rw-r--r-- | 3.1 KB |
compr_lzo.c | -rw-r--r-- | 2.2 KB |
compr_rtime.c | -rw-r--r-- | 2.9 KB |
compr_rubin.c | -rw-r--r-- | 8.7 KB |
compr_zlib.c | -rw-r--r-- | 5.5 KB |
debug.c | -rw-r--r-- | 25.6 KB |
debug.h | -rw-r--r-- | 8.3 KB |
dir.c | -rw-r--r-- | 23.0 KB |
erase.c | -rw-r--r-- | 13.4 KB |
file.c | -rw-r--r-- | 9.1 KB |
fs.c | -rw-r--r-- | 19.4 KB |
gc.c | -rw-r--r-- | 44.0 KB |
ioctl.c | -rw-r--r-- | 557 bytes |
jffs2_fs_i.h | -rw-r--r-- | 1.6 KB |
jffs2_fs_sb.h | -rw-r--r-- | 5.7 KB |
malloc.c | -rw-r--r-- | 7.3 KB |
nodelist.c | -rw-r--r-- | 21.3 KB |
nodelist.h | -rw-r--r-- | 17.9 KB |
nodemgmt.c | -rw-r--r-- | 28.4 KB |
os-linux.h | -rw-r--r-- | 7.4 KB |
read.c | -rw-r--r-- | 6.7 KB |
readinode.c | -rw-r--r-- | 43.2 KB |
scan.c | -rw-r--r-- | 35.3 KB |
security.c | -rw-r--r-- | 2.0 KB |
summary.c | -rw-r--r-- | 23.7 KB |
summary.h | -rw-r--r-- | 6.4 KB |
super.c | -rw-r--r-- | 10.6 KB |
symlink.c | -rw-r--r-- | 417 bytes |
wbuf.c | -rw-r--r-- | 36.9 KB |
write.c | -rw-r--r-- | 21.0 KB |
writev.c | -rw-r--r-- | 1.1 KB |
xattr.c | -rw-r--r-- | 38.3 KB |
xattr.h | -rw-r--r-- | 4.1 KB |
xattr_trusted.c | -rw-r--r-- | 1.2 KB |
xattr_user.c | -rw-r--r-- | 1.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...