Revision da353fac65fede6b8b4cfe207f0d9408e3121105 authored by Daniel Jordan on 27 October 2021, 21:59:20 UTC, committed by David S. Miller on 28 October 2021, 13:41:20 UTC
sk->sk_err appears to expect a positive value, a convention that ktls doesn't always follow and that leads to memory corruption in other code. For instance, [kworker] tls_encrypt_done(..., err=<negative error from crypto request>) tls_err_abort(.., err) sk->sk_err = err; [task] splice_from_pipe_feed ... tls_sw_do_sendpage if (sk->sk_err) { ret = -sk->sk_err; // ret is positive splice_from_pipe_feed (continued) ret = actor(...) // ret is still positive and interpreted as bytes // written, resulting in underflow of buf->len and // sd->len, leading to huge buf->offset and bogus // addresses computed in later calls to actor() Fix all tls_err_abort() callers to pass a negative error code consistently and centralize the error-prone sign flip there, throwing in a warning to catch future misuse and uninlining the function so it really does only warn once. Cc: stable@vger.kernel.org Fixes: c46234ebb4d1e ("tls: RX path for ktls") Reported-by: syzbot+b187b77c8474f9648fae@syzkaller.appspotmail.com Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a32f07d
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 381 bytes |
clnt4xdr.c | -rw-r--r-- | 12.9 KB |
clntlock.c | -rw-r--r-- | 7.5 KB |
clntproc.c | -rw-r--r-- | 21.7 KB |
clntxdr.c | -rw-r--r-- | 13.2 KB |
host.c | -rw-r--r-- | 17.5 KB |
mon.c | -rw-r--r-- | 14.4 KB |
netns.h | -rw-r--r-- | 395 bytes |
procfs.c | -rw-r--r-- | 1.9 KB |
procfs.h | -rw-r--r-- | 474 bytes |
svc.c | -rw-r--r-- | 20.5 KB |
svc4proc.c | -rw-r--r-- | 18.8 KB |
svclock.c | -rw-r--r-- | 27.3 KB |
svcproc.c | -rw-r--r-- | 19.5 KB |
svcshare.c | -rw-r--r-- | 2.4 KB |
svcsubs.c | -rw-r--r-- | 11.2 KB |
svcxdr.h | -rw-r--r-- | 2.8 KB |
xdr.c | -rw-r--r-- | 7.7 KB |
xdr4.c | -rw-r--r-- | 7.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...