Revision da353fac65fede6b8b4cfe207f0d9408e3121105 authored by Daniel Jordan on 27 October 2021, 21:59:20 UTC, committed by David S. Miller on 28 October 2021, 13:41:20 UTC
sk->sk_err appears to expect a positive value, a convention that ktls doesn't always follow and that leads to memory corruption in other code. For instance, [kworker] tls_encrypt_done(..., err=<negative error from crypto request>) tls_err_abort(.., err) sk->sk_err = err; [task] splice_from_pipe_feed ... tls_sw_do_sendpage if (sk->sk_err) { ret = -sk->sk_err; // ret is positive splice_from_pipe_feed (continued) ret = actor(...) // ret is still positive and interpreted as bytes // written, resulting in underflow of buf->len and // sd->len, leading to huge buf->offset and bogus // addresses computed in later calls to actor() Fix all tls_err_abort() callers to pass a negative error code consistently and centralize the error-prone sign flip there, throwing in a warning to catch future misuse and uninlining the function so it really does only warn once. Cc: stable@vger.kernel.org Fixes: c46234ebb4d1e ("tls: RX path for ktls") Reported-by: syzbot+b187b77c8474f9648fae@syzkaller.appspotmail.com Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a32f07d
File | Mode | Size |
---|---|---|
platform | ||
acbuffer.h | -rw-r--r-- | 8.9 KB |
acconfig.h | -rw-r--r-- | 7.4 KB |
acexcep.h | -rw-r--r-- | 16.9 KB |
acnames.h | -rw-r--r-- | 2.2 KB |
acoutput.h | -rw-r--r-- | 16.4 KB |
acpi.h | -rw-r--r-- | 1.3 KB |
acpi_bus.h | -rw-r--r-- | 20.4 KB |
acpi_drivers.h | -rw-r--r-- | 2.6 KB |
acpi_io.h | -rw-r--r-- | 723 bytes |
acpi_lpat.h | -rw-r--r-- | 1.2 KB |
acpi_numa.h | -rw-r--r-- | 970 bytes |
acpiosxf.h | -rw-r--r-- | 11.3 KB |
acpixf.h | -rw-r--r-- | 30.6 KB |
acrestyp.h | -rw-r--r-- | 19.0 KB |
actbl.h | -rw-r--r-- | 18.3 KB |
actbl1.h | -rw-r--r-- | 43.1 KB |
actbl2.h | -rw-r--r-- | 57.1 KB |
actbl3.h | -rw-r--r-- | 21.9 KB |
actypes.h | -rw-r--r-- | 41.3 KB |
acuuid.h | -rw-r--r-- | 3.4 KB |
apei.h | -rw-r--r-- | 1.3 KB |
battery.h | -rw-r--r-- | 594 bytes |
button.h | -rw-r--r-- | 401 bytes |
cppc_acpi.h | -rw-r--r-- | 4.2 KB |
ghes.h | -rw-r--r-- | 3.6 KB |
hed.h | -rw-r--r-- | 370 bytes |
nfit.h | -rw-r--r-- | 351 bytes |
pcc.h | -rw-r--r-- | 651 bytes |
pdc_intel.h | -rw-r--r-- | 1.0 KB |
processor.h | -rw-r--r-- | 11.7 KB |
reboot.h | -rw-r--r-- | 201 bytes |
video.h | -rw-r--r-- | 2.8 KB |
Computing file changes ...