Skip to main content

Browse the archive

https://github.com/halide/Halide
17 June 2024, 21:58:48 UTC
Revision da7c66e895cbaa3eccc36fd65fd29f7e5a57a311 authored by Steven Johnson on 04 October 2021, 16:33:15 UTC, committed by GitHub on 04 October 2021, 16:33:15 UTC 
Make parking_control (etc) use vtables (#6275)
 
* Make parking_control (etc) use vtables

This class hierarchy is clearly best modeled with virtual methods (rather than fn ptrs), but was not; we *think* this was due to COMDAT issues that have been resolved by other means. I refactored this to use virtual methods instead (and removed the unused unpark_all function); it seems to work locally.

* Add -fno-rtti to runtime compile flags (needed to allow vtables in runtime code)

* make all overrides 'final'

* Make virtual methods protected

* Make structs final too

* pacify clang-tidy
1 parent 2495bcc
History
Tip revision: da7c66e895cbaa3eccc36fd65fd29f7e5a57a311 authored by Steven Johnson on 04 October 2021, 16:33:15 UTC
Make parking_control (etc) use vtables (#6275)
Tip revision: da7c66e
File Mode Size
.github
apps
cmake
dependencies
doc
packaging
python_bindings
src
test
tools
tutorial
util
.clang-format -rw-r--r-- 1.4 KB
.clang-format-ignore -rw-r--r-- 265 bytes
.clang-tidy -rw-r--r-- 1.8 KB
.gitattributes -rw-r--r-- 342 bytes
.gitignore -rw-r--r-- 1.1 KB
.gitmodules -rw-r--r-- 0 bytes
CMakeLists.txt -rw-r--r-- 5.5 KB
CMakePresets.json -rw-r--r-- 5.2 KB
CODE_OF_CONDUCT.md -rw-r--r-- 3.5 KB
LICENSE.txt -rw-r--r-- 3.2 KB
Makefile -rw-r--r-- 100.9 KB
README.md -rw-r--r-- 16.5 KB
README_cmake.md -rw-r--r-- 69.3 KB
README_rungen.md -rw-r--r-- 12.1 KB
README_webassembly.md -rw-r--r-- 8.6 KB
run-clang-format.sh -rwxr-xr-x 1.4 KB
run-clang-tidy.sh -rwxr-xr-x 3.2 KB

README.md

back to top