Skip to main content

Browse the archive

Revision da98f5f51e52bd0f9b37b399631a28e4c97ac695 authored by Antoine R. Dumont (@ardumont) on 12 March 2020, 18:54:21 UTC, committed by Antoine R. Dumont (@ardumont) on 13 March 2020, 13:09:42 UTC 
origin_visit_add: Adapt endpoint signature to return OriginVisit
 
Prior to this commit, there was:
- no signature in the method
- discrepancy between checks on the different backend

origin_visit_add endpoint is now typed
```
def origin_visit_add(
    self, origin_url: str,
    date: Union[str, datetime.datetime], type: str) -> OriginVisit:
```

This also:
- renames appropriately the origin_url parameter (removing 1 FIXME)
- align backend implementations' check which were different
1 parent 0456cce
Raw File
mypy.ini 
[mypy]
namespace_packages = True

# due to the conditional import logic on swh.journal, in some cases a specific
# type: ignore is needed, in other it isn't...
warn_unused_ignores = False

# support for sqlalchemy magic: see https://github.com/dropbox/sqlalchemy-stubs
plugins = sqlmypy


# 3rd party libraries without stubs (yet)

[mypy-cassandra.*]
ignore_missing_imports = True

# only shipped indirectly via hypothesis
[mypy-django.*]
ignore_missing_imports = True

[mypy-pkg_resources.*]
ignore_missing_imports = True

[mypy-psycopg2.*]
ignore_missing_imports = True

[mypy-pytest.*]
ignore_missing_imports = True

[mypy-tenacity.*]
ignore_missing_imports = True

# temporary work-around for landing typing support in spite of the current
# journal<->storage dependency loop
[mypy-swh.journal.*]
ignore_missing_imports = True

[mypy-pytest_postgresql.*]
ignore_missing_imports = True
back to top