Skip to main content

Browse the archive

Revision dae3b5545c556e2479972a21d1ed8850aac0bae8 authored by anand76 on 28 March 2019, 22:13:02 UTC, committed by Facebook Github Bot on 28 March 2019, 22:17:13 UTC 
Smooth the deletion of WAL files (#5116)
 
Summary:
WAL files are currently not subject to deletion rate limiting by DeleteScheduler. If the size of the WAL files is significant, this can cause a high delete rate on SSDs that may affect other operations. To fix it, force WAL file deletions to go through the SstFileManager. Original PR for this is #2768
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5116

Differential Revision: D14669437

Pulled By: anand1976

fbshipit-source-id: c5f62d0640cebaa1574de841a1d01e4ce2faadf0
1 parent a98317f
Raw File
defs.bzl 
load("@fbcode_macros//build_defs:cpp_binary.bzl", "cpp_binary")
load("@fbcode_macros//build_defs:custom_unittest.bzl", "custom_unittest")

def test_binary(
        test_name,
        test_cc,
        parallelism,
        rocksdb_arch_preprocessor_flags,
        rocksdb_compiler_flags,
        rocksdb_preprocessor_flags,
        rocksdb_external_deps):
    TEST_RUNNER = native.package_name() + "/buckifier/rocks_test_runner.sh"

    ttype = "gtest" if parallelism == "parallel" else "simple"
    test_bin = test_name + "_bin"

    cpp_binary(
        name = test_bin,
        srcs = [test_cc],
        arch_preprocessor_flags = rocksdb_arch_preprocessor_flags,
        compiler_flags = rocksdb_compiler_flags,
        preprocessor_flags = rocksdb_preprocessor_flags,
        deps = [":rocksdb_test_lib"],
        external_deps = rocksdb_external_deps,
    )

    custom_unittest(
        name = test_name,
        command = [TEST_RUNNER, "$(location :{})".format(test_bin)],
        type = ttype,
    )
back to top