Revision dba72cb30b6a4811038128c8a98b268d18ca60fe authored by Holger Hoffstätte on 17 November 2015, 11:29:32 UTC, committed by Chris Mason on 25 November 2015, 13:27:33 UTC
There's a regression in 4.4-rc since commit bc3094673f22
(btrfs: extend balance filter usage to take minimum and maximum) in that
existing (non-ranged) balance with -dusage=x no longer works; all chunks
are skipped.

After staring at the code for a while and wondering why a non-ranged
balance would even need min and max thresholds (..which then were not
set correctly, leading to the bug) I realized that the only problem
was the fact that the filter functions were named wrong, thanks to
patching copypasta. Simply renaming both functions lets the existing
btrfs-progs call balance with -dusage=x and now the non-ranged filter
function is invoked, properly using only a single chunk limit.

Signed-off-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com>
Fixes: bc3094673f22 ("btrfs: extend balance filter usage to take minimum and maximum")
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
1 parent 82bd101
History
File Mode Size
apparmor
integrity
keys
selinux
smack
tomoyo
yama
Kconfig -rw-r--r-- 5.6 KB
Makefile -rw-r--r-- 900 bytes
commoncap.c -rw-r--r-- 31.2 KB
device_cgroup.c -rw-r--r-- 21.0 KB
inode.c -rw-r--r-- 6.5 KB
lsm_audit.c -rw-r--r-- 9.9 KB
min_addr.c -rw-r--r-- 1.3 KB
security.c -rw-r--r-- 53.1 KB

back to top