Revision dc342a25d1b48cb53448fe0e5dde578edce3122c authored by Jonathan Nieder on 24 January 2013, 23:21:46 UTC, committed by Junio C Hamano on 25 January 2013, 18:41:49 UTC
An earlier conversion from fgets() to strbuf_getline() in the
codepath to read from /etc/mailname to learn the default host-part
of the ident e-mail address forgot that strbuf_getline() stores the
line at the beginning of the buffer just like fgets().

The "username@" the caller has prepared in the strbuf, expecting the
function to append the host-part to it, was lost because of this.

Reported-by: Mihai Rusu <dizzy@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 7e20105
History
File Mode Size
.gitignore -rw-r--r-- 42 bytes
Makefile -rw-r--r-- 207 bytes
README -rw-r--r-- 4.3 KB
aggregate.perl -rwxr-xr-x 3.7 KB
min_time.perl -rwxr-xr-x 348 bytes
p0000-perf-lib-sanity.sh -rwxr-xr-x 1002 bytes
p0001-rev-list.sh -rwxr-xr-x 262 bytes
p4000-diff-algorithms.sh -rwxr-xr-x 488 bytes
p5302-pack-index.sh -rwxr-xr-x 827 bytes
p7810-grep.sh -rwxr-xr-x 512 bytes
perf-lib.sh -rw-r--r-- 5.5 KB
run -rwxr-xr-x 1.5 KB

README

back to top