Revision dc342a25d1b48cb53448fe0e5dde578edce3122c authored by Jonathan Nieder on 24 January 2013, 23:21:46 UTC, committed by Junio C Hamano on 25 January 2013, 18:41:49 UTC
An earlier conversion from fgets() to strbuf_getline() in the
codepath to read from /etc/mailname to learn the default host-part
of the ident e-mail address forgot that strbuf_getline() stores the
line at the beginning of the buffer just like fgets().

The "username@" the caller has prepared in the strbuf, expecting the
function to append the host-part to it, was lost because of this.

Reported-by: Mihai Rusu <dizzy@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 7e20105
History
File Mode Size
t-apply-1.expect -rw-r--r-- 544 bytes
t-apply-1.patch -rw-r--r-- 5.5 KB
t-apply-2.expect -rw-r--r-- 218 bytes
t-apply-2.patch -rw-r--r-- 1.9 KB
t-apply-3.expect -rw-r--r-- 317 bytes
t-apply-3.patch -rw-r--r-- 12.8 KB
t-apply-4.expect -rw-r--r-- 193 bytes
t-apply-4.patch -rw-r--r-- 245 bytes
t-apply-5.expect -rw-r--r-- 885 bytes
t-apply-5.patch -rw-r--r-- 12.7 KB
t-apply-6.expect -rw-r--r-- 232 bytes
t-apply-6.patch -rw-r--r-- 2.3 KB
t-apply-7.expect -rw-r--r-- 292 bytes
t-apply-7.patch -rw-r--r-- 12.0 KB
t-apply-8.expect -rw-r--r-- 80 bytes
t-apply-8.patch -rw-r--r-- 245 bytes
t-apply-9.expect -rw-r--r-- 80 bytes
t-apply-9.patch -rw-r--r-- 245 bytes

back to top